[PATCH 1/3] Fix double free in guess_from_received_header().

2011-06-15 Thread Dmitry Kurochkin
Before the change, the last loop in guess_from_received_header()
did not reset domain and tld variables to NULL.  This leads to
double free error in some cases and possibly other bugs.
---
 notmuch-reply.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/notmuch-reply.c b/notmuch-reply.c
index 514bbc6..dab69e6 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -406,6 +406,7 @@ guess_from_received_header (notmuch_config_t *config, 
notmuch_message_t *message
/* Now extract the last two components of the MTA host name
 * as domain and tld.
 */
+   domain = tld = NULL;
while ((ptr = strsep (&token, delim)) != NULL) {
if (*ptr == '\0')
continue;
-- 
1.7.5.4



Re: [PATCH 1/3] Fix double free in guess_from_received_header().

2011-06-15 Thread Carl Worth
On Wed, 15 Jun 2011 15:12:12 +0400, Dmitry Kurochkin 
 wrote:
> Before the change, the last loop in guess_from_received_header()
> did not reset domain and tld variables to NULL.  This leads to
> double free error in some cases and possibly other bugs.

Thanks for the fixes. These are all pushed now.

-Carl

-- 
carl.d.wo...@intel.com


pgp4qktBR8WkW.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[PATCH 1/3] Fix double free in guess_from_received_header().

2011-06-15 Thread Carl Worth
On Wed, 15 Jun 2011 15:12:12 +0400, Dmitry Kurochkin  wrote:
> Before the change, the last loop in guess_from_received_header()
> did not reset domain and tld variables to NULL.  This leads to
> double free error in some cases and possibly other bugs.

Thanks for the fixes. These are all pushed now.

-Carl

-- 
carl.d.worth at intel.com
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 



[PATCH 1/3] Fix double free in guess_from_received_header().

2011-06-15 Thread Dmitry Kurochkin
Before the change, the last loop in guess_from_received_header()
did not reset domain and tld variables to NULL.  This leads to
double free error in some cases and possibly other bugs.
---
 notmuch-reply.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/notmuch-reply.c b/notmuch-reply.c
index 514bbc6..dab69e6 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -406,6 +406,7 @@ guess_from_received_header (notmuch_config_t *config, 
notmuch_message_t *message
/* Now extract the last two components of the MTA host name
 * as domain and tld.
 */
+   domain = tld = NULL;
while ((ptr = strsep (&token, delim)) != NULL) {
if (*ptr == '\0')
continue;
-- 
1.7.5.4

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch