[PATCH 1/3] lib: Kill last usage of C++ type bool

[Felipe Contreras]

On Tue, Jul 12, 2011 at 4:59 PM, Louis Rilling  wrote:
> Signed-off-by: Louis Rilling 
> ---
> ?lib/message.cc | ? 12 ++--
> ?1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lib/message.cc b/lib/message.cc
> index d993cde..cf651e5 100644
> --- a/lib/message.cc
> +++ b/lib/message.cc
> @@ -49,16 +49,16 @@ struct visible _notmuch_message {
> ?struct maildir_flag_tag {
> ? ? char flag;
> ? ? const char *tag;
> - ? ?bool inverse;
> + ? ?notmuch_bool_t inverse;

That's not C++, that's C99.

-- 
Felipe Contreras

[PATCH 1/3] lib: Kill last usage of C++ type bool

[Austin Clements]

Quoth Felipe Contreras on Jul 16 at  9:06 pm:
> On Tue, Jul 12, 2011 at 4:59 PM, Louis Rilling  wrote:
> > Signed-off-by: Louis Rilling 
> > ---
> > ?lib/message.cc | ? 12 ++--
> > ?1 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/lib/message.cc b/lib/message.cc
> > index d993cde..cf651e5 100644
> > --- a/lib/message.cc
> > +++ b/lib/message.cc
> > @@ -49,16 +49,16 @@ struct visible _notmuch_message {
> > ?struct maildir_flag_tag {
> > ? ? char flag;
> > ? ? const char *tag;
> > - ? ?bool inverse;
> > + ? ?notmuch_bool_t inverse;
> 
> That's not C++, that's C99.

Here it's C++.  But what's actually interesting is that this is the
only place where libnotmuch strays from completely consistent use of
notmuch_bool_t.

Re: [PATCH 1/3] lib: Kill last usage of C++ type bool

[Felipe Contreras]

On Tue, Jul 12, 2011 at 4:59 PM, Louis Rilling l.rill...@av7.net wrote:
 Signed-off-by: Louis Rilling l.rill...@av7.net
 ---
  lib/message.cc |   12 ++--
  1 files changed, 6 insertions(+), 6 deletions(-)

 diff --git a/lib/message.cc b/lib/message.cc
 index d993cde..cf651e5 100644
 --- a/lib/message.cc
 +++ b/lib/message.cc
 @@ -49,16 +49,16 @@ struct visible _notmuch_message {
  struct maildir_flag_tag {
     char flag;
     const char *tag;
 -    bool inverse;
 +    notmuch_bool_t inverse;

That's not C++, that's C99.

-- 
Felipe Contreras
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3] lib: Kill last usage of C++ type bool

[Louis Rilling]

Signed-off-by: Louis Rilling l.rill...@av7.net
---
 lib/message.cc |   12 ++--
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lib/message.cc b/lib/message.cc
index d993cde..cf651e5 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -49,16 +49,16 @@ struct visible _notmuch_message {
 struct maildir_flag_tag {
 char flag;
 const char *tag;
-bool inverse;
+notmuch_bool_t inverse;
 };
 
 /* ASCII ordered table of Maildir flags and associated tags */
 static struct maildir_flag_tag flag2tag[] = {
-{ 'D', draft,   false},
-{ 'F', flagged, false},
-{ 'P', passed,  false},
-{ 'R', replied, false},
-{ 'S', unread,  true }
+{ 'D', draft,   FALSE},
+{ 'F', flagged, FALSE},
+{ 'P', passed,  FALSE},
+{ 'R', replied, FALSE},
+{ 'S', unread,  TRUE }
 };
 
 /* We end up having to call the destructor explicitly because we had
-- 
1.7.2.5

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch