[PATCH 1/3] pep8 fixes

[Patrick Totzke]

Quoting Sebastian Spaeth (2012-01-02 16:23:05)
>Hi, just tried to apply but it doesn't apply cleanly anymore, can you
>update the patch to latest master? 

no need: you already pushed these three patches on Dec 6, if i'm not mistaken.
best,
/p

Re: [PATCH 1/3] pep8 fixes

[Sebastian Spaeth]

On Mon,  5 Dec 2011 21:12:33 +, Patrick Totzke 
patricktot...@googlemail.com wrote:
 no changes to the code, only fixed stuff denounced by `pep8 *py`

Hi, just tried to apply but it doesn't apply cleanly anymore, can you
update the patch to latest master? 

Sorry for letting this languish for so long.

Sebastian


pgp2XZaJQqris.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3] pep8 fixes

[Sebastian Spaeth]

On Mon,  5 Dec 2011 21:12:33 +, Patrick Totzke  wrote:
> no changes to the code, only fixed stuff denounced by `pep8 *py`

Hi, just tried to apply but it doesn't apply cleanly anymore, can you
update the patch to latest master? 

Sorry for letting this languish for so long.

Sebastian
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 

[PATCH 1/3] pep8 fixes

[Patrick Totzke]

no changes to the code, only fixed stuff denounced by `pep8 *py`
---
 bindings/python/notmuch/__init__.py |2 +-
 bindings/python/notmuch/database.py |   28 +++--
 bindings/python/notmuch/globals.py  |   38 +++---
 bindings/python/notmuch/thread.py   |1 -
 4 files changed, 52 insertions(+), 17 deletions(-)

diff --git a/bindings/python/notmuch/__init__.py 
b/bindings/python/notmuch/__init__.py
index 539afed..f3ff987 100644
--- a/bindings/python/notmuch/__init__.py
+++ b/bindings/python/notmuch/__init__.py
@@ -69,7 +69,7 @@ from notmuch.globals import (
 TagTooLongError,
 UnbalancedFreezeThawError,
 UnbalancedAtomicError,
-NotInitializedError
+NotInitializedError,
 )
 from notmuch.version import __VERSION__
 __LICENSE__ = "GPL v3+"
diff --git a/bindings/python/notmuch/database.py 
b/bindings/python/notmuch/database.py
index 25b4b1b..ca17273 100644
--- a/bindings/python/notmuch/database.py
+++ b/bindings/python/notmuch/database.py
@@ -27,6 +27,7 @@ from notmuch.thread import Threads
 from notmuch.message import Messages, Message
 from notmuch.tag import Tags

+
 class Database(object):
 """The :class:`Database` is the highest-level object that notmuch
 provides. It references a notmuch database, and can be opened in
@@ -83,12 +84,14 @@ class Database(object):

 """ notmuch_database_find_message"""
 _find_message = nmlib.notmuch_database_find_message
-_find_message.argtypes = [NotmuchDatabaseP, c_char_p, 
POINTER(NotmuchMessageP)]
+_find_message.argtypes = [NotmuchDatabaseP, c_char_p,
+  POINTER(NotmuchMessageP)]
 _find_message.restype = c_uint

 """notmuch_database_find_message_by_filename"""
 _find_message_by_filename = nmlib.notmuch_database_find_message_by_filename
-_find_message_by_filename.argtypes = [NotmuchDatabaseP, c_char_p, 
POINTER(NotmuchMessageP)]
+_find_message_by_filename.argtypes = [NotmuchDatabaseP, c_char_p,
+  POINTER(NotmuchMessageP)]
 _find_message_by_filename.restype = c_uint

 """notmuch_database_get_all_tags"""
@@ -177,8 +180,8 @@ class Database(object):
 :param status: Open the database in read-only or read-write mode
 :type status:  :attr:`MODE`
 :returns: Nothing
-:exception: Raises :exc:`NotmuchError` in case
-of any failure (possibly after printing an error message on 
stderr).
+:exception: Raises :exc:`NotmuchError` in case of any failure
+(possibly after printing an error message on stderr).
 """
 res = Database._open(_str(path), mode)

@@ -293,12 +296,12 @@ class Database(object):
 (creating it if it does not exist(?))

 .. warning:: This call needs a writeable database in
-   :attr:`Database.MODE`.READ_WRITE mode. The underlying library will 
exit the
-   program if this method is used on a read-only database!
+   :attr:`Database.MODE`.READ_WRITE mode. The underlying library will
+   exit the program if this method is used on a read-only database!

 :param path: An unicode string containing the path relative to the path
-  of database (see :meth:`get_path`), or else should be an 
absolute path
-  with initial components that match the path of 'database'.
+  of database (see :meth:`get_path`), or else should be an absolute
+  path with initial components that match the path of 'database'.
 :returns: :class:`Directory` or raises an exception.
 :exception:
 :exc:`NotmuchError` with :attr:`STATUS`.FILE_ERROR
@@ -325,7 +328,8 @@ class Database(object):
 return Directory(_str(abs_dirpath), dir_p, self)

 _add_message = nmlib.notmuch_database_add_message
-_add_message.argtypes = [NotmuchDatabaseP, c_char_p, 
POINTER(NotmuchMessageP)]
+_add_message.argtypes = [NotmuchDatabaseP, c_char_p,
+ POINTER(NotmuchMessageP)]
 _add_message.restype = c_uint

 def add_message(self, filename, sync_maildir_flags=False):
@@ -490,7 +494,8 @@ class Database(object):
 """Returns :class:`Tags` with a list of all tags found in the database

 :returns: :class:`Tags`
-:execption: :exc:`NotmuchError` with :attr:`STATUS`.NULL_POINTER on 
error
+:execption: :exc:`NotmuchError` with :attr:`STATUS`.NULL_POINTER
+on error
 """
 self._assert_db_is_initialized()
 tags_p = Database._get_all_tags(self._db)
@@ -748,7 +753,8 @@ class Directory(object):
 _get_child_directories.restype = NotmuchFilenamesP

 def _assert_dir_is_initialized(self):
-"""Raises a NotmuchError(:attr:`STATUS`.NOT_INITIALIZED) if dir_p is 
None"""
+"""Raises a NotmuchError(:attr:`STATUS`.NOT_INITIALIZED)
+if dir_p is None"""
 if self._dir_p is None:
 raise 

[PATCH 1/3] pep8 fixes

[Patrick Totzke]

no changes to the code, only fixed stuff denounced by `pep8 *py`
---
 bindings/python/notmuch/__init__.py |2 +-
 bindings/python/notmuch/database.py |   28 +++--
 bindings/python/notmuch/globals.py  |   38 +++---
 bindings/python/notmuch/thread.py   |1 -
 4 files changed, 52 insertions(+), 17 deletions(-)

diff --git a/bindings/python/notmuch/__init__.py 
b/bindings/python/notmuch/__init__.py
index 539afed..f3ff987 100644
--- a/bindings/python/notmuch/__init__.py
+++ b/bindings/python/notmuch/__init__.py
@@ -69,7 +69,7 @@ from notmuch.globals import (
 TagTooLongError,
 UnbalancedFreezeThawError,
 UnbalancedAtomicError,
-NotInitializedError
+NotInitializedError,
 )
 from notmuch.version import __VERSION__
 __LICENSE__ = GPL v3+
diff --git a/bindings/python/notmuch/database.py 
b/bindings/python/notmuch/database.py
index 25b4b1b..ca17273 100644
--- a/bindings/python/notmuch/database.py
+++ b/bindings/python/notmuch/database.py
@@ -27,6 +27,7 @@ from notmuch.thread import Threads
 from notmuch.message import Messages, Message
 from notmuch.tag import Tags
 
+
 class Database(object):
 The :class:`Database` is the highest-level object that notmuch
 provides. It references a notmuch database, and can be opened in
@@ -83,12 +84,14 @@ class Database(object):
 
  notmuch_database_find_message
 _find_message = nmlib.notmuch_database_find_message
-_find_message.argtypes = [NotmuchDatabaseP, c_char_p, 
POINTER(NotmuchMessageP)]
+_find_message.argtypes = [NotmuchDatabaseP, c_char_p,
+  POINTER(NotmuchMessageP)]
 _find_message.restype = c_uint
 
 notmuch_database_find_message_by_filename
 _find_message_by_filename = nmlib.notmuch_database_find_message_by_filename
-_find_message_by_filename.argtypes = [NotmuchDatabaseP, c_char_p, 
POINTER(NotmuchMessageP)]
+_find_message_by_filename.argtypes = [NotmuchDatabaseP, c_char_p,
+  POINTER(NotmuchMessageP)]
 _find_message_by_filename.restype = c_uint
 
 notmuch_database_get_all_tags
@@ -177,8 +180,8 @@ class Database(object):
 :param status: Open the database in read-only or read-write mode
 :type status:  :attr:`MODE`
 :returns: Nothing
-:exception: Raises :exc:`NotmuchError` in case
-of any failure (possibly after printing an error message on 
stderr).
+:exception: Raises :exc:`NotmuchError` in case of any failure
+(possibly after printing an error message on stderr).
 
 res = Database._open(_str(path), mode)
 
@@ -293,12 +296,12 @@ class Database(object):
 (creating it if it does not exist(?))
 
 .. warning:: This call needs a writeable database in
-   :attr:`Database.MODE`.READ_WRITE mode. The underlying library will 
exit the
-   program if this method is used on a read-only database!
+   :attr:`Database.MODE`.READ_WRITE mode. The underlying library will
+   exit the program if this method is used on a read-only database!
 
 :param path: An unicode string containing the path relative to the path
-  of database (see :meth:`get_path`), or else should be an 
absolute path
-  with initial components that match the path of 'database'.
+  of database (see :meth:`get_path`), or else should be an absolute
+  path with initial components that match the path of 'database'.
 :returns: :class:`Directory` or raises an exception.
 :exception:
 :exc:`NotmuchError` with :attr:`STATUS`.FILE_ERROR
@@ -325,7 +328,8 @@ class Database(object):
 return Directory(_str(abs_dirpath), dir_p, self)
 
 _add_message = nmlib.notmuch_database_add_message
-_add_message.argtypes = [NotmuchDatabaseP, c_char_p, 
POINTER(NotmuchMessageP)]
+_add_message.argtypes = [NotmuchDatabaseP, c_char_p,
+ POINTER(NotmuchMessageP)]
 _add_message.restype = c_uint
 
 def add_message(self, filename, sync_maildir_flags=False):
@@ -490,7 +494,8 @@ class Database(object):
 Returns :class:`Tags` with a list of all tags found in the database
 
 :returns: :class:`Tags`
-:execption: :exc:`NotmuchError` with :attr:`STATUS`.NULL_POINTER on 
error
+:execption: :exc:`NotmuchError` with :attr:`STATUS`.NULL_POINTER
+on error
 
 self._assert_db_is_initialized()
 tags_p = Database._get_all_tags(self._db)
@@ -748,7 +753,8 @@ class Directory(object):
 _get_child_directories.restype = NotmuchFilenamesP
 
 def _assert_dir_is_initialized(self):
-Raises a NotmuchError(:attr:`STATUS`.NOT_INITIALIZED) if dir_p is 
None
+Raises a NotmuchError(:attr:`STATUS`.NOT_INITIALIZED)
+if dir_p is None
 if self._dir_p is None:
 raise