[PATCH 1/5] cli: Refactor option passing in the search command

2014-09-29 Thread Jani Nikula
On Thu, 25 Sep 2014, Michal Sojka wrote: > On Thu, Sep 25 2014, Tomi Ollila wrote: >> Although the test and the implementation in the next patches look OK, I'd >> prefer the FLAG implementation Jani suggested earlier. IMO now that I >> compare these two it looks cleaner and simpler... > > The

[PATCH 1/5] cli: Refactor option passing in the search command

2014-09-29 Thread Tomi Ollila
On Thu, Sep 25 2014, Michal Sojka wrote: > On Thu, Sep 25 2014, Tomi Ollila wrote: >> On Mon, Sep 22 2014, Michal Sojka wrote: >> >>> Many functions that implement the search command need to access command >>> line options. Instead of passing each option in a separate variable, put >>> them in

Re: [PATCH 1/5] cli: Refactor option passing in the search command

2014-09-29 Thread Tomi Ollila
On Thu, Sep 25 2014, Michal Sojka sojk...@fel.cvut.cz wrote: On Thu, Sep 25 2014, Tomi Ollila wrote: On Mon, Sep 22 2014, Michal Sojka sojk...@fel.cvut.cz wrote: Many functions that implement the search command need to access command line options. Instead of passing each option in a separate

[PATCH 1/5] cli: Refactor option passing in the search command

2014-09-25 Thread Michal Sojka
On Thu, Sep 25 2014, Tomi Ollila wrote: > On Mon, Sep 22 2014, Michal Sojka wrote: > >> Many functions that implement the search command need to access command >> line options. Instead of passing each option in a separate variable, put >> them in a structure and pass only this structure. > > This

[PATCH 1/5] cli: Refactor option passing in the search command

2014-09-25 Thread Tomi Ollila
On Mon, Sep 22 2014, Michal Sojka wrote: > Many functions that implement the search command need to access command > line options. Instead of passing each option in a separate variable, put > them in a structure and pass only this structure. This patch looks good to me. Although the test and

Re: [PATCH 1/5] cli: Refactor option passing in the search command

2014-09-25 Thread Tomi Ollila
On Mon, Sep 22 2014, Michal Sojka sojk...@fel.cvut.cz wrote: Many functions that implement the search command need to access command line options. Instead of passing each option in a separate variable, put them in a structure and pass only this structure. This patch looks good to me.

Re: [PATCH 1/5] cli: Refactor option passing in the search command

2014-09-25 Thread Michal Sojka
On Thu, Sep 25 2014, Tomi Ollila wrote: On Mon, Sep 22 2014, Michal Sojka sojk...@fel.cvut.cz wrote: Many functions that implement the search command need to access command line options. Instead of passing each option in a separate variable, put them in a structure and pass only this

[PATCH 1/5] cli: Refactor option passing in the search command

2014-09-22 Thread Michal Sojka
Many functions that implement the search command need to access command line options. Instead of passing each option in a separate variable, put them in a structure and pass only this structure. This will become handy in the following patches. --- notmuch-search.c | 122

[PATCH 1/5] cli: Refactor option passing in the search command

2014-09-22 Thread Michal Sojka
Many functions that implement the search command need to access command line options. Instead of passing each option in a separate variable, put them in a structure and pass only this structure. This will become handy in the following patches. --- notmuch-search.c | 122