[PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-05-13 Thread David Bremner
Aaron Ecay writes: > Presently, the code which finds the parent of a message as it is being > added to the database assumes that the first Message-ID-like substring > of the In-Reply-To header is the parent Message ID. Some mail > clients, however, put stuff other than the Message-ID of the pare

Re: [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-05-13 Thread David Bremner
Aaron Ecay writes: > Presently, the code which finds the parent of a message as it is being > added to the database assumes that the first Message-ID-like substring > of the In-Reply-To header is the parent Message ID. Some mail > clients, however, put stuff other than the Message-ID of the pare

[PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-05-04 Thread Jani Nikula
LGTM On Wed, 06 Mar 2013, Aaron Ecay wrote: > Presently, the code which finds the parent of a message as it is being > added to the database assumes that the first Message-ID-like substring > of the In-Reply-To header is the parent Message ID. Some mail clients, > however, put stuff other than

[PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-05-04 Thread David Bremner
Aaron Ecay writes: > +if (ref && strcmp(ref, message_id)) { > + return ref; > +} else { > + return NULL; > +} As a nit, there should be a space after strcmp. But if nobody has any other comments, I could amend that. d

Re: [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-05-04 Thread Jani Nikula
LGTM On Wed, 06 Mar 2013, Aaron Ecay wrote: > Presently, the code which finds the parent of a message as it is being > added to the database assumes that the first Message-ID-like substring > of the In-Reply-To header is the parent Message ID. Some mail clients, > however, put stuff other than

Re: [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-05-04 Thread David Bremner
Aaron Ecay writes: > +if (ref && strcmp(ref, message_id)) { > + return ref; > +} else { > + return NULL; > +} As a nit, there should be a space after strcmp. But if nobody has any other comments, I could amend that. d ___ notmuch ma

[PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-03-05 Thread Aaron Ecay
Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To header,

[PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-03-05 Thread Aaron Ecay
Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To header,