Re: [PATCH 2/2] lib: thread-safe s-expression query parser

2023-08-27 Thread Kevin Boulain
On 2023-07-22 at 16:06 -03, David Bremner wrote: > My first thought was that this should be static, but maybe it doesn't > matter in C++; I see the other inline functions in that file are not > declared static. True, I should have marked this function static. I did the same for the others. > I

Re: [PATCH 2/2] lib: thread-safe s-expression query parser

2023-07-22 Thread David Bremner
Kevin Boulain writes: > + > +inline Xapian::Query > +_sexp_initial_query (_sexp_initial_t initial) My first thought was that this should be static, but maybe it doesn't matter in C++; I see the other inline functions in that file are not declared static. > +} > +assert (!

[PATCH 2/2] lib: thread-safe s-expression query parser

2023-04-03 Thread Kevin Boulain
Follow-up of 6273966d, now that sfsexp 1.4.1 doesn't rely on globals anymore by default (https://github.com/mjsottile/sfsexp/issues/21). This simply defers the initial query generation to use the thread-safe helper (xapian_query_match_all) instead of Xapian::Query::MatchAll. ---