[PATCH 2/6] lib: Add per-message last modification tracking

2015-08-08 Thread Austin Clements
Hi David. I haven't had a chance to look back at the original code, but your follow-up expanded comment agrees with how I remember this code working. On Aug 7, 2015 4:41 PM, "David Bremner" wrote: > Daniel Schoepe writes: > > > > On Fri, 05 Jun 2015 19:28 +0200, David Bremner wrote: > >> +

Re: [PATCH 2/6] lib: Add per-message last modification tracking

2015-08-08 Thread Austin Clements
Hi David. I haven't had a chance to look back at the original code, but your follow-up expanded comment agrees with how I remember this code working. On Aug 7, 2015 4:41 PM, "David Bremner" wrote: > Daniel Schoepe writes: > > > > On Fri, 05 Jun 2015 19:28 +0200, David Bremner wrote: > >> +

[PATCH 2/6] lib: Add per-message last modification tracking

2015-08-07 Thread David Bremner
Daniel Schoepe writes: > On Fri, 05 Jun 2015 19:28 +0200, David Bremner wrote: >> +/* Prior to NOTMUCH_FEATURE_LAST_MOD, messages did not >> + * track modification revisions. Give all messages a >> + * revision of 1. >> + */ >> +if (new_features & NOTMUCH

Re: [PATCH 2/6] lib: Add per-message last modification tracking

2015-08-07 Thread David Bremner
Daniel Schoepe writes: > On Fri, 05 Jun 2015 19:28 +0200, David Bremner wrote: >> +/* Prior to NOTMUCH_FEATURE_LAST_MOD, messages did not >> + * track modification revisions. Give all messages a >> + * revision of 1. >> + */ >> +if (new_features & NOTMUCH

[PATCH 2/6] lib: Add per-message last modification tracking

2015-08-07 Thread Daniel Schoepe
Hi, On Fri, 05 Jun 2015 19:28 +0200, David Bremner wrote: > + /* Prior to NOTMUCH_FEATURE_LAST_MOD, messages did not > + * track modification revisions. Give all messages a > + * revision of 1. > + */ > + if (new_features & NOTMUCH_FEATURE_LAST_MOD) > +

Re: [PATCH 2/6] lib: Add per-message last modification tracking

2015-08-07 Thread Daniel Schoepe
Hi, On Fri, 05 Jun 2015 19:28 +0200, David Bremner wrote: > + /* Prior to NOTMUCH_FEATURE_LAST_MOD, messages did not > + * track modification revisions. Give all messages a > + * revision of 1. > + */ > + if (new_features & NOTMUCH_FEATURE_LAST_MOD) > +

[PATCH 2/6] lib: Add per-message last modification tracking

2015-06-05 Thread David Bremner
From: Austin Clements This adds a new document value that stores the revision of the last modification to message metadata, where the revision number increases monotonically with each database commit. An alternative would be to store the wall-clock time of the last modification of each message.

[PATCH 2/6] lib: Add per-message last modification tracking

2015-06-05 Thread David Bremner
From: Austin Clements This adds a new document value that stores the revision of the last modification to message metadata, where the revision number increases monotonically with each database commit. An alternative would be to store the wall-clock time of the last modification of each message.