Re: [PATCH 26/27] emacs: avoid binding unnamed commands in keymaps

2023-10-29 Thread David Bremner
Ryan Tate writes: > Jonas Bernoulli writes: > >> - -(defun notmuch-tree-close-message-pane-and (func) - "Close >> message pane and execute FUNC. > > I am confused why a function used in config files and documented > on the notmuch website (to this moment) as an example of how to >

Re: [PATCH 26/27] emacs: avoid binding unnamed commands in keymaps

2023-10-28 Thread Ryan Tate
> On Oct 28, 2023, at 5:32 AM, Michael J Gruber > > Maybe you can help us by rephrasing your complaints into suggestions for > documentation updates, and thus help others getting less confused? I’ve updated the documentation before when I discovered changes after the fact, in coordination

Re: [PATCH 26/27] emacs: avoid binding unnamed commands in keymaps

2023-10-28 Thread Michael J Gruber
Am Sa., 28. Okt. 2023 um 06:22 Uhr schrieb Ryan Tate : > > Jonas Bernoulli writes: > > > - -(defun notmuch-tree-close-message-pane-and (func) - "Close > > message pane and execute FUNC. > > I am confused why a function used in config files and documented > on the notmuch website (to this

Re: [PATCH 26/27] emacs: avoid binding unnamed commands in keymaps

2023-10-27 Thread Ryan Tate
Jonas Bernoulli writes: - -(defun notmuch-tree-close-message-pane-and (func) - "Close message pane and execute FUNC. I am confused why a function used in config files and documented on the notmuch website (to this moment) as an example of how to configure something would be removed,

[PATCH 26/27] emacs: avoid binding unnamed commands in keymaps

2020-11-08 Thread Jonas Bernoulli
One should never bind unnamed commands in keymaps because doing that makes it needlessly hard for users to change these bindings. Replace such anonymous bindings with named commands that are generated using macros and some boilerplate. Using macros is better than using a simple loop because that