Re: [PATCH 5/9] feat: Add more interactive specs

[David Bremner]

This needs a better commit message. Both the subject (what is actually
happening) and the body (more detail about what, and some explanation
about why).

I'd suggest sticking to emacs: as a tag for the subject, but this is
less important than the other two issues I mentioned.
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org

[PATCH 5/9] feat: Add more interactive specs

[Mohsin Kaleem]

---
 emacs/notmuch-tree.el | 20 ++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index 9ed8a3d9..5f999424 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -1215,7 +1215,15 @@ The arguments are:
   it is nil \"*notmuch-tree\" followed by QUERY is used.
   OPEN-TARGET: If TRUE open the target message in the message pane.
   UNTHREADED: If TRUE only show matching messages in an unthreaded view."
-  (interactive)
+  (interactive
+   (list
+;; Prompt for a query
+nil
+;; Fill other args with nil.
+nil nil nil nil nil nil
+;; Populate these from the default value of these options.
+(default-value 'notmuch-search-oldest-first)
+(default-value 'notmuch-search-exclude)))
   (unless query
 (setq query (notmuch-read-query (concat "Notmuch "
(if unthreaded "unthreaded " "tree 
")
@@ -1239,7 +1247,15 @@ The arguments are:
   "Display threads matching QUERY in unthreaded view.
 
 See function NOTMUCH-TREE for documentation of the arguments"
-  (interactive)
+  (interactive
+   (list
+;; Prompt for a query
+nil
+;; Fill other args with nil.
+nil nil nil nil
+;; Populate these from the default value of these options.
+(default-value 'notmuch-search-oldest-first)
+(default-value 'notmuch-search-exclude)))
   (notmuch-tree query query-context target buffer-name open-target
t nil oldest-first exclude))
 
-- 
2.37.1

___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org