[PATCH WIP v3 0/3] emacs: show: change the unread handling
On Thu, 05 Dec 2013, Mark Walters wrote: > This is the next iteration of this WIP patch series. v2 was at > id:1385892147-16994-1-git-send-email-markwalters1009 at gmail.com > > I would just like to emphasise that *all* feedback is appreciated > including "I HATE IT" etc. I LIKE IT. :) It's not perfect, but IMHO it's a nice, incremental improvement over what we have, and it's discoverable: you can see what it does and when. If anything is surprising, the user has a better chance of explaining what happened, and what he liked and didn't. Good work, Mark! BR, Jani. PS. I didn't look at the code, I only tried it. > I have followed Jani's suggestion and removed the delayed updates to > unread status: it makes it harder to see if the heuristics are doing > what you want. > > The first patch is completely new: it makes all tag changes in a > buffer (in particular the unread tag) clearly visible to the user: a > deleted tag is displayed with red strike-through and an added tag is > displayed underlined in green. (This may have strange interactions with > notmuch-tag-formats in some cases.) > > This makes the visual feedback when a message is marked unread very > clear: the unread tag is struck-through. > > As always with the previous series lots of tests will fail for the > obvious reason that marking read is done differently and displayed > differently. > > Best wishes > > Mark > > > > > Mark Walters (3): > emacs: show: mark tags changed since buffer loaded > emacs: show: add an update seen function to post-command-hook > emacs: show: make `seen' mean user viewed whole message > > emacs/notmuch-show.el | 136 +--- > emacs/notmuch-tag.el | 30 +++ > 2 files changed, 136 insertions(+), 30 deletions(-) > > -- > 1.7.9.1 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH WIP v3 0/3] emacs: show: change the unread handling
On Thu, 05 Dec 2013, Mark Walters markwalters1...@gmail.com wrote: This is the next iteration of this WIP patch series. v2 was at id:1385892147-16994-1-git-send-email-markwalters1...@gmail.com I would just like to emphasise that *all* feedback is appreciated including I HATE IT etc. I LIKE IT. :) It's not perfect, but IMHO it's a nice, incremental improvement over what we have, and it's discoverable: you can see what it does and when. If anything is surprising, the user has a better chance of explaining what happened, and what he liked and didn't. Good work, Mark! BR, Jani. PS. I didn't look at the code, I only tried it. I have followed Jani's suggestion and removed the delayed updates to unread status: it makes it harder to see if the heuristics are doing what you want. The first patch is completely new: it makes all tag changes in a buffer (in particular the unread tag) clearly visible to the user: a deleted tag is displayed with red strike-through and an added tag is displayed underlined in green. (This may have strange interactions with notmuch-tag-formats in some cases.) This makes the visual feedback when a message is marked unread very clear: the unread tag is struck-through. As always with the previous series lots of tests will fail for the obvious reason that marking read is done differently and displayed differently. Best wishes Mark Mark Walters (3): emacs: show: mark tags changed since buffer loaded emacs: show: add an update seen function to post-command-hook emacs: show: make `seen' mean user viewed whole message emacs/notmuch-show.el | 136 +--- emacs/notmuch-tag.el | 30 +++ 2 files changed, 136 insertions(+), 30 deletions(-) -- 1.7.9.1 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH WIP v3 0/3] emacs: show: change the unread handling
This is the next iteration of this WIP patch series. v2 was at id:1385892147-16994-1-git-send-email-markwalters1009 at gmail.com I would just like to emphasise that *all* feedback is appreciated including "I HATE IT" etc. I have followed Jani's suggestion and removed the delayed updates to unread status: it makes it harder to see if the heuristics are doing what you want. The first patch is completely new: it makes all tag changes in a buffer (in particular the unread tag) clearly visible to the user: a deleted tag is displayed with red strike-through and an added tag is displayed underlined in green. (This may have strange interactions with notmuch-tag-formats in some cases.) This makes the visual feedback when a message is marked unread very clear: the unread tag is struck-through. As always with the previous series lots of tests will fail for the obvious reason that marking read is done differently and displayed differently. Best wishes Mark Mark Walters (3): emacs: show: mark tags changed since buffer loaded emacs: show: add an update seen function to post-command-hook emacs: show: make `seen' mean user viewed whole message emacs/notmuch-show.el | 136 +--- emacs/notmuch-tag.el | 30 +++ 2 files changed, 136 insertions(+), 30 deletions(-) -- 1.7.9.1
[PATCH WIP v3 0/3] emacs: show: change the unread handling
This is the next iteration of this WIP patch series. v2 was at id:1385892147-16994-1-git-send-email-markwalters1...@gmail.com I would just like to emphasise that *all* feedback is appreciated including I HATE IT etc. I have followed Jani's suggestion and removed the delayed updates to unread status: it makes it harder to see if the heuristics are doing what you want. The first patch is completely new: it makes all tag changes in a buffer (in particular the unread tag) clearly visible to the user: a deleted tag is displayed with red strike-through and an added tag is displayed underlined in green. (This may have strange interactions with notmuch-tag-formats in some cases.) This makes the visual feedback when a message is marked unread very clear: the unread tag is struck-through. As always with the previous series lots of tests will fail for the obvious reason that marking read is done differently and displayed differently. Best wishes Mark Mark Walters (3): emacs: show: mark tags changed since buffer loaded emacs: show: add an update seen function to post-command-hook emacs: show: make `seen' mean user viewed whole message emacs/notmuch-show.el | 136 +--- emacs/notmuch-tag.el | 30 +++ 2 files changed, 136 insertions(+), 30 deletions(-) -- 1.7.9.1 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
