Re: [PATCH v1 1/3] emacs: Improve crypto button labels.

2016-03-24 Thread David Bremner
David Edmondson  writes:

> Make the labels for both encryption and signature buttons share a common
> format, in which both report the status if it is not one of those known.
> ---

Pushed this one patch, since surprisingly it doesn't break the test
suite.

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


[PATCH v1 1/3] emacs: Improve crypto button labels.

2016-02-09 Thread David Edmondson
Make the labels for both encryption and signature buttons share a common
format, in which both report the status if it is not one of those known.
---
 emacs/notmuch-crypto.el | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
index 5233824..73ebf51 100644
--- a/emacs/notmuch-crypto.el
+++ b/emacs/notmuch-crypto.el
@@ -110,8 +110,8 @@ mode."
(setq label (concat "Bad signature (claimed key ID " keyid ")"))
(setq face 'notmuch-crypto-signature-bad)))
  (t
-  (setq label "Unknown signature status")
-  (if status (setq label (concat label " \"" status "\"")
+  (setq label (concat "Unknown signature status"
+ (if status (concat ": " status))
 (insert-button
  (concat "[ " label " ]")
  :type 'notmuch-crypto-status-button-type
@@ -161,7 +161,8 @@ mode."
  ((string= status "bad")
   (setq label "Decryption error"))
  (t
-  (setq label (concat "Unknown encstatus \"" status "\""
+  (setq label (concat "Unknown encryption status"
+ (if status (concat ": " status))
 (insert-button
  (concat "[ " label " ]")
  :type 'notmuch-crypto-status-button-type
-- 
2.1.4

___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch