Re: [PATCH v2] emacs: add compatability functions for emacs 23

2016-11-12 Thread David Bremner
Tomi Ollila writes: > But this compatIbility change is not just emacs 23 -- iirc there were some > changes required to get emacs 24.1, 24.2, and 24.3 to work. It might be > easier to keep testing using emacs 23 until we deprecate everything before > emacs 24.4 (released October 20, 2014) -- or s

Re: [PATCH v2] emacs: add compatability functions for emacs 23

2016-11-11 Thread David Bremner
Tomi Ollila writes: >> 2) It's getting hard to debug emacs23 problems, and developer time is >>scarce, so at the same time, deprecate emacs23 support, so e.g. after >>the next major release we can just drop it. > > It is not hard at all. Just do not mess w/ mixed environments >;). I gue

Re: [PATCH v2] emacs: add compatability functions for emacs 23

2016-11-11 Thread Tomi Ollila
On Fri, Nov 11 2016, David Bremner wrote: > David Bremner writes: > >> The plot thickens. With this patch applied, I can generate an emacs >> segfault with >> >> 1) EMACS=emacs23 ./devel/try-emacs-mua -q >> >> 2) M-x notmuch-search >> >> 3) tag:inbox > > OK, I managed to figure out the problem

Re: [PATCH v2] emacs: add compatability functions for emacs 23

2016-11-11 Thread David Bremner
David Bremner writes: > The plot thickens. With this patch applied, I can generate an emacs > segfault with > > 1) EMACS=emacs23 ./devel/try-emacs-mua -q > > 2) M-x notmuch-search > > 3) tag:inbox OK, I managed to figure out the problem. I had byte compiled the emacs code with emacs24, and loa

Re: [PATCH v2] emacs: add compatability functions for emacs 23

2016-11-11 Thread David Bremner
David Bremner writes: > Mark Walters writes: > >> Some of the recent changes to the emacs code have used functions >> introduced in emacs 24. The functions used are read-char-choice and >> setq-local. This changeset adds compatability functions to >> notmuch-lib so that it should work on emacs 2

Re: [PATCH v2] emacs: add compatability functions for emacs 23

2016-11-11 Thread David Bremner
Mark Walters writes: > Some of the recent changes to the emacs code have used functions > introduced in emacs 24. The functions used are read-char-choice and > setq-local. This changeset adds compatability functions to > notmuch-lib so that it should work on emacs 23. > --- > 1) please could som

[PATCH v2] emacs: add compatability functions for emacs 23

2016-11-02 Thread Matt Armstrong
Mark Walters writes: [...] > Version 1 of this patch (with some discussion) is at > id:1477191835-17828-1-git-send-email-markwalters1009 at gmail.com > > The general consensus is that we should not define functions outside > our namespace, even when they are just backports of functions from > la

[PATCH v2] emacs: add compatability functions for emacs 23

2016-10-29 Thread Mark Walters
Some of the recent changes to the emacs code have used functions introduced in emacs 24. The functions used are read-char-choice and setq-local. This changeset adds compatability functions to notmuch-lib so that it should work on emacs 23. --- Version 1 of this patch (with some discussion) is at i