[PATCH v2 0/3] Allow emacs to toggle display of all parts including multipart

2012-12-03 Thread Mark Walters

Hi

I now have a version which does this `right': using invisibility as with
citations and signatures etc. It is working but I need to look through
more carefully before posting.

Best wishes

Mark

On Mon, 03 Dec 2012, Mark Walters  wrote:
> This is rather more polished version of
> id:1351152563-27277-1-git-send-email-markwalters1009 at gmail.com.
>
> The first patch modifies the behaviour of show refresh buffer to keep
> state more accurately where possible. It can never be perfect but it
> makes a reasonable attempt. This is independent of patches 2 and 3.
>
> The second patch allows the user to toggle the visibility of any part
> with 't' on the part button. It does this by storing a list of all
> parts that the user has over-ruled.
>
> The final patch binds the toggle to the default action in cases where
> the part has no filename. Is this a reasonable heuristic? And should
> it be customisable? In all cases the defined actions (save, view,
> other, and toggle) always do their action (ie they do not apply any
> heuristics)
>
> Overall I am pleased with the way it works. The one caveat is that it
> does redisplay the whole buffer when toggling the parts: it might be
> nice to use invisibility but that is beyond my lisp. Moreover it could
> be added at a later stage without changing the user experience.
>
>
> Best wishes
>
> Mark
>
>
> Mark Walters (3):
>   emacs: show: make refresh fix point(ish)
>   emacs: allow the user to toggle the visibility of
> multipart/alternative parts
>   emacs: show make default part button toggle view when sensible
>
>  emacs/notmuch-show.el |   80 ++--
>  1 files changed, 63 insertions(+), 17 deletions(-)
>
> -- 
> 1.7.9.1


[PATCH v2 0/3] Allow emacs to toggle display of all parts including multipart

2012-12-03 Thread Mark Walters
This is rather more polished version of
id:1351152563-27277-1-git-send-email-markwalters1009 at gmail.com.

The first patch modifies the behaviour of show refresh buffer to keep
state more accurately where possible. It can never be perfect but it
makes a reasonable attempt. This is independent of patches 2 and 3.

The second patch allows the user to toggle the visibility of any part
with 't' on the part button. It does this by storing a list of all
parts that the user has over-ruled.

The final patch binds the toggle to the default action in cases where
the part has no filename. Is this a reasonable heuristic? And should
it be customisable? In all cases the defined actions (save, view,
other, and toggle) always do their action (ie they do not apply any
heuristics)

Overall I am pleased with the way it works. The one caveat is that it
does redisplay the whole buffer when toggling the parts: it might be
nice to use invisibility but that is beyond my lisp. Moreover it could
be added at a later stage without changing the user experience.


Best wishes

Mark


Mark Walters (3):
  emacs: show: make refresh fix point(ish)
  emacs: allow the user to toggle the visibility of
multipart/alternative parts
  emacs: show make default part button toggle view when sensible

 emacs/notmuch-show.el |   80 ++--
 1 files changed, 63 insertions(+), 17 deletions(-)

-- 
1.7.9.1



Re: [PATCH v2 0/3] Allow emacs to toggle display of all parts including multipart

2012-12-03 Thread Mark Walters

Hi

I now have a version which does this `right': using invisibility as with
citations and signatures etc. It is working but I need to look through
more carefully before posting.

Best wishes

Mark

On Mon, 03 Dec 2012, Mark Walters markwalters1...@gmail.com wrote:
 This is rather more polished version of
 id:1351152563-27277-1-git-send-email-markwalters1...@gmail.com.

 The first patch modifies the behaviour of show refresh buffer to keep
 state more accurately where possible. It can never be perfect but it
 makes a reasonable attempt. This is independent of patches 2 and 3.

 The second patch allows the user to toggle the visibility of any part
 with 't' on the part button. It does this by storing a list of all
 parts that the user has over-ruled.

 The final patch binds the toggle to the default action in cases where
 the part has no filename. Is this a reasonable heuristic? And should
 it be customisable? In all cases the defined actions (save, view,
 other, and toggle) always do their action (ie they do not apply any
 heuristics)

 Overall I am pleased with the way it works. The one caveat is that it
 does redisplay the whole buffer when toggling the parts: it might be
 nice to use invisibility but that is beyond my lisp. Moreover it could
 be added at a later stage without changing the user experience.


 Best wishes

 Mark


 Mark Walters (3):
   emacs: show: make refresh fix point(ish)
   emacs: allow the user to toggle the visibility of
 multipart/alternative parts
   emacs: show make default part button toggle view when sensible

  emacs/notmuch-show.el |   80 ++--
  1 files changed, 63 insertions(+), 17 deletions(-)

 -- 
 1.7.9.1
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[PATCH v2 0/3] Allow emacs to toggle display of all parts including multipart

2012-12-02 Thread Mark Walters
This is rather more polished version of
id:1351152563-27277-1-git-send-email-markwalters1...@gmail.com.

The first patch modifies the behaviour of show refresh buffer to keep
state more accurately where possible. It can never be perfect but it
makes a reasonable attempt. This is independent of patches 2 and 3.

The second patch allows the user to toggle the visibility of any part
with 't' on the part button. It does this by storing a list of all
parts that the user has over-ruled.

The final patch binds the toggle to the default action in cases where
the part has no filename. Is this a reasonable heuristic? And should
it be customisable? In all cases the defined actions (save, view,
other, and toggle) always do their action (ie they do not apply any
heuristics)

Overall I am pleased with the way it works. The one caveat is that it
does redisplay the whole buffer when toggling the parts: it might be
nice to use invisibility but that is beyond my lisp. Moreover it could
be added at a later stage without changing the user experience.


Best wishes

Mark


Mark Walters (3):
  emacs: show: make refresh fix point(ish)
  emacs: allow the user to toggle the visibility of
multipart/alternative parts
  emacs: show make default part button toggle view when sensible

 emacs/notmuch-show.el |   80 ++--
 1 files changed, 63 insertions(+), 17 deletions(-)

-- 
1.7.9.1

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch