Re: [PATCH v2 0/8] Port notmuch-show's x/X bindings to notmuch-tree
Teemu Likonen writes: > William Casarin [2019-11-28T08:13:53-08] wrote: > >> These patches bring notmuch-tree more in line with the user experience >> of notmuch-show by adding the x/X bindings. >> >> v2: >> - fix a bug when moving between open messages >> - include M-RET keybinding patch from >> id:20191113225752.26502-1-j...@jb55.com > > A minor inconvenience: In "show" mode X key > (notmuch-show-archive-thread-then-exit) archives, exits and moves the > cursor above the next thread in the list. In "tree" mode this new X key > (notmuch-tree-archive-thread-then-exit) does not move the cursor to the > next thread. I didn't even realize notmuch-show does this, I never noticed it before. I'll see if there's a quick fix. Another thing I noticed is that X won't work if it moves past the last message. This is a minor inconvenience, perhaps I can make it so it doesn't move down a line if there are no more messages. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v2 0/8] Port notmuch-show's x/X bindings to notmuch-tree
William Casarin [2019-11-28T08:13:53-08] wrote: > These patches bring notmuch-tree more in line with the user experience > of notmuch-show by adding the x/X bindings. > > v2: > - fix a bug when moving between open messages > - include M-RET keybinding patch from > id:20191113225752.26502-1-j...@jb55.com A minor inconvenience: In "show" mode X key (notmuch-show-archive-thread-then-exit) archives, exits and moves the cursor above the next thread in the list. In "tree" mode this new X key (notmuch-tree-archive-thread-then-exit) does not move the cursor to the next thread. -- /// OpenPGP key: 4E1055DC84E9DFF613D78557719D69D324539450 // https://keys.openpgp.org/search?q=tliko...@iki.fi / https://keybase.io/tlikonen https://github.com/tlikonen signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH v2 0/8] Port notmuch-show's x/X bindings to notmuch-tree
These patches bring notmuch-tree more in line with the user experience of notmuch-show by adding the x/X bindings. v2: - fix a bug when moving between open messages - include M-RET keybinding patch from id:20191113225752.26502-1-j...@jb55.com v1: id:20191117222929.1064-1-j...@jb55.com William Casarin (8): emacs/tree: return true if a thread was found in next-thread emacs/tree: add notmuch-tree-goto-matching-message emacs/tree: add notmuch-tree-matching-message emacs/tree: add kill-both prefix argument to notmuch-tree-quit emacs/tree: add notmuch-tree-archive-message-than-next-or-exit emacs/tree: add notmuch-tree-archive-thread-then-exit emacs/tree: add x/X bindings emacs: bind M-RET to notmuch-tree-from-search-thread emacs/notmuch-tree.el | 72 +++ emacs/notmuch.el | 1 + 2 files changed, 53 insertions(+), 20 deletions(-) Range-diff: 1: 04f7138f = 1: 16972fa8 emacs/tree: return true if a thread was found in next-thread 2: c1f58bf3 = 2: 54e166a9 emacs/tree: add notmuch-tree-goto-matching-message 3: ef6d5da3 = 3: d68d2050 emacs/tree: add notmuch-tree-matching-message 4: 777ea3eb = 4: 8432bc9a emacs/tree: add kill-both prefix argument to notmuch-tree-quit 5: fc2497ad ! 5: 0c3f996d emacs/tree: add notmuch-tree-archive-message-than-next-or-exit @@ emacs/notmuch-tree.el: nil otherwise." - (notmuch-tree-goto-matching-message prev) - (when (window-live-p notmuch-tree-message-window) -(notmuch-tree-show-message-in))) -+ (if (and pop-at-end (not (notmuch-tree-goto-matching-message prev))) ++ (if (and (not (notmuch-tree-goto-matching-message prev)) pop-at-end) + (notmuch-tree-quit pop-at-end) +(when (window-live-p notmuch-tree-message-window) + (notmuch-tree-show-message-in 6: bf3107fa = 6: 17545910 emacs/tree: add notmuch-tree-archive-thread-then-exit 7: 9fea4f9e = 7: fbcb3ee0 emacs/tree: add x/X bindings -: > 8: ac0f03a2 emacs: bind M-RET to notmuch-tree-from-search-thread base-commit: 7ad7cfbff232431377562271901ee00202bf0bd0 -- 2.23.0 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
