Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope

2021-01-13 Thread Jonas Bernoulli
David Bremner writes: > I pushed applied the first 22 patches to master. Thanks! > "[PATCH v2 23/36] emacs: various cosmetic improvements" leads to some > test failures. FWIW, I'm using Emacs 27.1 on Debian testing. Sorry about, it seems I did not rerun the tests after making the responsible c

Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope

2021-01-13 Thread Tomi Ollila
On Wed, Jan 13 2021, David Bremner wrote: > Jonas Bernoulli writes: > >> This fixes a minor whitespace bug that Tomi notices in (1). >> >> This also adds for commits, two of them in response to a concern >> raised by Tomi, who didn't "see enough point for requiring subr-x >> just [for string-empt

Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope

2021-01-13 Thread David Bremner
Jonas Bernoulli writes: > This fixes a minor whitespace bug that Tomi notices in (1). > > This also adds for commits, two of them in response to a concern > raised by Tomi, who didn't "see enough point for requiring subr-x > just [for string-empty-p]", which I agree with: > > 2) Changes how `cl-l

Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope

2021-01-13 Thread Tomi Ollila
On Sun, Jan 10 2021, Jonas Bernoulli wrote: > This fixes a minor whitespace bug that Tomi notices in (1). > > This also adds for commits, two of them in response to a concern > raised by Tomi, who didn't "see enough point for requiring subr-x > just [for string-empty-p]", which I agree with: > > 2

[PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope

2021-01-10 Thread Jonas Bernoulli
This fixes a minor whitespace bug that Tomi notices in (1). This also adds for commits, two of them in response to a concern raised by Tomi, who didn't "see enough point for requiring subr-x just [for string-empty-p]", which I agree with: 2) Changes how `cl-lib' and `pcase' are required. I did t