Re: [PATCH v2 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

2019-06-16 Thread Daniel Kahn Gillmor
On Sun 2019-06-16 14:35:53 +0300, Tomi Ollila wrote: > On Mon, Jun 10 2019, Daniel Kahn Gillmor wrote: >> +test_expect_code 1 "$(printf "notmuch_with_shim shim-%q insert < %q" >> "$code" "$gen_msg_filename")" > > does test_expect_code 1 'notmuch_with_shim shim-$code insert < >

Re: [PATCH v2 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

2019-06-16 Thread Tomi Ollila
On Mon, Jun 10 2019, Daniel Kahn Gillmor wrote: > diff --git a/test/T070-insert.sh b/test/T070-insert.sh > index 48165caa..017124fc 100755 > --- a/test/T070-insert.sh > +++ b/test/T070-insert.sh > @@ -266,30 +264,18 @@ gen_insert_msg > > for code in FILE_NOT_EMAIL READ_ONLY_DATABASE

[PATCH v2 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

2019-06-10 Thread Daniel Kahn Gillmor
From: David Bremner This removes the dependency of this test script on gdb, and considerably speeds up the running of the tests. --- dkg cleaned up the placement of gen_insert_msg, and used printf's %q to handle the perverse case where $gen_msg_filename happens to have a U+0022 QUOTATION MARK