[PATCH v2 4/4] emacs: Use the new JSON reply format.

Hi David, Thanks for the review. A couple of comments inline: On Tue, Jan 17, 2012 at 02:04, David Edmondson wrote: >> + ? ?(insert "\n") >> + ? ?(set-buffer-modified-p nil))) > > Is this newline always required? Is it the cause of the spurious blank > line down below? This is the cause of the

[PATCH v2 4/4] emacs: Use the new JSON reply format.

Much nicer now that it uses the mm stuff. On Mon, 16 Jan 2012 11:13:23 -0700, Adam Wolfe Gordon wrote: > +(defun find-parts (parts type) Sorry for being a nuisance - this needs a name that indicates that it relates to notmuch. How about `notmuch-parts-filter-by-type'? >

Re: [PATCH v2 4/4] emacs: Use the new JSON reply format.

Much nicer now that it uses the mm stuff. On Mon, 16 Jan 2012 11:13:23 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: +(defun find-parts (parts type) Sorry for being a nuisance - this needs a name that indicates that it relates to notmuch. How about `notmuch-parts-filter-by-type'? +

Re: [PATCH v2 4/4] emacs: Use the new JSON reply format.

Hi David, Thanks for the review. A couple of comments inline: On Tue, Jan 17, 2012 at 02:04, David Edmondson d...@dme.org wrote: +    (insert \n) +    (set-buffer-modified-p nil))) Is this newline always required? Is it the cause of the spurious blank line down below? This is the cause of

[PATCH v2 4/4] emacs: Use the new JSON reply format.

Using the new JSON reply format allows emacs to quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them. This is very useful for users who regularly receive HTML-only email. The behavior for messages that contain plain text parts should be unchanged,

[PATCH v2 4/4] emacs: Use the new JSON reply format.

Using the new JSON reply format allows emacs to quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them. This is very useful for users who regularly receive HTML-only email. The behavior for messages that contain plain text parts should be unchanged,