[PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-18 Thread Austin Clements
Quoth Mark Walters on Jan 18 at 10:46 am: > > > > +(defun notmuch-show-view-part (message-id nth filename > > > content-type ) > > > + (notmuch-with-temp-part-buffer message-id nth > > > +;; set mm-inlined-types to nil to force an external viewer > > > +(let ((handle (mm-make-handle

[PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-18 Thread Mark Walters
> > +(defun notmuch-show-view-part (message-id nth filename > > content-type ) > > + (notmuch-with-temp-part-buffer message-id nth > > +;; set mm-inlined-types to nil to force an external viewer > > +(let ((handle (mm-make-handle (current-buffer) (list content-type))) > > +

[PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-18 Thread Antoine Beaupré
On Tue, 17 Jan 2012 23:44:46 +, Mark Walters wrote: > Define a keymap for attachment buttons to allow multiple actions. > Define 3 possible actions: > save attachment: exactly as currently, > view attachment: uses mailcap entry, > view attachment with user chosen program > >

[PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-18 Thread Mark Walters
> Oof, sorry. Two more tweaks that I really should have caught in the > previous version. After that this gets my automatic +1. Both fixed. I have also fixed the bug I mentioned (missing filename when "view" falls back on save); I couldn't make it work with the "no-default" option. However

Re: [PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-18 Thread Mark Walters
+(defun notmuch-show-view-part (message-id nth optional filename content-type ) + (notmuch-with-temp-part-buffer message-id nth +;; set mm-inlined-types to nil to force an external viewer +(let ((handle (mm-make-handle (current-buffer) (list content-type))) +

Re: [PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-18 Thread Austin Clements
Quoth Mark Walters on Jan 18 at 10:46 am: +(defun notmuch-show-view-part (message-id nth optional filename content-type ) + (notmuch-with-temp-part-buffer message-id nth +;; set mm-inlined-types to nil to force an external viewer +(let ((handle (mm-make-handle

[PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Mark Walters
Define a keymap for attachment buttons to allow multiple actions. Define 3 possible actions: save attachment: exactly as currently, view attachment: uses mailcap entry, view attachment with user chosen program Keymap on a button is: s for save, v for view and o for view with other

[PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Austin Clements
Quoth Mark Walters on Jan 18 at 12:40 am: > > > Oof, sorry. Two more tweaks that I really should have caught in the > > previous version. After that this gets my automatic +1. > > Both fixed. I have also fixed the bug I mentioned (missing filename when > "view" falls back on save); I couldn't

[PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Austin Clements
Quoth Mark Walters on Jan 17 at 11:44 pm: > Define a keymap for attachment buttons to allow multiple actions. > Define 3 possible actions: > save attachment: exactly as currently, > view attachment: uses mailcap entry, > view attachment with user chosen program > > Keymap on a button

[PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Mark Walters
Define a keymap for attachment buttons to allow multiple actions. Define 3 possible actions: save attachment: exactly as currently, view attachment: uses mailcap entry, view attachment with user chosen program Keymap on a button is: s for save, v for view and o for view with other

Re: [PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Austin Clements
Quoth Mark Walters on Jan 17 at 11:44 pm: Define a keymap for attachment buttons to allow multiple actions. Define 3 possible actions: save attachment: exactly as currently, view attachment: uses mailcap entry, view attachment with user chosen program Keymap on a button is: s

Re: [PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Mark Walters
Oof, sorry. Two more tweaks that I really should have caught in the previous version. After that this gets my automatic +1. Both fixed. I have also fixed the bug I mentioned (missing filename when view falls back on save); I couldn't make it work with the no-default option. However

Re: [PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Austin Clements
Quoth Mark Walters on Jan 18 at 12:40 am: Oof, sorry. Two more tweaks that I really should have caught in the previous version. After that this gets my automatic +1. Both fixed. I have also fixed the bug I mentioned (missing filename when view falls back on save); I couldn't make it