[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Dmitry Kurochkin]

Hi Thomas.

On Wed, 21 Dec 2011 01:30:48 +0100, Thomas Jost  
wrote:
> On Fri, 16 Dec 2011 16:34:03 +0400, Dmitry Kurochkin  gmail.com> wrote:
> > On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner  
> > wrote:
> > > On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin  > > gmail.com> wrote:
> > > > 
> > > > What do perople think about making the thousands separator a space by
> > > > default?
> > > > 
> > > 
> > > Is that really good for a majority of users? I had never heard of it
> > > until now. I know this is hardly scientific, but still...
> > > 
> > 
> > Well, to me "1 000 000 000" looks better than "1,000,000,000".  But I do
> > not know about the others.  That is why I was asking :)
> 
> That's a complex topic unfortunately. I prefer "1 000 000" too, but many
> would prefer "1,000,000", others would prefer "1'000'000", and in India
> many would even prefer "1,00,"
> (https://en.wikipedia.org/wiki/Thousands_separator#Examples_of_use).
> 
> The cleanest solution would be to use something that cares about the
> LC_NUMERIC environment variable. sprintf() can do such things, but I'm
> not aware of any possibility to do that in elisp.
> 

We discussed this on IRC.  And, surprisingly, everyone agreed on
changing the default to a space in a separate patch.

But my other comment for this patch is still relevant: please rename
`notmuch-thousands-separator' to `notmuch-hello-thousands-separator'.

If you decide to make another patch that changes the default to a space,
please add this link [1] to the preamble and a citation:

  Therefore the space is recommended in the SI/ISO 31-0 standard,
  and the International Bureau of Weights and Measures states that "for
  numbers with many digits the digits may be divided into groups of
  three by a thin space, in order to facilitate reading. Neither dots
  nor commas are inserted in the spaces between groups of three".

Regards,
  Dmitry

[1] http://en.wikipedia.org/wiki/Decimal_separator#Digit_grouping

> -- 
> Thomas/Schnouki

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Thomas Jost]

On Fri, 16 Dec 2011 16:34:03 +0400, Dmitry Kurochkin  wrote:
> On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner  
> wrote:
> > On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin  > gmail.com> wrote:
> > > 
> > > What do perople think about making the thousands separator a space by
> > > default?
> > > 
> > 
> > Is that really good for a majority of users? I had never heard of it
> > until now. I know this is hardly scientific, but still...
> > 
> 
> Well, to me "1 000 000 000" looks better than "1,000,000,000".  But I do
> not know about the others.  That is why I was asking :)

That's a complex topic unfortunately. I prefer "1 000 000" too, but many
would prefer "1,000,000", others would prefer "1'000'000", and in India
many would even prefer "1,00,"
(https://en.wikipedia.org/wiki/Thousands_separator#Examples_of_use).

The cleanest solution would be to use something that cares about the
LC_NUMERIC environment variable. sprintf() can do such things, but I'm
not aware of any possibility to do that in elisp.

-- 
Thomas/Schnouki
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: 

Re: [PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Thomas Jost]

On Fri, 16 Dec 2011 16:34:03 +0400, Dmitry Kurochkin 
dmitry.kuroch...@gmail.com wrote:
 On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner da...@tethera.net wrote:
  On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin 
  dmitry.kuroch...@gmail.com wrote:
   
   What do perople think about making the thousands separator a space by
   default?
   
  
  Is that really good for a majority of users? I had never heard of it
  until now. I know this is hardly scientific, but still...
  
 
 Well, to me 1 000 000 000 looks better than 1,000,000,000.  But I do
 not know about the others.  That is why I was asking :)

That's a complex topic unfortunately. I prefer 1 000 000 too, but many
would prefer 1,000,000, others would prefer 1'000'000, and in India
many would even prefer 1,00,
(https://en.wikipedia.org/wiki/Thousands_separator#Examples_of_use).

The cleanest solution would be to use something that cares about the
LC_NUMERIC environment variable. sprintf() can do such things, but I'm
not aware of any possibility to do that in elisp.

-- 
Thomas/Schnouki


pgpyIvPp7KX9G.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Dmitry Kurochkin]

Hi Thomas.

On Wed, 21 Dec 2011 01:30:48 +0100, Thomas Jost schno...@schnouki.net wrote:
 On Fri, 16 Dec 2011 16:34:03 +0400, Dmitry Kurochkin 
 dmitry.kuroch...@gmail.com wrote:
  On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner da...@tethera.net wrote:
   On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin 
   dmitry.kuroch...@gmail.com wrote:

What do perople think about making the thousands separator a space by
default?

   
   Is that really good for a majority of users? I had never heard of it
   until now. I know this is hardly scientific, but still...
   
  
  Well, to me 1 000 000 000 looks better than 1,000,000,000.  But I do
  not know about the others.  That is why I was asking :)
 
 That's a complex topic unfortunately. I prefer 1 000 000 too, but many
 would prefer 1,000,000, others would prefer 1'000'000, and in India
 many would even prefer 1,00,
 (https://en.wikipedia.org/wiki/Thousands_separator#Examples_of_use).
 
 The cleanest solution would be to use something that cares about the
 LC_NUMERIC environment variable. sprintf() can do such things, but I'm
 not aware of any possibility to do that in elisp.
 

We discussed this on IRC.  And, surprisingly, everyone agreed on
changing the default to a space in a separate patch.

But my other comment for this patch is still relevant: please rename
`notmuch-thousands-separator' to `notmuch-hello-thousands-separator'.

If you decide to make another patch that changes the default to a space,
please add this link [1] to the preamble and a citation:

  Therefore the space is recommended in the SI/ISO 31-0 standard,
  and the International Bureau of Weights and Measures states that for
  numbers with many digits the digits may be divided into groups of
  three by a thin space, in order to facilitate reading. Neither dots
  nor commas are inserted in the spaces between groups of three.

Regards,
  Dmitry

[1] http://en.wikipedia.org/wiki/Decimal_separator#Digit_grouping

 -- 
 Thomas/Schnouki
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Dmitry Kurochkin]

On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner  wrote:
> On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin  gmail.com> wrote:
> > 
> > What do perople think about making the thousands separator a space by
> > default?
> > 
> 
> Is that really good for a majority of users? I had never heard of it
> until now. I know this is hardly scientific, but still...
> 

Well, to me "1 000 000 000" looks better than "1,000,000,000".  But I do
not know about the others.  That is why I was asking :)

Regards,
  Dmitry

> d

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[David Bremner]

On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin  wrote:
> 
> What do perople think about making the thousands separator a space by
> default?
> 

Is that really good for a majority of users? I had never heard of it
until now. I know this is hardly scientific, but still...

d

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Dmitry Kurochkin]

On Tue, 13 Dec 2011 18:32:11 +0100, Thomas Jost  
wrote:
> In 123,456.78, "." is the decimal separator, but "," is the thousands 
> separator.
> 
> This commit also mentions the space being used as thousands separator in 
> several
> European countries.
> ---

What do perople think about making the thousands separator a space by
default?

>  emacs/notmuch-hello.el |8 
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 0582cae..0fe9c1d 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -131,10 +131,10 @@ So:
> (integer :tag "Number of characters")
> (float :tag "Fraction of window")))
>  
> -(defcustom notmuch-decimal-separator ","
> -  "The string used as a decimal separator.
> +(defcustom notmuch-thousands-separator ","
> +  "The string used as a thousands separator.

I suggest renaming this to notmuch-hello-thousands-separator.

Looks good otherwise.

Regards,
  Dmitry

>  
> -Typically \",\" in the US and UK and \".\" in Europe."
> +Typically \",\" in the US and UK and \".\" or \" \" in Europe."
>:group 'notmuch
>:type 'string)
>  
> @@ -159,7 +159,7 @@ Typically \",\" in the US and UK and \".\" in Europe."
>  (apply #'concat
>   (number-to-string (car result))
>   (mapcar (lambda (elem)
> -   (format "%s%03d" notmuch-decimal-separator elem))
> +   (format "%s%03d" notmuch-thousands-separator elem))
>(cdr result)
>  
>  (defun notmuch-hello-trim (search)
> -- 
> 1.7.8
> 
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[David Bremner]

On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin 
dmitry.kuroch...@gmail.com wrote:
 
 What do perople think about making the thousands separator a space by
 default?
 

Is that really good for a majority of users? I had never heard of it
until now. I know this is hardly scientific, but still...

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Dmitry Kurochkin]

On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner da...@tethera.net wrote:
 On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin 
 dmitry.kuroch...@gmail.com wrote:
  
  What do perople think about making the thousands separator a space by
  default?
  
 
 Is that really good for a majority of users? I had never heard of it
 until now. I know this is hardly scientific, but still...
 

Well, to me 1 000 000 000 looks better than 1,000,000,000.  But I do
not know about the others.  That is why I was asking :)

Regards,
  Dmitry

 d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Dmitry Kurochkin]

On Tue, 13 Dec 2011 18:32:11 +0100, Thomas Jost schno...@schnouki.net wrote:
 In 123,456.78, . is the decimal separator, but , is the thousands 
 separator.
 
 This commit also mentions the space being used as thousands separator in 
 several
 European countries.
 ---

What do perople think about making the thousands separator a space by
default?

  emacs/notmuch-hello.el |8 
  1 files changed, 4 insertions(+), 4 deletions(-)
 
 diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
 index 0582cae..0fe9c1d 100644
 --- a/emacs/notmuch-hello.el
 +++ b/emacs/notmuch-hello.el
 @@ -131,10 +131,10 @@ So:
 (integer :tag Number of characters)
 (float :tag Fraction of window)))
  
 -(defcustom notmuch-decimal-separator ,
 -  The string used as a decimal separator.
 +(defcustom notmuch-thousands-separator ,
 +  The string used as a thousands separator.

I suggest renaming this to notmuch-hello-thousands-separator.

Looks good otherwise.

Regards,
  Dmitry

  
 -Typically \,\ in the US and UK and \.\ in Europe.
 +Typically \,\ in the US and UK and \.\ or \ \ in Europe.
:group 'notmuch
:type 'string)
  
 @@ -159,7 +159,7 @@ Typically \,\ in the US and UK and \.\ in Europe.
  (apply #'concat
   (number-to-string (car result))
   (mapcar (lambda (elem)
 -   (format %s%03d notmuch-decimal-separator elem))
 +   (format %s%03d notmuch-thousands-separator elem))
(cdr result)
  
  (defun notmuch-hello-trim (search)
 -- 
 1.7.8
 
 ___
 notmuch mailing list
 notmuch@notmuchmail.org
 http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Thomas Jost]

In 123,456.78, "." is the decimal separator, but "," is the thousands separator.

This commit also mentions the space being used as thousands separator in several
European countries.
---
 emacs/notmuch-hello.el |8 
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 0582cae..0fe9c1d 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -131,10 +131,10 @@ So:
  (integer :tag "Number of characters")
  (float :tag "Fraction of window")))

-(defcustom notmuch-decimal-separator ","
-  "The string used as a decimal separator.
+(defcustom notmuch-thousands-separator ","
+  "The string used as a thousands separator.

-Typically \",\" in the US and UK and \".\" in Europe."
+Typically \",\" in the US and UK and \".\" or \" \" in Europe."
   :group 'notmuch
   :type 'string)

@@ -159,7 +159,7 @@ Typically \",\" in the US and UK and \".\" in Europe."
 (apply #'concat
  (number-to-string (car result))
  (mapcar (lambda (elem)
- (format "%s%03d" notmuch-decimal-separator elem))
+ (format "%s%03d" notmuch-thousands-separator elem))
 (cdr result)

 (defun notmuch-hello-trim (search)
-- 
1.7.8

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Thomas Jost]

In 123,456.78, . is the decimal separator, but , is the thousands separator.

This commit also mentions the space being used as thousands separator in several
European countries.
---
 emacs/notmuch-hello.el |8 
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 0582cae..0fe9c1d 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -131,10 +131,10 @@ So:
  (integer :tag Number of characters)
  (float :tag Fraction of window)))
 
-(defcustom notmuch-decimal-separator ,
-  The string used as a decimal separator.
+(defcustom notmuch-thousands-separator ,
+  The string used as a thousands separator.
 
-Typically \,\ in the US and UK and \.\ in Europe.
+Typically \,\ in the US and UK and \.\ or \ \ in Europe.
   :group 'notmuch
   :type 'string)
 
@@ -159,7 +159,7 @@ Typically \,\ in the US and UK and \.\ in Europe.
 (apply #'concat
  (number-to-string (car result))
  (mapcar (lambda (elem)
- (format %s%03d notmuch-decimal-separator elem))
+ (format %s%03d notmuch-thousands-separator elem))
 (cdr result)
 
 (defun notmuch-hello-trim (search)
-- 
1.7.8

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch