Re: [RFC] [PATCH v1 0/2] Improve the display of headers.
Hi David, I like the idea of aligning the headers, but won't padding with spaces from the left break code that expects at the beginning of the line? Servilio ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC] [PATCH v1 0/2] Improve the display of headers.
On Thu, Jan 05 2017, Servilio Afre Puentes wrote: > I like the idea of aligning the headers, but won't padding with spaces > from the left break code that expects at the beginning of the line? It would. Do you know of such code? The one piece that I noticed (that coloured the headers) I re-worked. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC] [PATCH v1 0/2] Improve the display of headers.
On Fri, Dec 30 2016, David Bremner wrote: > David Edmondson writes: > >> On Thu, Dec 29 2016, David Bremner wrote: >> >>> David Edmondson writes: >>> This is a pair of patches that attempt to make header display more pleasant to look at. RFC! I will update the tests if the results of the changes are considered useful, of course. >>> >>> Hi David; >>> >>> The wrapping seems a bit fragile. Some of the lines are wrapped to the >>> left column and others line up with the headers. To reproduce, try >>> id:87wpgjxeia@nikula.org at about 40 columns. It looks like two >>> different kinds of wrapping going on. >> >> This doesn't reproduce for me. Do you have any interesting settings >> relating to line wrapping or truncation? > > I don't think so. I can duplicate this with ./devel/try-emacs-mua -Q > with emacs 24 and 25. Ah, this is caused by `truncate-lines' being `nil', which is the result of `notmuch-show-hook' including `notmuch-show-turn-on-visual-line-mode' by default - I have never used that. Ugh, so the implication of this is that most people are seeing horribly wrapped headers all of the time! ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC] [PATCH v1 0/2] Improve the display of headers.
David Edmondson writes: > On Thu, Dec 29 2016, David Bremner wrote: > >> David Edmondson writes: >> >>> This is a pair of patches that attempt to make header display more >>> pleasant to look at. RFC! >>> >>> I will update the tests if the results of the changes are considered >>> useful, of course. >>> >> >> Hi David; >> >> The wrapping seems a bit fragile. Some of the lines are wrapped to the >> left column and others line up with the headers. To reproduce, try >> id:87wpgjxeia@nikula.org at about 40 columns. It looks like two >> different kinds of wrapping going on. > > This doesn't reproduce for me. Do you have any interesting settings > relating to line wrapping or truncation? I don't think so. I can duplicate this with ./devel/try-emacs-mua -Q with emacs 24 and 25. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC] [PATCH v1 0/2] Improve the display of headers.
On Thu, Dec 29 2016, David Bremner wrote: > David Edmondson writes: > >> This is a pair of patches that attempt to make header display more >> pleasant to look at. RFC! >> >> I will update the tests if the results of the changes are considered >> useful, of course. >> > > Hi David; > > The wrapping seems a bit fragile. Some of the lines are wrapped to the > left column and others line up with the headers. To reproduce, try > id:87wpgjxeia@nikula.org at about 40 columns. It looks like two > different kinds of wrapping going on. This doesn't reproduce for me. Do you have any interesting settings relating to line wrapping or truncation? > About aligning the headers I'm not sure how I feel yet. I probably > need to use it a bit to give an informed opinion. I agree it makes > the individual headers easier to pick out, but I have some kind of > knee jerk reaction to using up space that way. That might be my 1980s > VT52 instincts kicking in uselessly though. Agreed. I've been playing with another patch to hide the wrapped headers behind a button, but that is running into difficulties with `indent-rigidly' and invisible text... ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC] [PATCH v1 0/2] Improve the display of headers.
David Edmondson writes: > This is a pair of patches that attempt to make header display more > pleasant to look at. RFC! > > I will update the tests if the results of the changes are considered > useful, of course. > Hi David; The wrapping seems a bit fragile. Some of the lines are wrapped to the left column and others line up with the headers. To reproduce, try id:87wpgjxeia@nikula.org at about 40 columns. It looks like two different kinds of wrapping going on. About aligning the headers I'm not sure how I feel yet. I probably need to use it a bit to give an informed opinion. I agree it makes the individual headers easier to pick out, but I have some kind of knee jerk reaction to using up space that way. That might be my 1980s VT52 instincts kicking in uselessly though. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[RFC] [PATCH v1 0/2] Improve the display of headers.
This is a pair of patches that attempt to make header display more pleasant to look at. RFC! I will update the tests if the results of the changes are considered useful, of course. David Edmondson (2): emacs: show: Align the colon in header display emacs: show: Wrap headers for display emacs/notmuch-show.el | 124 +- 1 file changed, 83 insertions(+), 41 deletions(-) -- 2.11.0 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
