Re: [RFC PATCH 5/5] cli: add support for deduplicating based on case insensitive address

2015-08-31 Thread Tomi Ollila
On Sun, Aug 30 2015, David Bremner wrote: > Jani Nikula writes: > >> Consider all variants of an email address as one, and print the most >> common variant. > > Other than the quibbles already mentioned, the series looks ok to > me. For production it should

Re: [RFC PATCH 5/5] cli: add support for deduplicating based on case insensitive address

2015-08-31 Thread David Bremner
Tomi Ollila writes: >> I can live with the current argument syntax, but since a certain a mount >> of bikeshedding is expected, here is an alternative suggestion >> >> --deduplication={none|mailbox|address} > > (is s/deduplicate/deduplication/ intended or accidental change?)

Re: [RFC PATCH 5/5] cli: add support for deduplicating based on case insensitive address

2015-08-30 Thread David Bremner
Jani Nikula j...@nikula.org writes: Consider all variants of an email address as one, and print the most common variant. Other than the quibbles already mentioned, the series looks ok to me. For production it should have one or two tests I guess. Oh, and man page updates. But you knew that I