[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-04 Thread Austin Clements
On Mon, Oct 31, 2011 at 6:07 PM, Jani Nikula wrote: > On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins finestructure.net> wrote: >> In order to push forward with this, though, I think we really need to >> have a complete unit test for this new functionality. ?We usually like >> to see un

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-04 Thread Austin Clements
On Mon, Oct 31, 2011 at 6:07 PM, Jani Nikula wrote: > On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins > wrote: >> In order to push forward with this, though, I think we really need to >> have a complete unit test for this new functionality.  We usually like >> to see units tests that d

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-02 Thread Jani Nikula
On Tue, 01 Nov 2011 09:30:56 -0300, David Bremner wrote: > Is just because it add a function to the library that you think this > might be problematic? I don't think we are super-dogmatic about the > library never growing. When notmuch started, there were no bindings, so > in retrospect maybe mo

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-02 Thread Jani Nikula
On Tue, 01 Nov 2011 09:30:56 -0300, David Bremner wrote: > Is just because it add a function to the library that you think this > might be problematic? I don't think we are super-dogmatic about the > library never growing. When notmuch started, there were no bindings, so > in retrospect maybe mo

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread David Bremner
On Mon, 31 Oct 2011 23:18:07 +0200, Jani Nikula wrote: > > I'm still marking it as RFC. It works for me, but patch 1 might be deemed > unacceptable. > Hi Jani; Is just because it add a function to the library that you think this might be problematic? I don't think we are super-dogmatic about

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread David Bremner
On Mon, 31 Oct 2011 23:18:07 +0200, Jani Nikula wrote: > > I'm still marking it as RFC. It works for me, but patch 1 might be deemed > unacceptable. > Hi Jani; Is just because it add a function to the library that you think this might be problematic? I don't think we are super-dogmatic about

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread Jani Nikula
On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins wrote: > Hi, Jani. Thanks for working on this. This should also be valuable for > vim users. Thanks for your interest! :) > In order to push forward with this, though, I think we really need to > have a complete unit test for this new f

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jani Nikula
Hi, this is an iteration of id:"cover.1319833617.git.jani at nikula.org" addressing comments on the list and IRC. Main changes: * Results are now limited based on threads (not messages) for thread and summary output. This is accomplished with a new lib function to count the number of threads

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jameson Graef Rollins
On Tue, 01 Nov 2011 00:07:59 +0200, Jani Nikula wrote: > On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins > wrote: > Right. I'd just like to make sure the approach I've taken (particularly > patch 1 in the set as it touches the lib) is acceptable before spending > time on testing and do

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jameson Graef Rollins
On Tue, 01 Nov 2011 00:07:59 +0200, Jani Nikula wrote: > On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins finestructure.net> wrote: > Right. I'd just like to make sure the approach I've taken (particularly > patch 1 in the set as it touches the lib) is acceptable before spending > time o

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jani Nikula
On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins wrote: > Hi, Jani. Thanks for working on this. This should also be valuable for > vim users. Thanks for your interest! :) > In order to push forward with this, though, I think we really need to > have a complete unit test for this new

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jameson Graef Rollins
On Mon, 31 Oct 2011 23:18:07 +0200, Jani Nikula wrote: > Hi, this is an iteration of id:"cover.1319833617.git.j...@nikula.org" > addressing > comments on the list and IRC. Main changes: > > * Results are now limited based on threads (not messages) for thread and > summary > output. This is ac

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jameson Graef Rollins
On Mon, 31 Oct 2011 23:18:07 +0200, Jani Nikula wrote: > Hi, this is an iteration of id:"cover.1319833617.git.jani at nikula.org" > addressing > comments on the list and IRC. Main changes: > > * Results are now limited based on threads (not messages) for thread and > summary > output. This is

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jani Nikula
Hi, this is an iteration of id:"cover.1319833617.git.j...@nikula.org" addressing comments on the list and IRC. Main changes: * Results are now limited based on threads (not messages) for thread and summary output. This is accomplished with a new lib function to count the number of threads in m