[RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

[Mark Walters]

On Mon, 13 Feb 2012 14:35:31 +0530, "Aneesh Kumar K.V"  wrote:
> On Sun, 12 Feb 2012 18:49:36 +, Mark Walters  gmail.com> wrote:
> > Here is a rebased version of the notmuch-pick patch set
> > id:"87d39k1gvi.fsf at qmul.ac.uk". It now applies directly 
> > to master since Jani's notmuch-show command line parsing 
> > has been pushed.
> > 
> > It includes the significant bug fix (at least for anyone working 
> > with a dark background) from Daniel making matched messages 
> > highlight color both configurable and have a sensible default.
> > These are in the notmuch-pick subgroup of the customize menus.
> > 

Hi

> Really nice patchset. It would be really nice if we can get the serach
> limit patchset before this. That way the pick result will be limitted.

Do you mean id:"1327692900-22926-1-git-send-email-jani at nikula.org"? That
would not affect notmuch-pick. In fact, since notmuch-pick uses
notmuch-show.c rather than notmuch-search.c the cli doesn't have the
--limit option. You are quite right that this may be the way to go
though.

> I also noticied that mails are not marked as read when i select them in
> the notmuch-pick mode. Also for me the tree structures appears as
> below. 

Are they not marked as read at all, or just not marked as read in the
notmuch-pick display (try pressing '=' and see if they are shown
correctly on refresh). It would be very nice to have the tags refresh
automatically but I have not implemented it (it may be beyond my lisp-fu).

>  Today 00:19  Mark Walters  ???[RFC PATCH v2 1/3] cli: notmuch-show 
> changes to support pick (notmuch)
>  Today 02:38  Daniel Schoepe ...  
> (notmuch, signed)
>  Today 03:38  Mark Walters   ...  
> (notmuch)
>  Today 00:19  Mark Walters  ???[RFC PATCH v2 2/3] emacs: changes to 
> other files to support notmuch-pick (notmuch)
>  Today 03:57  Mark Walters   ...  
> (notmuch)
>  Today 00:19  Mark Walters  ???[RFC PATCH v2 3/3] emacs: add 
> notmuch-pick itself  (notmuch)

I am not quite sure what this looks like (as I am not sure what is my
emacs doing things and what is what you sent. Could you send me a
screenshot (and an explanation of what is wrong if it is not clear from
the screenshot)?

Thanks

Mark

[RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

[Aneesh Kumar K.V]

On Sun, 12 Feb 2012 18:49:36 +, Mark Walters  
wrote:
> Here is a rebased version of the notmuch-pick patch set
> id:"87d39k1gvi.fsf at qmul.ac.uk". It now applies directly 
> to master since Jani's notmuch-show command line parsing 
> has been pushed.
> 
> It includes the significant bug fix (at least for anyone working 
> with a dark background) from Daniel making matched messages 
> highlight color both configurable and have a sensible default.
> These are in the notmuch-pick subgroup of the customize menus.
> 

Really nice patchset. It would be really nice if we can get the serach
limit patchset before this. That way the pick result will be limitted.
I also noticied that mails are not marked as read when i select them in
the notmuch-pick mode. Also for me the tree structures appears as
below. 

 Today 00:19  Mark Walters  ???[RFC PATCH v2 1/3] cli: notmuch-show 
changes to support pick (notmuch)
 Today 02:38  Daniel Schoepe ...
  (notmuch, signed)
 Today 03:38  Mark Walters   ...
  (notmuch)
 Today 00:19  Mark Walters  ???[RFC PATCH v2 2/3] emacs: changes to 
other files to support notmuch-pick (notmuch)
 Today 03:57  Mark Walters   ...
  (notmuch)
 Today 00:19  Mark Walters  ???[RFC PATCH v2 3/3] emacs: add 
notmuch-pick itself  (notmuch)

Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

[Mark Walters]

On Mon, 13 Feb 2012 14:35:31 +0530, "Aneesh Kumar K.V" 
 wrote:
> On Sun, 12 Feb 2012 18:49:36 +, Mark Walters  
> wrote:
> > Here is a rebased version of the notmuch-pick patch set
> > id:"87d39k1gvi@qmul.ac.uk". It now applies directly 
> > to master since Jani's notmuch-show command line parsing 
> > has been pushed.
> > 
> > It includes the significant bug fix (at least for anyone working 
> > with a dark background) from Daniel making matched messages 
> > highlight color both configurable and have a sensible default.
> > These are in the notmuch-pick subgroup of the customize menus.
> > 

Hi

> Really nice patchset. It would be really nice if we can get the serach
> limit patchset before this. That way the pick result will be limitted.

Do you mean id:"1327692900-22926-1-git-send-email-j...@nikula.org"? That
would not affect notmuch-pick. In fact, since notmuch-pick uses
notmuch-show.c rather than notmuch-search.c the cli doesn't have the
--limit option. You are quite right that this may be the way to go
though.

> I also noticied that mails are not marked as read when i select them in
> the notmuch-pick mode. Also for me the tree structures appears as
> below. 

Are they not marked as read at all, or just not marked as read in the
notmuch-pick display (try pressing '=' and see if they are shown
correctly on refresh). It would be very nice to have the tags refresh
automatically but I have not implemented it (it may be beyond my lisp-fu).

>  Today 00:19  Mark Walters  ├┬►[RFC PATCH v2 1/3] cli: notmuch-show 
> changes to support pick (notmuch)
>  Today 02:38  Daniel Schoepe│├─► ...  
> (notmuch, signed)
>  Today 03:38  Mark Walters  │╰─► ...  
> (notmuch)
>  Today 00:19  Mark Walters  ├┬►[RFC PATCH v2 2/3] emacs: changes to 
> other files to support notmuch-pick (notmuch)
>  Today 03:57  Mark Walters  │╰─► ...  
> (notmuch)
>  Today 00:19  Mark Walters  ├─►[RFC PATCH v2 3/3] emacs: add 
> notmuch-pick itself  (notmuch)

I am not quite sure what this looks like (as I am not sure what is my
emacs doing things and what is what you sent. Could you send me a
screenshot (and an explanation of what is wrong if it is not clear from
the screenshot)?

Thanks

Mark
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

[Aneesh Kumar K.V]

On Sun, 12 Feb 2012 18:49:36 +, Mark Walters  
wrote:
> Here is a rebased version of the notmuch-pick patch set
> id:"87d39k1gvi@qmul.ac.uk". It now applies directly 
> to master since Jani's notmuch-show command line parsing 
> has been pushed.
> 
> It includes the significant bug fix (at least for anyone working 
> with a dark background) from Daniel making matched messages 
> highlight color both configurable and have a sensible default.
> These are in the notmuch-pick subgroup of the customize menus.
> 

Really nice patchset. It would be really nice if we can get the serach
limit patchset before this. That way the pick result will be limitted.
I also noticied that mails are not marked as read when i select them in
the notmuch-pick mode. Also for me the tree structures appears as
below. 

 Today 00:19  Mark Walters  ├┬►[RFC PATCH v2 1/3] cli: notmuch-show 
changes to support pick (notmuch)
 Today 02:38  Daniel Schoepe│├─► ...
  (notmuch, signed)
 Today 03:38  Mark Walters  │╰─► ...
  (notmuch)
 Today 00:19  Mark Walters  ├┬►[RFC PATCH v2 2/3] emacs: changes to 
other files to support notmuch-pick (notmuch)
 Today 03:57  Mark Walters  │╰─► ...
  (notmuch)
 Today 00:19  Mark Walters  ├─►[RFC PATCH v2 3/3] emacs: add 
notmuch-pick itself  (notmuch)


___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

[Mark Walters]

On Sun, 12 Feb 2012 12:39:13 -0800, Jameson Graef Rollins  wrote:
> On Sun, 12 Feb 2012 18:49:36 +, Mark Walters  gmail.com> wrote:
> > Here is a rebased version of the notmuch-pick patch set
> > id:"87d39k1gvi.fsf at qmul.ac.uk". It now applies directly 
> > to master since Jani's notmuch-show command line parsing 
> > has been pushed.
> 
> Hey, Mark.  Thanks for working on this.  However, none of the patches
> have commit messages, so there's no explanation for what any of the
> patches are supposed to do.  This is particularly bothersome for the
> first patch, which introduces a lot of unexplained changes to the cli.
> 
> I think I would like to review this patch set, since I think I'm
> interested in the functionality it may be introducing, but without any
> commit messages or explanation what the patches are meant to do it's
> kind of a non starter for me.

Hi 

At the moment I was mostly looking for feedback on whether people like
the final outcome (i.e., whether people liked it enough to be worth
tidying). I will add comments on the first two patches.

Best wishes

Mark

[RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

[Mark Walters]

Here is a rebased version of the notmuch-pick patch set
id:"87d39k1gvi.fsf at qmul.ac.uk". It now applies directly 
to master since Jani's notmuch-show command line parsing 
has been pushed.

It includes the significant bug fix (at least for anyone working 
with a dark background) from Daniel making matched messages 
highlight color both configurable and have a sensible default.
These are in the notmuch-pick subgroup of the customize menus.

Best wishes

Mark

Mark Walters (3):
  cli: notmuch-show changes to support pick
  emacs: changes to other files to support notmuch-pick
  emacs: add notmuch-pick itself

 emacs/Makefile.local   |3 +-
 emacs/notmuch-hello.el |   10 +
 emacs/notmuch-lib.el   |4 +
 emacs/notmuch-pick.el  |  585 
 emacs/notmuch-query.el |4 +-
 emacs/notmuch-show.el  |   25 ++-
 emacs/notmuch.el   |8 +
 notmuch-client.h   |9 +-
 notmuch-show.c |   90 +++-
 9 files changed, 722 insertions(+), 16 deletions(-)
 create mode 100644 emacs/notmuch-pick.el

-- 
1.7.2.3

Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

[Mark Walters]

On Sun, 12 Feb 2012 12:39:13 -0800, Jameson Graef Rollins 
 wrote:
> On Sun, 12 Feb 2012 18:49:36 +, Mark Walters  
> wrote:
> > Here is a rebased version of the notmuch-pick patch set
> > id:"87d39k1gvi@qmul.ac.uk". It now applies directly 
> > to master since Jani's notmuch-show command line parsing 
> > has been pushed.
> 
> Hey, Mark.  Thanks for working on this.  However, none of the patches
> have commit messages, so there's no explanation for what any of the
> patches are supposed to do.  This is particularly bothersome for the
> first patch, which introduces a lot of unexplained changes to the cli.
> 
> I think I would like to review this patch set, since I think I'm
> interested in the functionality it may be introducing, but without any
> commit messages or explanation what the patches are meant to do it's
> kind of a non starter for me.

Hi 

At the moment I was mostly looking for feedback on whether people like
the final outcome (i.e., whether people liked it enough to be worth
tidying). I will add comments on the first two patches.

Best wishes

Mark

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

[Jameson Graef Rollins]

On Sun, 12 Feb 2012 18:49:36 +, Mark Walters  
wrote:
> Here is a rebased version of the notmuch-pick patch set
> id:"87d39k1gvi@qmul.ac.uk". It now applies directly 
> to master since Jani's notmuch-show command line parsing 
> has been pushed.

Hey, Mark.  Thanks for working on this.  However, none of the patches
have commit messages, so there's no explanation for what any of the
patches are supposed to do.  This is particularly bothersome for the
first patch, which introduces a lot of unexplained changes to the cli.

I think I would like to review this patch set, since I think I'm
interested in the functionality it may be introducing, but without any
commit messages or explanation what the patches are meant to do it's
kind of a non starter for me.

jamie.


pgpJOooCk0ETs.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

[Jameson Graef Rollins]

On Sun, 12 Feb 2012 18:49:36 +, Mark Walters  
wrote:
> Here is a rebased version of the notmuch-pick patch set
> id:"87d39k1gvi.fsf at qmul.ac.uk". It now applies directly 
> to master since Jani's notmuch-show command line parsing 
> has been pushed.

Hey, Mark.  Thanks for working on this.  However, none of the patches
have commit messages, so there's no explanation for what any of the
patches are supposed to do.  This is particularly bothersome for the
first patch, which introduces a lot of unexplained changes to the cli.

I think I would like to review this patch set, since I think I'm
interested in the functionality it may be introducing, but without any
commit messages or explanation what the patches are meant to do it's
kind of a non starter for me.

jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

[RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

[Mark Walters]

Here is a rebased version of the notmuch-pick patch set
id:"87d39k1gvi@qmul.ac.uk". It now applies directly 
to master since Jani's notmuch-show command line parsing 
has been pushed.

It includes the significant bug fix (at least for anyone working 
with a dark background) from Daniel making matched messages 
highlight color both configurable and have a sensible default.
These are in the notmuch-pick subgroup of the customize menus.

Best wishes

Mark

Mark Walters (3):
  cli: notmuch-show changes to support pick
  emacs: changes to other files to support notmuch-pick
  emacs: add notmuch-pick itself

 emacs/Makefile.local   |3 +-
 emacs/notmuch-hello.el |   10 +
 emacs/notmuch-lib.el   |4 +
 emacs/notmuch-pick.el  |  585 
 emacs/notmuch-query.el |4 +-
 emacs/notmuch-show.el  |   25 ++-
 emacs/notmuch.el   |8 +
 notmuch-client.h   |9 +-
 notmuch-show.c |   90 +++-
 9 files changed, 722 insertions(+), 16 deletions(-)
 create mode 100644 emacs/notmuch-pick.el

-- 
1.7.2.3

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch