[notmuch] [PATCH] Build and link against notmuch shared library

2010-03-11 Thread Ben Gamari
--- .gitignore |1 + Makefile |1 + Makefile.local |9 ++--- lib/Makefile.local | 11 ++- 4 files changed, 14 insertions(+), 8 deletions(-) diff --git a/.gitignore b/.gitignore index efa98fb..daf8094 100644 --- a/.gitignore +++ b/.gitignore @@ -5,6

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-26 Thread Ben Gamari
Inger in #notmuch brought to light some build issues that will occur when the notmuch binary is being built before libnotmuch is installed. Here is an updated patch that resolves these issues. --- .gitignore |1 + Makefile |1 + Makefile.local |6 --

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-25 Thread Ben Gamari
Inger in #notmuch brought to light some build issues that will occur when the notmuch binary is being built before libnotmuch is installed. Here is an updated patch that resolves these issues. --- .gitignore |1 + Makefile |1 + Makefile.local |6 --

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-24 Thread Scott Robinson
Excerpts from bgamari.foss's message of Sat Jan 23 12:58:42 -0600 2010: > True, but I don't think that this means that we need to link the > executable with a C++ compiler. I've tried linking with CC and it seems > to succeed, so I don't think there should be a problem changing it. > Are you

Re: [notmuch] [PATCH] Build and link against notmuch shared library

2010-01-24 Thread Scott Robinson
Excerpts from bgamari.foss's message of Sat Jan 23 12:58:42 -0600 2010: True, but I don't think that this means that we need to link the executable with a C++ compiler. I've tried linking with CC and it seems to succeed, so I don't think there should be a problem changing it. Are you using

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-23 Thread bgamari.foss
Excerpts from Ingmar Vanhassel's message of Fri Jan 22 21:06:00 -0500 2010: > On Sat, 23 Jan 2010 02:58:53 +0200, Felipe Contreras gmail.com> wrote: > > Does it need to be CXX? Why not CC instead? > > Xapian and the notmuch wrapper 'parts' are written in C++. > True, but I don't think that this

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-23 Thread Ben Gamari
Excerpts from Felipe Contreras's message of Fri Jan 22 19:58:53 -0500 2010: > Does it need to be CXX? Why not CC instead? > Nope. It's been changed to CC. Thanks! - Ben

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-23 Thread Felipe Contreras
On Wed, Jan 20, 2010 at 10:35 PM, Ben Gamari wrote: > ?libnotmuch_modules = $(libnotmuch_c_srcs:.c=.o) $(libnotmuch_cxx_srcs:.cc=.o) > -$(dir)/notmuch.a: $(libnotmuch_modules) > - ? ? ? $(call quiet,AR) rcs $@ $^ > +$(dir)/$(SONAME): $(libnotmuch_modules) > + ? ? ? $(call quiet,CXX,$(LDFLAGS)) $^

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-23 Thread Ingmar Vanhassel
On Sat, 23 Jan 2010 02:58:53 +0200, Felipe Contreras wrote: > On Wed, Jan 20, 2010 at 10:35 PM, Ben Gamari > wrote: > > ??libnotmuch_modules = $(libnotmuch_c_srcs:.c=.o) > > $(libnotmuch_cxx_srcs:.cc=.o) > > -$(dir)/notmuch.a: $(libnotmuch_modules) > > - ?? ?? ?? $(call quiet,AR) rcs $@ $^ > >

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-20 Thread Mike Hommey
On Wed, Jan 20, 2010 at 03:07:27PM -0500, Ben Gamari wrote: > + install lib/libnotmuch.so $(DESTDIR)$(prefix)/lib/ > +$(dir)/libnotmuch.so: $(libnotmuch_modules) > + $(call quiet,CXX,$(LDFLAGS)) $^ $(FINAL_LDFLAGS) -shared -o $@ If you're going to install that in $(prefix)/lib, you'd

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-20 Thread Ben Gamari
How's this look? --- Makefile |1 + Makefile.local |6 -- lib/Makefile.local | 10 ++ 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 021fdb8..0f56bc6 100644 --- a/Makefile +++ b/Makefile @@ -1,3 +1,4 @@ +SONAME =

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-20 Thread Ben Gamari
--- Makefile.local |5 +++-- lib/Makefile.local |8 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Makefile.local b/Makefile.local index 933ff4c..6e851e4 100644 --- a/Makefile.local +++ b/Makefile.local @@ -21,8 +21,8 @@ notmuch_client_srcs = \

[notmuch] [PATCH] Build and link against notmuch shared library

2010-01-20 Thread Ben Gamari
--- Makefile.local |5 +++-- lib/Makefile.local |8 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Makefile.local b/Makefile.local index 933ff4c..6e851e4 100644 --- a/Makefile.local +++ b/Makefile.local @@ -21,8 +21,8 @@ notmuch_client_srcs = \

Re: [notmuch] [PATCH] Build and link against notmuch shared library

2010-01-20 Thread Mike Hommey
On Wed, Jan 20, 2010 at 03:07:27PM -0500, Ben Gamari wrote: + install lib/libnotmuch.so $(DESTDIR)$(prefix)/lib/ +$(dir)/libnotmuch.so: $(libnotmuch_modules) + $(call quiet,CXX,$(LDFLAGS)) $^ $(FINAL_LDFLAGS) -shared -o $@ If you're going to install that in $(prefix)/lib, you'd better