[notmuch] [PATCH] Missing final semi-colon in .desktop's Categories.

2009-11-22 Thread Carl Worth
On Sun, 22 Nov 2009 01:07:49 -0600, Jeffrey Ollie  wrote:
> Found the same problem on my own, only to minutes later catch up on
> the backlog of patches in my email and find this!
...
> > Signed-off-by: James Rowe 
> 
> Reviewed-by: Jeffrey C. Ollie 

Much thanks, James and Jeffrey!

I always feel *much* more comfortable pushing a patch I haven't tested
personally if someone else has reviewed it.

-Carl


[notmuch] [PATCH] Missing final semi-colon in .desktop's Categories.

2009-11-22 Thread Jeffrey Ollie
Found the same problem on my own, only to minutes later catch up on
the backlog of patches in my email and find this!

On Sat, Nov 21, 2009 at 3:13 AM, James Rowe  wrote:
> "Those keys which have several values should have a semicolon as the trailing
> character."
> ?-- http://standards.freedesktop.org/desktop-entry-spec/1.0/ar01s03.html
>
> Signed-off-by: James Rowe 

Reviewed-by: Jeffrey C. Ollie 

> ---
> ?notmuch.desktop | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/notmuch.desktop b/notmuch.desktop
> index d29dff6..819cd1e 100644
> --- a/notmuch.desktop
> +++ b/notmuch.desktop
> @@ -4,4 +4,4 @@ Exec=emacs -f notmuch
> ?Icon=emblem-mail
> ?Terminal=false
> ?Type=Application
> -Categories=Network;Email
> +Categories=Network;Email;
> --
> 1.6.4.4
>
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
>



-- 
Jeff Ollie


[notmuch] [PATCH] Missing final semi-colon in .desktop's Categories.

2009-11-21 Thread James Rowe
"Those keys which have several values should have a semicolon as the trailing
character."
  -- http://standards.freedesktop.org/desktop-entry-spec/1.0/ar01s03.html

Signed-off-by: James Rowe 
---
 notmuch.desktop |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/notmuch.desktop b/notmuch.desktop
index d29dff6..819cd1e 100644
--- a/notmuch.desktop
+++ b/notmuch.desktop
@@ -4,4 +4,4 @@ Exec=emacs -f notmuch
 Icon=emblem-mail
 Terminal=false
 Type=Application
-Categories=Network;Email
+Categories=Network;Email;
-- 
1.6.4.4