[notmuch] [PATCH] Solaris doesn't have 'struct dirent::d_type'

2009-12-21 Thread Tomas Carnecky
On 12/20/09 7:02 PM, James Westby wrote: > From: Tomas Carnecky > > Use stat(2) instead. > > Signed-off-by: Tomas Carnecky > Signed-off-by: James Westby > --- > >The original patch duplicated asprintf and stat calls, rearraging >the code means we don't need to. > >I have a concern about

Re: [notmuch] [PATCH] Solaris doesn't have 'struct dirent::d_type'

2009-12-21 Thread Tomas Carnecky
On 12/20/09 7:02 PM, James Westby wrote: From: Tomas Carnecky Use stat(2) instead. Signed-off-by: Tomas Carnecky Signed-off-by: James Westby --- The original patch duplicated asprintf and stat calls, rearraging the code means we don't need to. I have a concern about the duplicated st

[notmuch] [PATCH] Solaris doesn't have 'struct dirent::d_type'

2009-12-20 Thread James Westby
From: Tomas Carnecky Use stat(2) instead. Signed-off-by: Tomas Carnecky Signed-off-by: James Westby --- The original patch duplicated asprintf and stat calls, rearraging the code means we don't need to. I have a concern about the duplicated stats in is_maildir, but they are not so ea

[notmuch] [PATCH] Solaris doesn't have 'struct dirent::d_type'

2009-12-20 Thread Tomas Carnecky
Use stat(2) instead. Signed-off-by: Tomas Carnecky --- There is a second issue that prevents notmuch from working on Solaris: the getpwuid_r() prototype doesn't have the last argument. But that can be easily worked around by setting -D_POSIX_PTHREAD_SEMANTICS on the compiler commandline. Do you

[notmuch] [PATCH] Solaris doesn't have 'struct dirent::d_type'

2009-12-20 Thread James Westby
From: Tomas Carnecky Use stat(2) instead. Signed-off-by: Tomas Carnecky Signed-off-by: James Westby --- The original patch duplicated asprintf and stat calls, rearraging the code means we don't need to. I have a concern about the duplicated stats in is_maildir, but they are not so ea

[notmuch] [PATCH] Solaris doesn't have 'struct dirent::d_type'

2009-12-20 Thread Tomas Carnecky
Use stat(2) instead. Signed-off-by: Tomas Carnecky --- There is a second issue that prevents notmuch from working on Solaris: the getpwuid_r() prototype doesn't have the last argument. But that can be easily worked around by setting -D_POSIX_PTHREAD_SEMANTICS on the compiler commandline. Do you