[notmuch] [PATCH] Store the size of the file for each message

2009-12-19 Thread Carl Worth
On Sat, 19 Dec 2009 09:02:11 +0100, Marten Veldthuis wrote: > > Anyone have a solution here? > > Something like "git help add" just opens the manpage for git-add. Can't > we do the same here? The granularity is different, though. I like that "notmuch help show" shows just the documentation for

[notmuch] [PATCH] Store the size of the file for each message

2009-12-19 Thread Marten Veldthuis
On Fri, 18 Dec 2009 21:24:10 -0800, Carl Worth wrote: > Currently we're replicating all of our documentation both in the man > page and in the output from "notmuch help". It's annoying to have to > add everything in two places, but I don't have a good idea for making > that sharable yet. > >

[notmuch] [PATCH] Store the size of the file for each message

2009-12-19 Thread James Westby
On Fri, 18 Dec 2009 16:57:16 -0800, Carl Worth wrote: > You can, actually. Just set the NOTMUCH_CONFIG environment variable to > your alternate configuration file. (And yes, we're missing any mention > of this in our documentation.) Sweet. Where would be the best place to document it? Just in

[notmuch] [PATCH] Store the size of the file for each message

2009-12-19 Thread James Westby
On Fri, 18 Dec 2009 14:29:21 -0800, Carl Worth wrote: > On Fri, 18 Dec 2009 21:21:03 +, James Westby jameswestby.net> wrote: > Yes, a value makes sense here and should make the value easy to > retrieve. Excellent. > I usually use a little tool I wrote called xapian-dump. It

Re: [notmuch] [PATCH] Store the size of the file for each message

2009-12-19 Thread Marten Veldthuis
On Fri, 18 Dec 2009 21:24:10 -0800, Carl Worth cwo...@cworth.org wrote: Currently we're replicating all of our documentation both in the man page and in the output from notmuch help. It's annoying to have to add everything in two places, but I don't have a good idea for making that sharable

Re: [notmuch] [PATCH] Store the size of the file for each message

2009-12-19 Thread Carl Worth
On Sat, 19 Dec 2009 09:02:11 +0100, Marten Veldthuis mar...@veldthuis.com wrote: Anyone have a solution here? Something like git help add just opens the manpage for git-add. Can't we do the same here? The granularity is different, though. I like that notmuch help show shows just the

[notmuch] [PATCH] Store the size of the file for each message

2009-12-18 Thread Carl Worth
On Sat, 19 Dec 2009 01:35:46 +, James Westby wrote: > On Fri, 18 Dec 2009 16:57:16 -0800, Carl Worth wrote: > > You can, actually. Just set the NOTMUCH_CONFIG environment variable to > > your alternate configuration file. (And yes, we're missing any mention > >

[notmuch] [PATCH] Store the size of the file for each message

2009-12-18 Thread James Westby
When indexing a message store the filesize along with it so that when we store all the filenames for a message-id we can know if any of them have different content cheaply. The value stored is defined to be the largest filesize of any of the files for that message. This changes the API for

[notmuch] [PATCH] Store the size of the file for each message

2009-12-18 Thread Carl Worth
On Sat, 19 Dec 2009 00:08:24 +, James Westby wrote: > Thanks, I found delve, which at least showed that something was > being stored. It's in the xapian-tools package, and > >delve -V2 > > prints out the filesize value for each document. Ah, right. I had

[notmuch] [PATCH] Store the size of the file for each message

2009-12-18 Thread Carl Worth
On Fri, 18 Dec 2009 21:21:03 +, James Westby wrote: > Here's the first part, storing the filesize. I'm using > add_value so that we can make it sortable, is that valid > for retrieving it as well? Yes, a value makes sense here and should make the value

[notmuch] [PATCH] Store the size of the file for each message

2009-12-18 Thread James Westby
When indexing a message store the filesize along with it so that when we store all the filenames for a message-id we can know if any of them have different content cheaply. The value stored is defined to be the largest filesize of any of the files for that message. This changes the API for

Re: [notmuch] [PATCH] Store the size of the file for each message

2009-12-18 Thread Carl Worth
On Fri, 18 Dec 2009 21:21:03 +, James Westby jw+deb...@jameswestby.net wrote: Here's the first part, storing the filesize. I'm using add_value so that we can make it sortable, is that valid for retrieving it as well? Yes, a value makes sense here and should make the value easy to

Re: [notmuch] [PATCH] Store the size of the file for each message

2009-12-18 Thread James Westby
On Fri, 18 Dec 2009 16:57:16 -0800, Carl Worth cwo...@cworth.org wrote: You can, actually. Just set the NOTMUCH_CONFIG environment variable to your alternate configuration file. (And yes, we're missing any mention of this in our documentation.) Sweet. Where would be the best place to document