[notmuch] [PATCH] makefile: Tell echo to interpret escape sequences.

2009-11-23 Thread Karl Wiberg
On Mon, Nov 23, 2009 at 3:41 AM, Carl Worth  wrote:

> It's a shame that simple things like "echo" aren't easy to use portably.
> (And yes, I know that autoconf has a bunch of tests for echo, such as
> how to get the behavior of "echo -n", etc.)

I think the standard workaround is to use "printf" instead.

-- 
Karl Wiberg, kha at treskal.com
   subrabbit.wordpress.com
   www.treskal.com/kalle


[notmuch] [PATCH] makefile: Tell echo to interpret escape sequences.

2009-11-23 Thread Jan Janak
On Mon, Nov 23, 2009 at 3:41 AM, Carl Worth  wrote:
> On Sun, 22 Nov 2009 13:44:37 +0100, Jan Janak  wrote:
>> The initial message that informs the user about the possibility to use
>> make V=1 contains a \n at the end, but echo wouldn't interpret that
>> properly without the -e command line option.
>
> Patch doesn't work for me.
>
> Before patch:
>
> ? ? ? ?0:~/src/notmuch:(master)$ make
> ? ? ? ?Use "make V=1" to see the verbose compile lines.
> ? ? ? ? ?CC ? ?notmuch-new.o
> ? ? ? ? ?CXX ? notmuch
>
> After patch:
>
> ? ? ? ?0:~/src/notmuch:(master)$ make
> ? ? ? ?-e Use "make V=1" to see the verbose compile lines.
> ? ? ? ? ?CC ? ?debugger.o
> ? ? ? ?-e ? CC gmime-filter-reply.o
> ? ? ? ?-e ? CC notmuch.o
>
> It's a shame that simple things like "echo" aren't easy to use portably.
> (And yes, I know that autoconf has a bunch of tests for echo, such as
> how to get the behavior of "echo -n", etc.)

It seems your echo interprets escape sequences by default. When I run
make, the first line of output looks like this:

Use "make V=1" to see the verbose compile lines.\n  CC  debugger.o
  CCgmime-filter-reply.o
  CCnotmuch.o

This is on Debian Lenny. Anyway, this one is not important either.

  -- Jan


[notmuch] [PATCH] makefile: Tell echo to interpret escape sequences.

2009-11-23 Thread Carl Worth
On Sun, 22 Nov 2009 13:44:37 +0100, Jan Janak  wrote:
> The initial message that informs the user about the possibility to use
> make V=1 contains a \n at the end, but echo wouldn't interpret that
> properly without the -e command line option.

Patch doesn't work for me.

Before patch:

0:~/src/notmuch:(master)$ make
Use "make V=1" to see the verbose compile lines.
  CCnotmuch-new.o
  CXX   notmuch

After patch:

0:~/src/notmuch:(master)$ make 
-e Use "make V=1" to see the verbose compile lines.
  CCdebugger.o
-e   CC gmime-filter-reply.o
-e   CC notmuch.o

It's a shame that simple things like "echo" aren't easy to use portably.
(And yes, I know that autoconf has a bunch of tests for echo, such as
how to get the behavior of "echo -n", etc.)

-Carl


[notmuch] [PATCH] makefile: Tell echo to interpret escape sequences.

2009-11-22 Thread Jan Janak
The initial message that informs the user about the possibility to use
make V=1 contains a \n at the end, but echo wouldn't interpret that
properly without the -e command line option.
---
 Makefile |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index ae8bff1..3553ff4 100644
--- a/Makefile
+++ b/Makefile
@@ -41,7 +41,7 @@ include Makefile.config
 # user how to enable verbose compiles.
 ifeq ($(V),)
 quiet_DOC := "Use \"$(MAKE) V=1\" to see the verbose compile lines.\n"
-quiet = @echo $(quiet_DOC)$(eval quiet_DOC:=)"  $1 $@"; $($1)
+quiet = @echo -e $(quiet_DOC)$(eval quiet_DOC:=)"  $1  $@"; $($1)
 endif
 # The user has explicitly enabled quiet compilation.
 ifeq ($(V),0)
-- 
1.6.3.3