Re: [notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.

[Carl Worth]

On Mon, 15 Feb 2010 09:41:49 +, David Edmondson  wrote:
> ---
>  notmuch.el |2 ++

Thanks, David.

I've pushed this now, (with the later fix from Sebastian applied).

-Carl


pgpagotMKroN6.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.

[Carl Worth]

On Mon, 15 Feb 2010 09:41:49 +, David Edmondson  wrote:
> ---
>  notmuch.el |2 ++

Thanks, David.

I've pushed this now, (with the later fix from Sebastian applied).

-Carl
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 

[notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.

[Michal Sojka]

Nice, it works for me.

On Mon, 15 Feb 2010 10:03:32 +, David Edmondson  wrote:
> This version is over-eager in marking (non-)signatures. The second call
> to 'overlay-put' needs to move inside the 'if' a line below.

Could you please send a fixed patch so that it can be applied easilly.

Michal

[notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.

[David Edmondson]

On Tue, 16 Feb 2010 11:22:01 +0100, Michal Sojka  wrote:
> Nice, it works for me.
> 
> On Mon, 15 Feb 2010 10:03:32 +, David Edmondson  wrote:
> > This version is over-eager in marking (non-)signatures. The second call
> > to 'overlay-put' needs to move inside the 'if' a line below.
> 
> Could you please send a fixed patch so that it can be applied easilly.

Sebastian posted one this morning.

dme.
-- 
David Edmondson, http://dme.org

Re: [notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.

[David Edmondson]

On Tue, 16 Feb 2010 11:22:01 +0100, Michal Sojka  wrote:
> Nice, it works for me.
> 
> On Mon, 15 Feb 2010 10:03:32 +, David Edmondson  wrote:
> > This version is over-eager in marking (non-)signatures. The second call
> > to 'overlay-put' needs to move inside the 'if' a line below.
> 
> Could you please send a fixed patch so that it can be applied easilly.

Sebastian posted one this morning.

dme.
-- 
David Edmondson, http://dme.org
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.

[Michal Sojka]

Nice, it works for me.

On Mon, 15 Feb 2010 10:03:32 +, David Edmondson  wrote:
> This version is over-eager in marking (non-)signatures. The second call
> to 'overlay-put' needs to move inside the 'if' a line below.

Could you please send a fixed patch so that it can be applied easilly.

Michal
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.

[David Edmondson]

This version is over-eager in marking (non-)signatures. The second call
to 'overlay-put' needs to move inside the 'if' a line below.

On Mon, 15 Feb 2010 09:41:49 +, David Edmondson  wrote:
> ---
>  notmuch.el |2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/notmuch.el b/notmuch.el
> index 8090b2f..3e8e50d 100644
> --- a/notmuch.el
> +++ b/notmuch.el
> @@ -703,6 +703,7 @@ is what to put on the button."
>(let* ((cite-start (match-beginning 0))
>(cite-end  (match-end 0))
>(cite-lines (count-lines cite-start cite-end)))
> + (overlay-put (make-overlay cite-start cite-end) 'face 
> 'message-cited-text-face)
>   (when (> cite-lines (1+ notmuch-show-citation-lines-prefix))
> (goto-char cite-start)
> (forward-line notmuch-show-citation-lines-prefix)
> @@ -718,6 +719,7 @@ is what to put on the button."
>   (let* ((sig-start (match-beginning 0))
>  (sig-end (match-end 0))
>  (sig-lines (1- (count-lines sig-start end
> +   (overlay-put (make-overlay sig-start end) 'face 
> 'message-cited-text-face)
> (if (<= sig-lines notmuch-show-signature-lines-max)
> (notmuch-show-region-to-button
>  sig-start
> -- 
> 1.6.6.1
> 

dme.
-- 
David Edmondson, http://dme.org

[notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.

[David Edmondson]

---
 notmuch.el |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/notmuch.el b/notmuch.el
index 8090b2f..3e8e50d 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -703,6 +703,7 @@ is what to put on the button."
   (let* ((cite-start (match-beginning 0))
 (cite-end  (match-end 0))
 (cite-lines (count-lines cite-start cite-end)))
+   (overlay-put (make-overlay cite-start cite-end) 'face 
'message-cited-text-face)
(when (> cite-lines (1+ notmuch-show-citation-lines-prefix))
  (goto-char cite-start)
  (forward-line notmuch-show-citation-lines-prefix)
@@ -718,6 +719,7 @@ is what to put on the button."
(let* ((sig-start (match-beginning 0))
   (sig-end (match-end 0))
   (sig-lines (1- (count-lines sig-start end
+ (overlay-put (make-overlay sig-start end) 'face 
'message-cited-text-face)
  (if (<= sig-lines notmuch-show-signature-lines-max)
  (notmuch-show-region-to-button
   sig-start
-- 
1.6.6.1

Re: [notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.

[David Edmondson]

This version is over-eager in marking (non-)signatures. The second call
to 'overlay-put' needs to move inside the 'if' a line below.

On Mon, 15 Feb 2010 09:41:49 +, David Edmondson  wrote:
> ---
>  notmuch.el |2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/notmuch.el b/notmuch.el
> index 8090b2f..3e8e50d 100644
> --- a/notmuch.el
> +++ b/notmuch.el
> @@ -703,6 +703,7 @@ is what to put on the button."
>(let* ((cite-start (match-beginning 0))
>(cite-end  (match-end 0))
>(cite-lines (count-lines cite-start cite-end)))
> + (overlay-put (make-overlay cite-start cite-end) 'face 
> 'message-cited-text-face)
>   (when (> cite-lines (1+ notmuch-show-citation-lines-prefix))
> (goto-char cite-start)
> (forward-line notmuch-show-citation-lines-prefix)
> @@ -718,6 +719,7 @@ is what to put on the button."
>   (let* ((sig-start (match-beginning 0))
>  (sig-end (match-end 0))
>  (sig-lines (1- (count-lines sig-start end
> +   (overlay-put (make-overlay sig-start end) 'face 
> 'message-cited-text-face)
> (if (<= sig-lines notmuch-show-signature-lines-max)
> (notmuch-show-region-to-button
>  sig-start
> -- 
> 1.6.6.1
> 

dme.
-- 
David Edmondson, http://dme.org
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face.

[David Edmondson]

---
 notmuch.el |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/notmuch.el b/notmuch.el
index 8090b2f..3e8e50d 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -703,6 +703,7 @@ is what to put on the button."
   (let* ((cite-start (match-beginning 0))
 (cite-end  (match-end 0))
 (cite-lines (count-lines cite-start cite-end)))
+   (overlay-put (make-overlay cite-start cite-end) 'face 
'message-cited-text-face)
(when (> cite-lines (1+ notmuch-show-citation-lines-prefix))
  (goto-char cite-start)
  (forward-line notmuch-show-citation-lines-prefix)
@@ -718,6 +719,7 @@ is what to put on the button."
(let* ((sig-start (match-beginning 0))
   (sig-end (match-end 0))
   (sig-lines (1- (count-lines sig-start end
+ (overlay-put (make-overlay sig-start end) 'face 
'message-cited-text-face)
  (if (<= sig-lines notmuch-show-signature-lines-max)
  (notmuch-show-region-to-button
   sig-start
-- 
1.6.6.1

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch