Re: [notmuch] notmuch.el and searching within citations

[Carl Worth]

On Sat, 9 Jan 2010 06:18:10 +1100, "Bart Bunting"  wrote:
> Hi all,

Hi Bart, welcome to notmuch!

> If however the word 'grandfather' appears in a citation then an incremental
> search through the buffer won't find it.
> 
> If the citation is expanded then things work as expected.
> 
> I don't think this is very logical behavior as it stands, having to expand
> each citation to be able to search in it appears to sort of defeat the
> search.

I agree 100%.

There's good support in emacs for doing what we want here. There are
variables to control what happens when a search terminates (or
temporarily matches) invisible text. And one of the possible behaviors
is for the invisible region to be made visible (and that perhaps
temporarily if the search doesn't terminate in the invisible region).

So we just need to play with things a bit to turn that behavior on.

I've made a note in the TODO file so that I won't (permanently) forget
about this feature request. Of course, I'd be quite glad if anyone had
the time and inclination to investigate.

-Carl


pgpkY1E5mIJub.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[notmuch] notmuch.el and searching within citations

[Carl Worth]

On Sat, 9 Jan 2010 06:18:10 +1100, "Bart Bunting"  wrote:
> Hi all,

Hi Bart, welcome to notmuch!

> If however the word 'grandfather' appears in a citation then an incremental
> search through the buffer won't find it.
> 
> If the citation is expanded then things work as expected.
> 
> I don't think this is very logical behavior as it stands, having to expand
> each citation to be able to search in it appears to sort of defeat the
> search.

I agree 100%.

There's good support in emacs for doing what we want here. There are
variables to control what happens when a search terminates (or
temporarily matches) invisible text. And one of the possible behaviors
is for the invisible region to be made visible (and that perhaps
temporarily if the search doesn't terminate in the invisible region).

So we just need to play with things a bit to turn that behavior on.

I've made a note in the TODO file so that I won't (permanently) forget
about this feature request. Of course, I'd be quite glad if anyone had
the time and inclination to investigate.

-Carl
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 

[notmuch] notmuch.el and searching within citations

[Bart Bunting]

Hi all,



I am having a little bit of trouble with notmuch.el, I'm not sure if I'm
just not understanding how it works or if there is an actual issue.



The problem is that if I search for a word, lets say grandfather using 's'
from the notmuch buffer a list of messages is returned correctly that
contain the word.

Next I hit enter on the thread I want to read.

Then I use 'c-s' to search forward through the buffer for the word
'grandfather'.  

Provided that the word is in a non citation part of the buffer all works as
expected.

If however the word 'grandfather' appears in a citation then an incremental
search through the buffer won't find it.

If the citation is expanded then things work as expected.



I don't think this is very logical behavior as it stands, having to expand
each citation to be able to search in it appears to sort of defeat the
search.



Ideally I would like to be able to search forward and if the word was in a
citation to have it automagicaly expand for me.  

Alternatively Just having point land on the citation would be enough to let
me know there was something inside I may want to read.



What do others think?



Regards



Bart



-- next part --
An HTML attachment was scrubbed...
URL: 

[notmuch] notmuch.el and searching within citations

[Bart Bunting]

Hi all,

 

I am having a little bit of trouble with notmuch.el, I'm not sure if I'm
just not understanding how it works or if there is an actual issue.

 

The problem is that if I search for a word, lets say grandfather using 's'
from the notmuch buffer a list of messages is returned correctly that
contain the word.

Next I hit enter on the thread I want to read.

Then I use 'c-s' to search forward through the buffer for the word
'grandfather'.  

Provided that the word is in a non citation part of the buffer all works as
expected.

If however the word 'grandfather' appears in a citation then an incremental
search through the buffer won't find it.

If the citation is expanded then things work as expected.

 

I don't think this is very logical behavior as it stands, having to expand
each citation to be able to search in it appears to sort of defeat the
search.

 

Ideally I would like to be able to search forward and if the word was in a
citation to have it automagicaly expand for me.  

Alternatively Just having point land on the citation would be enough to let
me know there was something inside I may want to read.

 

What do others think?

 

Regards

 

Bart

 

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch