Re: [PATCH v2 0/9] FreeBSD Support Patches

2012-09-05 Thread Mike Kelly
Thanks, I'll try to take care of the concerns with the other 2 patches at some point, but I haven't had as much free time lately as I'd like to have. On Sat, Sep 1, 2012 at 10:41 PM, David Bremner da...@tethera.net wrote: Mike Kelly pi...@pioto.org writes: Hi, Here's a second attempt at

[PATCH v2 0/9] FreeBSD Support Patches

2012-09-04 Thread Mike Kelly
Thanks, I'll try to take care of the concerns with the other 2 patches at some point, but I haven't had as much free time lately as I'd like to have. On Sat, Sep 1, 2012 at 10:41 PM, David Bremner wrote: > Mike Kelly writes: > >> Hi, >> >> Here's a second attempt at adding FreeBSD support.

[PATCH v2 0/9] FreeBSD Support Patches

2012-09-02 Thread David Bremner
Mike Kelly writes: > Hi, > > Here's a second attempt at adding FreeBSD support. Hopefully most of the > concerns raised about the initial patch set have been addressed. I pushed (finally) patches 1,2,4,5,6 and 8. The others either no longer apply, or there were some outstanding issues in the

[PATCH v2 0/9] FreeBSD Support Patches

2012-05-30 Thread Tomi Ollila
On Wed, May 30 2012, Mike Kelly wrote: > Hi, > > Here's a second attempt at adding FreeBSD support. Hopefully most of the > concerns raised about the initial patch set have been addressed. LGTM and patches apply, compiles fine and related tests pass. Tomi

[PATCH v2 0/9] FreeBSD Support Patches

2012-05-30 Thread Mike Kelly
Hi, Here's a second attempt at adding FreeBSD support. Hopefully most of the concerns raised about the initial patch set have been addressed. I'll send my "I don't have emacs" patches in a separate email.

[PATCH v2 0/9] FreeBSD Support Patches

2012-05-30 Thread Mike Kelly
Hi, Here's a second attempt at adding FreeBSD support. Hopefully most of the concerns raised about the initial patch set have been addressed. I'll send my I don't have emacs patches in a separate email. ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH v2 0/9] FreeBSD Support Patches

2012-05-30 Thread Tomi Ollila
On Wed, May 30 2012, Mike Kelly pi...@pioto.org wrote: Hi, Here's a second attempt at adding FreeBSD support. Hopefully most of the concerns raised about the initial patch set have been addressed. LGTM and patches apply, compiles fine and related tests pass. Tomi

FreeBSD Support Patches

2012-05-26 Thread Dmitry Kurochkin
Mike Kelly writes: > On Fri, May 25, 2012 at 10:15 AM, Dmitry Kurochkin > wrote: >> Why do we need to explicitly declare Emacs dependency for tests? ?There >> should be no need for it. ?We have "implicit" dependencies which are >> declared once (see test_declare_external_prereq calls at the end

FreeBSD Support Patches

2012-05-26 Thread Tomi Ollila
On Fri, May 25 2012, Mike Kelly wrote: > Hi, > > These patches add some changes necessary for a clean build on FreeBSD, > and for most of the tests to pass. > > Also mixed in are a few patches to disable emacs tests when you don't > have emacs, along with tests that depend upon emacs. I could

FreeBSD Support Patches

2012-05-25 Thread Dmitry Kurochkin
Hi Mike. Mike Kelly writes: > Hi, > > These patches add some changes necessary for a clean build on FreeBSD, > and for most of the tests to pass. > > Also mixed in are a few patches to disable emacs tests when you don't > have emacs, along with tests that depend upon emacs. I could split those

FreeBSD Support Patches

2012-05-25 Thread Mike Kelly
On Fri, May 25, 2012 at 10:15 AM, Dmitry Kurochkin wrote: > Why do we need to explicitly declare Emacs dependency for tests? ?There > should be no need for it. ?We have "implicit" dependencies which are > declared once (see test_declare_external_prereq calls at the end of > test-lib.sh) and are

FreeBSD Support Patches

2012-05-25 Thread Mike Kelly
Hi, These patches add some changes necessary for a clean build on FreeBSD, and for most of the tests to pass. Also mixed in are a few patches to disable emacs tests when you don't have emacs, along with tests that depend upon emacs. I could split those off onto a separate branch if required.

FreeBSD Support Patches

2012-05-25 Thread Mike Kelly
Hi, These patches add some changes necessary for a clean build on FreeBSD, and for most of the tests to pass. Also mixed in are a few patches to disable emacs tests when you don't have emacs, along with tests that depend upon emacs. I could split those off onto a separate branch if required.

Re: FreeBSD Support Patches

2012-05-25 Thread Dmitry Kurochkin
Hi Mike. Mike Kelly pi...@pioto.org writes: Hi, These patches add some changes necessary for a clean build on FreeBSD, and for most of the tests to pass. Also mixed in are a few patches to disable emacs tests when you don't have emacs, along with tests that depend upon emacs. I could

Re: FreeBSD Support Patches

2012-05-25 Thread Mike Kelly
On Fri, May 25, 2012 at 10:15 AM, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Why do we need to explicitly declare Emacs dependency for tests?  There should be no need for it.  We have implicit dependencies which are declared once (see test_declare_external_prereq calls at the end of

Re: FreeBSD Support Patches

2012-05-25 Thread Tomi Ollila
On Fri, May 25 2012, Mike Kelly pi...@pioto.org wrote: Hi, These patches add some changes necessary for a clean build on FreeBSD, and for most of the tests to pass. Also mixed in are a few patches to disable emacs tests when you don't have emacs, along with tests that depend upon emacs. I

Re: FreeBSD Support Patches

2012-05-25 Thread Dmitry Kurochkin
Mike Kelly pi...@pioto.org writes: On Fri, May 25, 2012 at 10:15 AM, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Why do we need to explicitly declare Emacs dependency for tests?  There should be no need for it.  We have implicit dependencies which are declared once (see