Re: Indentation style

2019-07-31 Thread Tomi Ollila
On Tue, Jul 30 2019, Ralph Seichter wrote: > * Tomi Ollila: > >> I like mixed tabs and spaces. for example cursor moves faster... > > If that's the case, you're just not using the right keys to move around > the source code. :-) In Vim, keys like W/B, +/- etc. ignore whitespaces > anyway, and Emac

Re: Indentation style

2019-07-30 Thread Ralph Seichter
* Tomi Ollila: > I like mixed tabs and spaces. for example cursor moves faster... If that's the case, you're just not using the right keys to move around the source code. :-) In Vim, keys like W/B, +/- etc. ignore whitespaces anyway, and Emacs has equivalents. Rumour has it there are other editor

Re: Indentation style

2019-07-30 Thread Daniel Kahn Gillmor
On Tue 2019-07-30 00:23:16 +0300, Tomi Ollila wrote: > On Sun, Jul 28 2019, Daniel Kahn Gillmor wrote: >> (fwiw, i would also be happy if we moved away from literal tabs and just >> used spaces-only. But i am not interested in setting off a flamewar, >> so if anyone prefers the mixed-tabs-and-spac

Re: Indentation style

2019-07-29 Thread Tomi Ollila
On Sun, Jul 28 2019, Daniel Kahn Gillmor wrote: > > (fwiw, i would also be happy if we moved away from literal tabs and just > used spaces-only. But i am not interested in setting off a flamewar, > so if anyone prefers the mixed-tabs-and-spaces situation we are in > today, i will never mention th

Re: Indentation style

2019-07-29 Thread David Bremner
Daniel Kahn Gillmor writes: > > (fwiw, i would also be happy if we moved away from literal tabs and just > used spaces-only. But i am not interested in setting off a flamewar, > so if anyone prefers the mixed-tabs-and-spaces situation we are in > today, i will never mention this again) > I most

Re: Indentation style

2019-07-29 Thread Daniel Kahn Gillmor
On Mon 2019-07-29 00:19:48 +0200, Thomas Schneider wrote: > Maybe I misunderstood, but this doesn’t really look like Emacs’ defaults > for C. I think the question is less "emacs defaults" vs. "consistency with the current codebase". > While we’re at it, how about a generic .editorconfig? The wor

Re: Indentation style

2019-07-28 Thread David Bremner
Thomas Schneider writes: > David Bremner writes: > >> We're using more or less the default for Emacs (you can see the details >> in .dir-locals.el). > > Maybe I misunderstood, but this doesn’t really look like Emacs’ defaults > for C. Right, I should have been more precise, using tabs at the be

Re: Indentation style

2019-07-28 Thread Thomas Schneider
David Bremner writes: > We're using more or less the default for Emacs (you can see the details > in .dir-locals.el). Maybe I misunderstood, but this doesn’t really look like Emacs’ defaults for C. > I'm a bit dubious that we want to re-whitespace everything, but I'd > certainly be receptive to

Re: Indentation style (was: [PATCH] notmuch-dump.c: Fix output file being closed twice)

2019-07-28 Thread David Bremner
Ralph Seichter writes: > * David Bremner: > >> I did have to revert one unrelated whitespace change. > > I knew I might run afoul of that the minute I read "Indent is 4 spaces > with mixed tab/spaces and a tab width of 8" in the code style notes. ;-) > > In my experience, it is error-prone to mix

Indentation style (was: [PATCH] notmuch-dump.c: Fix output file being closed twice)

2019-07-28 Thread Ralph Seichter
* David Bremner: > I did have to revert one unrelated whitespace change. I knew I might run afoul of that the minute I read "Indent is 4 spaces with mixed tab/spaces and a tab width of 8" in the code style notes. ;-) In my experience, it is error-prone to mix tabs and spaces. Perhaps it would be