Re: Indentation style (was: [PATCH] notmuch-dump.c: Fix output file being closed twice)

2019-07-28 Thread David Bremner
Ralph Seichter  writes:

> * David Bremner:
>
>> I did have to revert one unrelated whitespace change.
>
> I knew I might run afoul of that the minute I read "Indent is 4 spaces
> with mixed tab/spaces and a tab width of 8" in the code style notes. ;-)
>
> In my experience, it is error-prone to mix tabs and spaces. Perhaps it
> would be useful to change to all spaces? Also, with an added editor mode
> line, supporting that style would be more convenient (for Emacs and Vim
> at least).

We're using more or less the default for Emacs (you can see the details
in .dir-locals.el).  I'm a bit dubious that we want to re-whitespace
everything, but I'd certainly be receptive to matching configuration for
other editors. Does anyone know if vim indentation can be configured per
project / directory?

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Indentation style (was: [PATCH] notmuch-dump.c: Fix output file being closed twice)

2019-07-28 Thread Ralph Seichter
* David Bremner:

> I did have to revert one unrelated whitespace change.

I knew I might run afoul of that the minute I read "Indent is 4 spaces
with mixed tab/spaces and a tab width of 8" in the code style notes. ;-)

In my experience, it is error-prone to mix tabs and spaces. Perhaps it
would be useful to change to all spaces? Also, with an added editor mode
line, supporting that style would be more convenient (for Emacs and Vim
at least).

-Ralph
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch