Maildir-flags synchronization now on master branch

2010-11-18 Thread Ruben Pollan
On 05:04, Thu 11 Nov 10, Carl Worth wrote:
> Thanks to work by Michal, and a few followups by me, I'm now happy to
> report that the patches for synchronizing tags with maildir flags are
> now pushed out to the master branch.

Nice to see that, I was waiting for this feature since a while.

I only find a problem with it. The 'unread' tag is not working as I expected.
notmuch only tags as 'unread' my email at 'cur' folder. fetchmail download the
email to the 'new' folder. As I understand that is a correct behaviour[0].


[0] http://cr.yp.to/proto/maildir.html

-- 
Rub?n Poll?n  | jabber:meskio at jabber.org
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
   Hay un mundo
  a la vuelta de la esquina de tu mente,
 donde la realidad es un intruso
  y los sue?os se hacen realidad.

-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: 



Re: Maildir-flags synchronization now on master branch

2010-11-18 Thread Ruben Pollan
On 05:04, Thu 11 Nov 10, Carl Worth wrote:
 Thanks to work by Michal, and a few followups by me, I'm now happy to
 report that the patches for synchronizing tags with maildir flags are
 now pushed out to the master branch.

Nice to see that, I was waiting for this feature since a while.

I only find a problem with it. The 'unread' tag is not working as I expected.
notmuch only tags as 'unread' my email at 'cur' folder. fetchmail download the
email to the 'new' folder. As I understand that is a correct behaviour[0].


[0] http://cr.yp.to/proto/maildir.html

-- 
Rubén Pollán  | jabber:mes...@jabber.org
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
   Hay un mundo
  a la vuelta de la esquina de tu mente,
 donde la realidad es un intruso
  y los sueños se hacen realidad.



signature.asc
Description: Digital signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


Maildir-flags synchronization now on master branch

2010-11-11 Thread Dirk Hohndel
On Thu, 11 Nov 2010 16:43:45 -0800, Carl Worth  wrote:
> 
> Now that all of this maildir-flag synchronization is possible, I wonder
> if we shouldn't allow the user to configure the mapping of maildir-flag
> characters to tag names. That would allow for (a limited number of) tags
> to be synchronized on multiple machines using synchronization mechanisms
> such as offlineimap without needing any notmuch-aware synchronization.
> 
> So that might be very interesting.

Oh I LOVE that idea. There are only a small number of tags that I
/really/ need and to be able to access them from multiplme machines,
kept in sync through the imap server... awesome.

/D


Maildir-flags synchronization now on master branch

2010-11-11 Thread Carl Worth
On Thu, 11 Nov 2010 05:04:48 -0800, Carl Worth  wrote:
> There were two things I had wanted to do before pushing this out, but
> I've decided to get some sleep now instead:
> 
>   1. Don't do maildir-flag things in non-maildir directories
> 
>   2. Preserve any unsupported flags when renaming

After some good sleep, both of these features seemed much easier to
implement. These are both pushed now.

And I've now done a much more thorough audit of all of the
implementation, (adapting things to my preferred coding style, adding
comments, fixing up little corner cases, etc.). So I'm quite comfortable
with all of this now. I think 0.5 will be imminent.

Now that all of this maildir-flag synchronization is possible, I wonder
if we shouldn't allow the user to configure the mapping of maildir-flag
characters to tag names. That would allow for (a limited number of) tags
to be synchronized on multiple machines using synchronization mechanisms
such as offlineimap without needing any notmuch-aware synchronization.

So that might be very interesting.

-Carl

-- 
carl.d.worth at intel.com
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 



Maildir-flags synchronization now on master branch

2010-11-11 Thread Carl Worth
On Thu, 11 Nov 2010 15:11:23 +0100, Kristoffer Str?m  wrote:
> >   1. Don't do maildir-flag things in non-maildir directories
...
> I'm just pinging that the small feedreader sluk i'm writing/maintaining 
> relies on filenames not changing. 
> So if anyone's using it be careful, and #1 would be a tad more important then.

Hi Kristoffer,

I really like the idea of sluk, and I don't want to make it painful to
use. So that's for pointing out this problem.

I've now pushed a change that will avoid doing any renaming except in
directories named either "new" or "cur".

That's not the strongest heuristic for detecting maildir, (we could
actually look and see if all three of "cur", "new", and "tmp"
directories exist, for example). But it's at least a very cheap
heuristic. So hopefully this will help for your use case.

And obviously, one can still configure the maildir synchronization off
(globally) if desired.

-Carl

-- 
carl.d.worth at intel.com
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 



Maildir-flags synchronization now on master branch

2010-11-11 Thread Carl Worth
Thanks to work by Michal, and a few followups by me, I'm now happy to
report that the patches for synchronizing tags with maildir flags are
now pushed out to the master branch.

I've done a fair bit of testing with this stuff, and I think it's ready
to be used. In fact, I've now got the synchronization turned on by
default.

Please, anyone that cares to test it, let me know how it goes.

There were two things I had wanted to do before pushing this out, but
I've decided to get some sleep now instead:

  1. Don't do maildir-flag things in non-maildir directories

  2. Preserve any unsupported flags when renaming

Of these, number 1 is likely less important. If someone is very
concerned about avoiding the maildir-style renaming then they can simply
configure maildir.synchronize_flags to false.

But this second feature is essential, I think. People may have valuable
information encoded in their mail store as maildir flags, and it's not
right of notmuch to destroy that, (particularly as notmuch has
previously treated the mailstore in an entirely read-only fashion).

So, be warned! If you do have precious information encoded as maildir
flags, (other than D,F,P,R, or S), then you'll want to avoid using the
latest notmuch or be sure to do:

notmuch config set maildir.synchronize_flags false

Meanwhile, as soon as we fix this one misfeature, I think I'd like to
push out what we've got now as notmuch 0.5, (perhaps with a few of the
very recent, tiny changes that have been proposed).

Thanks for the help, everyone!

-Carl

-- 
carl.d.worth at intel.com
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 



Maildir-flags synchronization now on master branch

2010-11-11 Thread Carl Worth
Thanks to work by Michal, and a few followups by me, I'm now happy to
report that the patches for synchronizing tags with maildir flags are
now pushed out to the master branch.

I've done a fair bit of testing with this stuff, and I think it's ready
to be used. In fact, I've now got the synchronization turned on by
default.

Please, anyone that cares to test it, let me know how it goes.

There were two things I had wanted to do before pushing this out, but
I've decided to get some sleep now instead:

  1. Don't do maildir-flag things in non-maildir directories

  2. Preserve any unsupported flags when renaming

Of these, number 1 is likely less important. If someone is very
concerned about avoiding the maildir-style renaming then they can simply
configure maildir.synchronize_flags to false.

But this second feature is essential, I think. People may have valuable
information encoded in their mail store as maildir flags, and it's not
right of notmuch to destroy that, (particularly as notmuch has
previously treated the mailstore in an entirely read-only fashion).

So, be warned! If you do have precious information encoded as maildir
flags, (other than D,F,P,R, or S), then you'll want to avoid using the
latest notmuch or be sure to do:

notmuch config set maildir.synchronize_flags false

Meanwhile, as soon as we fix this one misfeature, I think I'd like to
push out what we've got now as notmuch 0.5, (perhaps with a few of the
very recent, tiny changes that have been proposed).

Thanks for the help, everyone!

-Carl

-- 
carl.d.wo...@intel.com


pgpqhIemobyue.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


Re: Maildir-flags synchronization now on master branch

2010-11-11 Thread Kristoffer Ström
 
   1. Don't do maildir-flag things in non-maildir directories
 
   2. Preserve any unsupported flags when renaming
 
 Of these, number 1 is likely less important. If someone is very
 concerned about avoiding the maildir-style renaming then they can simply
 configure maildir.synchronize_flags to false.

I'm just pinging that the small feedreader sluk i'm writing/maintaining relies 
on filenames not changing. 
So if anyone's using it be careful, and #1 would be a tad more important then.

Kristoffer
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


Re: Maildir-flags synchronization now on master branch

2010-11-11 Thread Carl Worth
On Thu, 11 Nov 2010 15:11:23 +0100, Kristoffer Ström kristof...@rymdkoloni.se 
wrote:
1. Don't do maildir-flag things in non-maildir directories
...
 I'm just pinging that the small feedreader sluk i'm writing/maintaining 
 relies on filenames not changing. 
 So if anyone's using it be careful, and #1 would be a tad more important then.

Hi Kristoffer,

I really like the idea of sluk, and I don't want to make it painful to
use. So that's for pointing out this problem.

I've now pushed a change that will avoid doing any renaming except in
directories named either new or cur.

That's not the strongest heuristic for detecting maildir, (we could
actually look and see if all three of cur, new, and tmp
directories exist, for example). But it's at least a very cheap
heuristic. So hopefully this will help for your use case.

And obviously, one can still configure the maildir synchronization off
(globally) if desired.

-Carl

-- 
carl.d.wo...@intel.com


pgpyKsZprEK2w.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


Re: Maildir-flags synchronization now on master branch

2010-11-11 Thread Carl Worth
On Thu, 11 Nov 2010 05:04:48 -0800, Carl Worth cwo...@cworth.org wrote:
 There were two things I had wanted to do before pushing this out, but
 I've decided to get some sleep now instead:
 
   1. Don't do maildir-flag things in non-maildir directories
 
   2. Preserve any unsupported flags when renaming

After some good sleep, both of these features seemed much easier to
implement. These are both pushed now.

And I've now done a much more thorough audit of all of the
implementation, (adapting things to my preferred coding style, adding
comments, fixing up little corner cases, etc.). So I'm quite comfortable
with all of this now. I think 0.5 will be imminent.

Now that all of this maildir-flag synchronization is possible, I wonder
if we shouldn't allow the user to configure the mapping of maildir-flag
characters to tag names. That would allow for (a limited number of) tags
to be synchronized on multiple machines using synchronization mechanisms
such as offlineimap without needing any notmuch-aware synchronization.

So that might be very interesting.

-Carl

-- 
carl.d.wo...@intel.com


pgphLl9Q0KoRv.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch