Re: Final call for news for 0.18
David Bremner da...@tethera.net writes: We've had a quiet freeze for a week or so, so I think we're probably ready to release. Per Jani's suggestion, I made a tl;dr summary for the NEWS. Barring last minute bugs, I'd like to release this weekend, so please send me any NEWS comments ASAP. d I have pushed the vim changes, so we'll have a short freeze extension for 48h. We will release on May 6, unless a bug that causes data loss is revealed in the interim. d pgpQTETzgHgb_.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
RE: Final call for news for 0.18
On Fri, May 02 2014, Felipe Contreras felipe.contre...@gmail.com wrote: Tomi Ollila wrote: PS: does vim frontend lack id:message-id feature -- What feature? In Emacs MUA, when one presses ENTER (or clicks mouse) on top of text containing id:message-id the client opens that particular message. -- Felipe Contreras Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
RE: Final call for news for 0.18
On Thu, May 01 2014, Felipe Contreras felipe.contre...@gmail.com wrote: David Bremner wrote: We've had a quiet freeze for a week or so, so I think we're probably ready to release. Per Jani's suggestion, I made a tl;dr summary for the NEWS. Barring last minute bugs, I'd like to release this weekend, so please send me any NEWS comments ASAP. What about the vim changes? http://mid.gmane.org/1398289784-18203-1-git-send-email-felipe.contre...@gmail.com I was going to review these after 0.18 release as the freeze was announced to be Apri 21th(*) and these patches in question was sent April 24th, without any request to consider these for 0.18... (*) This freeze was announced April 14th (see id:8761mcxjhc.fsf@zancas.localnet or http://mid.gmane.org/8761mcxjhc.fsf@zancas.localnet ) In general these patches: id:1398289784-18203-2-git-send-email-felipe.contre...@gmail.com id:1398289784-18203-3-git-send-email-felipe.contre...@gmail.com id:1398289784-18203-4-git-send-email-felipe.contre...@gmail.com has something lacking in the commit messages; none of these indicate that these are vim patches in the subject line. For 1/3 I'd have liked to see some potentially understandable explanation why the change was done instead of Seems it never really worked. -- the change looks a bit strange (probably due to only the context seen). Commit message for 2/3 might be tolerable if it were prefixed with vim: -- and the same applies to 3/3 (in 3/3 I don't understand the change and I don't use vim so I don't know how to test so It would be nice to get someone else (or two) to report their experience with these patches applied in their notmuch-vim environment) Also NEWS for these changes are missing. I personally don't see these patches being important enough to hinder 0.18 release timeline -- these patches should just have come earlier... ... but if you had a good case, fix these things (quickly!) and had strong backing from some other notmuch-vim users I could see a small chance of these being part of the next release... Tomi PS: does vim frontend lack id:message-id feature -- the above http link to gmane was just useless to me, which meant I had to use extra steps to reach the emails (which sometimes if not often leads me just to drop the issue there...). If it is lacking and SomeOne(™) proposes id:msgid handling to notmuch-wim I promise to review that right away :D -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
RE: Final call for news for 0.18
Tomi Ollila wrote: In general these patches: id:1398289784-18203-2-git-send-email-felipe.contre...@gmail.com id:1398289784-18203-3-git-send-email-felipe.contre...@gmail.com id:1398289784-18203-4-git-send-email-felipe.contre...@gmail.com has something lacking in the commit messages; none of these indicate that these are vim patches in the subject line. Agh, I ported them from my standalone repo and forgot to do that. Also NEWS for these changes are missing. Shouldn't the NEWS be written by the maintainers? In fact, aren't they the ones that decide if something is worth mentioning in the NEWS or not? I personally don't see these patches being important enough to hinder 0.18 release timeline -- Well, if your mails had ever been rejected from vger.kernel.org because of the format you might see that. these patches should just have come earlier... Yes. ... but if you had a good case, fix these things (quickly!) and had strong backing from some other notmuch-vim users I could see a small chance of these being part of the next release... All right. PS: does vim frontend lack id:message-id feature -- What feature? -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
RE: Final call for news for 0.18
Felipe Contreras felipe.contre...@gmail.com writes: Also NEWS for these changes are missing. Shouldn't the NEWS be written by the maintainers? In fact, aren't they the ones that decide if something is worth mentioning in the NEWS or not? Hi Felipe; I guess for the Vim/ruby stuff you're best positioned to judge what is important. We run a kind of pyramid scheme: people generally submit short summaries of their own user visible changes; this is the first release that I've written a short summary of that. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
RE: Final call for news for 0.18
David Bremner wrote: We've had a quiet freeze for a week or so, so I think we're probably ready to release. Per Jani's suggestion, I made a tl;dr summary for the NEWS. Barring last minute bugs, I'd like to release this weekend, so please send me any NEWS comments ASAP. What about the vim changes? http://mid.gmane.org/1398289784-18203-1-git-send-email-felipe.contre...@gmail.com -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
