Re: Thread safety?

2023-02-22 Thread David Bremner
Kevin Boulain writes: > The documentation of MatchNothing says it's thread-safe. > > If you'd like, I'm happy to submit a patch (likely very small, given the > limited number of occurrences) after I review a bit more the > documentation and the code (I'm just starting with Notmuch and Xapian so

Re: Thread safety?

2023-02-21 Thread Kevin Boulain
y on GLib which emitted false positives under -fsanitize so I resorted to debugging that one manually (but maybe I missed something obvious). I only discovered the issue because the test framework I'm using runs the tests in different threads. > It seems reasonable to try to provide the same lev

Re: Thread safety?

2023-02-21 Thread David Bremner
ide the same level of thread safety as Xapian does. So I guess we should go ahead and replace all of the MatchAll objects. I'm guessing this might apply to Xapian::Query::MatchNothing as well. Probably preprocessor macros wrapping Xapian::Query(std::string()) and whatever the equivalent for MatchNot

Thread safety?

2023-02-21 Thread Kevin Boulain
Hey, I quickly searched the mailing list archives but couldn't find a related topic, apologies if this has already been discussed. Should Notmuch be thread-safe? Here's a simple repro (notmuch 09f2ad8e, xapian-core 1.4.22): // cc -Wall -g -lpthread -lnotmuch #include #include #include void