Re: add status value to _notmuch_message_ensure_metadata

2017-02-23 Thread David Bremner
Gaute Hope writes: > Ideally if the error could be caught in `notmuch_threads_valid` or > `notmuch_threads_get_thread` I think that would be the clearest, _st > versions would be nice. We can't really control when the exceptions happen, due to lazily reading data from

Re: add status value to _notmuch_message_ensure_metadata

2017-02-22 Thread Gaute Hope
David Bremner writes on februar 23, 2017 1:58: Gaute Hope writes: Gaute Hope writes on februar 20, 2017 10:27: David Bremner writes on februar 18, 2017 15:45: In id:1487339566.mz8acpov1j.astr...@strange.none , Gaute provided a traceback of an uncaught

Re: add status value to _notmuch_message_ensure_metadata

2017-02-22 Thread David Bremner
Gaute Hope writes: > Gaute Hope writes on februar 20, 2017 10:27: >> David Bremner writes on februar 18, 2017 15:45: >>> In id:1487339566.mz8acpov1j.astr...@strange.none , Gaute provided a >>> traceback of an uncaught Xapian::DatabaseModifiedError. The fix for >>> this is

Re: add status value to _notmuch_message_ensure_metadata

2017-02-20 Thread Gaute Hope
Gaute Hope writes on februar 20, 2017 10:27: David Bremner writes on februar 18, 2017 15:45: In id:1487339566.mz8acpov1j.astr...@strange.none , Gaute provided a traceback of an uncaught Xapian::DatabaseModifiedError. The fix for this is simple, but somewhat intrusive. [...] I haven't tested

Re: add status value to _notmuch_message_ensure_metadata

2017-02-20 Thread Gaute Hope
David Bremner writes on februar 18, 2017 15:45: In id:1487339566.mz8acpov1j.astr...@strange.none , Gaute provided a traceback of an uncaught Xapian::DatabaseModifiedError. The fix for this is simple, but somewhat intrusive. [...] I haven't tested against Gaute's test case (needs more boost

add status value to _notmuch_message_ensure_metadata

2017-02-18 Thread David Bremner
In id:1487339566.mz8acpov1j.astr...@strange.none , Gaute provided a traceback of an uncaught Xapian::DatabaseModifiedError. The fix for this is simple, but somewhat intrusive. This patch series catches any Xapian exceptions in _notmuch_message_ensure_metadata and converts them into status returns