Re: difficulties with notmuch2 python bindings for alot
On Sun 14 Jun 2020 at 19:44 -0300, David Bremner wrote: > Floris Bruynooghe writes: > >> One thing that they encountered and don't yet understand is that they >> reported issues with leaking filedescriptors. They used the bindings in >> a way where I expect it to only call notmuch_database_destroy() when >> they are done with it. From reading notmuch.h I think that's correct >> and there's no need to call notmuch_database_close() first. Yet someone >> reported that explicitly calling close helped. Is the assumption I made >> of only calling destroy correct? > > The first thing destroy does is call close. My read of the > notmuch_database_close code is that it is idempotent (calling multiple > times does not change anything). Thanks for confirming, so that should be fine. Cheers, Floris ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: difficulties with notmuch2 python bindings for alot
Floris Bruynooghe writes: > One thing that they encountered and don't yet understand is that they > reported issues with leaking filedescriptors. They used the bindings in > a way where I expect it to only call notmuch_database_destroy() when > they are done with it. From reading notmuch.h I think that's correct > and there's no need to call notmuch_database_close() first. Yet someone > reported that explicitly calling close helped. Is the assumption I made > of only calling destroy correct? The first thing destroy does is call close. My read of the notmuch_database_close code is that it is idempotent (calling multiple times does not change anything). d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: difficulties with notmuch2 python bindings for alot
Hi Daniel, On Tue 09 Jun 2020 at 09:19 -0400, Daniel Kahn Gillmor wrote: > I see over on github that alot is trying to port to the notmuch2 > bindings, and having a few problems with it: > > https://github.com/pazz/alot/pull/1511 > > alot is an important consumer of the notmuch python bindings, and it > would be really great to see them successfully transition to the > notmuch2 module. > > Floris, if you (or anyone else with this particular knowledge) has a > chance to take a look and help them sort out the remaining issues, that > would be much appreciated! Thanks for the pointer, I've pinged the issue offering help with the bindings and had a look through the existing things they discussed. One thing that they encountered and don't yet understand is that they reported issues with leaking filedescriptors. They used the bindings in a way where I expect it to only call notmuch_database_destroy() when they are done with it. From reading notmuch.h I think that's correct and there's no need to call notmuch_database_close() first. Yet someone reported that explicitly calling close helped. Is the assumption I made of only calling destroy correct? Cheers, Floris ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
difficulties with notmuch2 python bindings for alot
Hi all-- I see over on github that alot is trying to port to the notmuch2 bindings, and having a few problems with it: https://github.com/pazz/alot/pull/1511 alot is an important consumer of the notmuch python bindings, and it would be really great to see them successfully transition to the notmuch2 module. Floris, if you (or anyone else with this particular knowledge) has a chance to take a look and help them sort out the remaining issues, that would be much appreciated! --dkg signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
