Re: on deleting messages

[Antoine Beaupré]

Hi Jamie!

I have taken the time to test those patches and those in the other
thread[1], and I like it! I was able to run all tests with the patches
applied and I am now running them alongside with most recent master
gd51b784 and Mark Walter's attachment buttons patch[2].

So I support those patches and hope they get in. The only issue I could
find was that I have the reflex of hitting A (capital a) instead of just
"a" in the search view because that's the key i hit in the show
view... but that's probably something i should get used to.

If something pops up I'll let you know!

A.

[1] id:"1325975294-646-2-git-send-email-jroll...@finestructure.net"
[2] id:"1326843886-18387-1-git-send-email-markwalters1...@gmail.com"

-- 
Antoine Beaupré +++ Réseau Koumbit Networks +++ +1.514.387.6262 #208



pgpLwgTl99CfX.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

on deleting messages

[Tomi Ollila]

On Tue, 17 Jan 2012 22:21:18 +0200, Jani Nikula  wrote:
> Looking at the source and history, I have to admit there has been
> intent, and code, to have support for "deleted" tag. See for example
> TODO or [1].
> 
> And I agree there has been demand for this.
> 
> I say let's have this.

+1

> But make it clear that "deleted" is just a tag; that the messages aren't
> going away, not by notmuch anyway.

Indeed; notmuch does not touch the content of files nor touch the existence
of files.

Emacs tips wiki page may contain a section user can shoot 
thems^H^H^H^H^H^H^H^H^H^H^H
configure the actual file deleting functionality for themselves.

> BR,
> Jani.

Tomi

on deleting messages

[David Edmondson]

Add the bindings. Provide documentation that makes it clear that they
just add tags and never delete anything.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 

on deleting messages

[Antoine Beaupré]

Hi Jamie!

I have taken the time to test those patches and those in the other
thread[1], and I like it! I was able to run all tests with the patches
applied and I am now running them alongside with most recent master
gd51b784 and Mark Walter's attachment buttons patch[2].

So I support those patches and hope they get in. The only issue I could
find was that I have the reflex of hitting A (capital a) instead of just
"a" in the search view because that's the key i hit in the show
view... but that's probably something i should get used to.

If something pops up I'll let you know!

A.

[1] id:"1325975294-646-2-git-send-email-jrollins at finestructure.net"
[2] id:"1326843886-18387-1-git-send-email-markwalters1009 at gmail.com"

-- 
Antoine Beaupr? +++ R?seau Koumbit Networks +++ +1.514.387.6262 #208

-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

Re: on deleting messages

[David Edmondson]

Add the bindings. Provide documentation that makes it clear that they
just add tags and never delete anything.


pgp3b1CEVBlBs.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

on deleting messages

[Xavier Maillard]

Hi,

On Tue, 17 Jan 2012 11:01:45 -0800, Jameson Graef Rollins  wrote:

[ ... ]

> Based on the show-mode improvements I recently sent [1], the following
> patch set implements thread and message delete keys.
> 
> This is the last I'm going to comment on this issue.  If we don't want
> to support this, we should put together something on the wiki that
> states we don't want to support it and that users should just bind it
> themselves (with a nice explanation how), so that we can try to reduce
> the number of future patches on the issue.

I think this is something every (new) users are expecting to have: a
simple and sensible way "to list the trashed messages". So I'd go for
it.

/Xavier

Re: on deleting messages

[Tomi Ollila]

On Tue, 17 Jan 2012 22:21:18 +0200, Jani Nikula  wrote:
> Looking at the source and history, I have to admit there has been
> intent, and code, to have support for "deleted" tag. See for example
> TODO or [1].
> 
> And I agree there has been demand for this.
> 
> I say let's have this.

+1

> But make it clear that "deleted" is just a tag; that the messages aren't
> going away, not by notmuch anyway.

Indeed; notmuch does not touch the content of files nor touch the existence
of files.

Emacs tips wiki page may contain a section user can shoot 
thems^H^H^H^H^H^H^H^H^H^H^H
configure the actual file deleting functionality for themselves.

> BR,
> Jani.

Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

on deleting messages

[Jani Nikula]

On Tue, 17 Jan 2012 11:01:45 -0800, Jameson Graef Rollins  wrote:
> Now that Austin's excellent tag exclusion patch set [0] has been pushed,
> the question remains if we want to support any delete-handling key
> bindings in emacs.
> 
> Based on the show-mode improvements I recently sent [1], the following
> patch set implements thread and message delete keys.
> 
> This is the last I'm going to comment on this issue.  If we don't want
> to support this, we should put together something on the wiki that
> states we don't want to support it and that users should just bind it
> themselves (with a nice explanation how), so that we can try to reduce
> the number of future patches on the issue.
> 
> Given the number of patches we've had on this issue, though, it's clear
> that a lot of people expect this functionality, so we may want to
> seriously consider supporting it.  Given Austin's tag exclusion stuff,
> and the fact that "deleted" tags are excluded by default, we now have
> the functionality that Carl originally wanted to see, so it's not so
> unreasonable to support this functionality anymore.

I think it's reasonable to consider having key bindings (or other
special handling) for pretty much *any* tags that are special to
notmuch: inbox, unread, draft, flagged, etc. (An exhaustive list should
be documented somewhere.)

Looking at the source and history, I have to admit there has been
intent, and code, to have support for "deleted" tag. See for example
TODO or [1].

And I agree there has been demand for this.

I say let's have this.

But make it clear that "deleted" is just a tag; that the messages aren't
going away, not by notmuch anyway.


BR,
Jani.

[1] commit 2c262042ac174d7bc96d6035ab9c88bd0abe7f35

Re: on deleting messages

[Xavier Maillard]

Hi,

On Tue, 17 Jan 2012 11:01:45 -0800, Jameson Graef Rollins 
 wrote:

[ ... ]

> Based on the show-mode improvements I recently sent [1], the following
> patch set implements thread and message delete keys.
> 
> This is the last I'm going to comment on this issue.  If we don't want
> to support this, we should put together something on the wiki that
> states we don't want to support it and that users should just bind it
> themselves (with a nice explanation how), so that we can try to reduce
> the number of future patches on the issue.

I think this is something every (new) users are expecting to have: a
simple and sensible way "to list the trashed messages". So I'd go for
it.

/Xavier
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: on deleting messages

[Jani Nikula]

On Tue, 17 Jan 2012 11:01:45 -0800, Jameson Graef Rollins 
 wrote:
> Now that Austin's excellent tag exclusion patch set [0] has been pushed,
> the question remains if we want to support any delete-handling key
> bindings in emacs.
> 
> Based on the show-mode improvements I recently sent [1], the following
> patch set implements thread and message delete keys.
> 
> This is the last I'm going to comment on this issue.  If we don't want
> to support this, we should put together something on the wiki that
> states we don't want to support it and that users should just bind it
> themselves (with a nice explanation how), so that we can try to reduce
> the number of future patches on the issue.
> 
> Given the number of patches we've had on this issue, though, it's clear
> that a lot of people expect this functionality, so we may want to
> seriously consider supporting it.  Given Austin's tag exclusion stuff,
> and the fact that "deleted" tags are excluded by default, we now have
> the functionality that Carl originally wanted to see, so it's not so
> unreasonable to support this functionality anymore.

I think it's reasonable to consider having key bindings (or other
special handling) for pretty much *any* tags that are special to
notmuch: inbox, unread, draft, flagged, etc. (An exhaustive list should
be documented somewhere.)

Looking at the source and history, I have to admit there has been
intent, and code, to have support for "deleted" tag. See for example
TODO or [1].

And I agree there has been demand for this.

I say let's have this.

But make it clear that "deleted" is just a tag; that the messages aren't
going away, not by notmuch anyway.


BR,
Jani.

[1] commit 2c262042ac174d7bc96d6035ab9c88bd0abe7f35
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

on deleting messages

[Jameson Graef Rollins]

Now that Austin's excellent tag exclusion patch set [0] has been pushed,
the question remains if we want to support any delete-handling key
bindings in emacs.

Based on the show-mode improvements I recently sent [1], the following
patch set implements thread and message delete keys.

This is the last I'm going to comment on this issue.  If we don't want
to support this, we should put together something on the wiki that
states we don't want to support it and that users should just bind it
themselves (with a nice explanation how), so that we can try to reduce
the number of future patches on the issue.

Given the number of patches we've had on this issue, though, it's clear
that a lot of people expect this functionality, so we may want to
seriously consider supporting it.  Given Austin's tag exclusion stuff,
and the fact that "deleted" tags are excluded by default, we now have
the functionality that Carl originally wanted to see, so it's not so
unreasonable to support this functionality anymore.

jamie.

[0] id:"1326496024-14403-1-git-send-email-amdra...@mit.edu"
[1] id:"871uqy19yo@servo.finestructure.net"


pgpH0hbFQRP7p.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

on deleting messages

[Jameson Graef Rollins]

Now that Austin's excellent tag exclusion patch set [0] has been pushed,
the question remains if we want to support any delete-handling key
bindings in emacs.

Based on the show-mode improvements I recently sent [1], the following
patch set implements thread and message delete keys.

This is the last I'm going to comment on this issue.  If we don't want
to support this, we should put together something on the wiki that
states we don't want to support it and that users should just bind it
themselves (with a nice explanation how), so that we can try to reduce
the number of future patches on the issue.

Given the number of patches we've had on this issue, though, it's clear
that a lot of people expect this functionality, so we may want to
seriously consider supporting it.  Given Austin's tag exclusion stuff,
and the fact that "deleted" tags are excluded by default, we now have
the functionality that Carl originally wanted to see, so it's not so
unreasonable to support this functionality anymore.

jamie.

[0] id:"1326496024-14403-1-git-send-email-amdragon at mit.edu"
[1] id:"871uqy19yo.fsf at servo.finestructure.net"
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: