Re: python-cffi and ruby test suites fail in out-of-tree builds

2020-05-30 Thread David Bremner
Floris Bruynooghe  writes:
>
> I checked out the python one, and maybe that's not too hard.  The
> following patch made this work for both in tree and out of tree (on top
> of your other patch):
>
> modified   test/T391-python-cffi.sh
> @@ -8,7 +8,7 @@ fi
>  
>  
>  test_begin_subtest "python cffi tests"
> -pytest_dir=$NOTMUCH_SRCDIR/bindings/python-cffi/build/stage
> +pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage
>  printf "[pytest]\nminversion = 3.0\naddopts = -ra\n" > $pytest_dir/pytest.ini
>  test_expect_success "(cd $pytest_dir && ${NOTMUCH_PYTHON} -m pytest 
> --log-file=$TMP_DIRECTORY/test.output)"
>  test_done
>

I smooshed this into id:20200522010359.715688-1-...@fifthhorseman.net
and pushed to master.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: python-cffi and ruby test suites fail in out-of-tree builds

2020-05-26 Thread Daniel Kahn Gillmor
On Sat 2020-05-23 21:52:18 +0200, Floris Bruynooghe wrote:
> modified   test/T391-python-cffi.sh
> @@ -8,7 +8,7 @@ fi
>  
>  
>  test_begin_subtest "python cffi tests"
> -pytest_dir=$NOTMUCH_SRCDIR/bindings/python-cffi/build/stage
> +pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage
>  printf "[pytest]\nminversion = 3.0\naddopts = -ra\n" > $pytest_dir/pytest.ini
>  test_expect_success "(cd $pytest_dir && ${NOTMUCH_PYTHON} -m pytest 
> --log-file=$TMP_DIRECTORY/test.output)"
>  test_done

I've tested this and i can confirm that it works for both out-of-tree
and in-tree builds.  LGTM.

 --dkg


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: python-cffi and ruby test suites fail in out-of-tree builds

2020-05-23 Thread Floris Bruynooghe
Hi,

On Thu 21 May 2020 at 21:29 -0400, Daniel Kahn Gillmor wrote:

> Hey folks--
>
> I just did a bit of testing and cleanup for out-of-tree builds (see the
> minor patches that should have landed on the list in the last hour or
> two).

It probably is indeed the unfortunate case that copying the python
source is currently the easiest.  I had a quick look and it seemed like
one'd have to dig into the cffi setuptools support to make this work and
I'm not sure how successful that would be, but I admit I didn't feel
like trying.

> For me, "make check" in an out-of-tree build works fine now, with the
> exception of T391-python-cffi.sh and T395-ruby.sh.

I checked out the python one, and maybe that's not too hard.  The
following patch made this work for both in tree and out of tree (on top
of your other patch):

modified   test/T391-python-cffi.sh
@@ -8,7 +8,7 @@ fi
 
 
 test_begin_subtest "python cffi tests"
-pytest_dir=$NOTMUCH_SRCDIR/bindings/python-cffi/build/stage
+pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage
 printf "[pytest]\nminversion = 3.0\naddopts = -ra\n" > $pytest_dir/pytest.ini
 test_expect_success "(cd $pytest_dir && ${NOTMUCH_PYTHON} -m pytest 
--log-file=$TMP_DIRECTORY/test.output)"
 test_done



Hope that's helpful.

Cheers,
Floris
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


python-cffi and ruby test suites fail in out-of-tree builds

2020-05-21 Thread Daniel Kahn Gillmor
Hey folks--

I just did a bit of testing and cleanup for out-of-tree builds (see the
minor patches that should have landed on the list in the last hour or
two).

For me, "make check" in an out-of-tree build works fine now, with the
exception of T391-python-cffi.sh and T395-ruby.sh.

I'm afraid i don't know enough about either python or ruby to see the
obvious fix for these builds, but i do note that they're the only builds
which depend on copying their source into the out-of-tree location
(assuming no one proposes an improvement for
id:20200522010359.715688-1-...@fifthhorseman.net).

Just thought i'd flag this as an outstanding problem that hopefully
someone clever feels like digging into.

--dkg


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch