revision tracking patches round 4
Tomi Ollila writes: > > Looked a bit to xapian documentation... it seems in case of compacting > one should do the following: > > 1) see that current database uuid is the one expected (which is stored > somewhere) > 2) compact database > 3) read new uuid and store it to "somewhere" right, I think this is basically right. It falls under the same general lazy objections in id:87si7kx27c.fsf at maritornes.cs.unb.ca; I think compact changing uuid is a short term problem. d
revision tracking patches round 4
On Fri, Aug 14 2015, David Bremner wrote: > This obsoletes > > id:1439112285-6681-1-git-send-email-david at tethera.net > > The main differences since that series are in the command line syntax > for notmuch-count. > > We also now consider passing --uuid to notmuch-compact an error, since > the user might reasonably expect that to do something sensible, but we > don't because of the existing API. Series LGTM. Tests pass. Looked a bit to xapian documentation... it seems in case of compacting one should do the following: 1) see that current database uuid is the one expected (which is stored somewhere) 2) compact database 3) read new uuid and store it to "somewhere" Tomi
Re: revision tracking patches round 4
Tomi Ollila writes: > > Looked a bit to xapian documentation... it seems in case of compacting > one should do the following: > > 1) see that current database uuid is the one expected (which is stored > somewhere) > 2) compact database > 3) read new uuid and store it to "somewhere" right, I think this is basically right. It falls under the same general lazy objections in id:87si7kx27c@maritornes.cs.unb.ca; I think compact changing uuid is a short term problem. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: revision tracking patches round 4
On Fri, Aug 14 2015, David Bremner wrote: > This obsoletes > > id:1439112285-6681-1-git-send-email-da...@tethera.net > > The main differences since that series are in the command line syntax > for notmuch-count. > > We also now consider passing --uuid to notmuch-compact an error, since > the user might reasonably expect that to do something sensible, but we > don't because of the existing API. Series LGTM. Tests pass. Looked a bit to xapian documentation... it seems in case of compacting one should do the following: 1) see that current database uuid is the one expected (which is stored somewhere) 2) compact database 3) read new uuid and store it to "somewhere" Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
revision tracking patches round 4
This obsoletes id:1439112285-6681-1-git-send-email-david at tethera.net The main differences since that series are in the command line syntax for notmuch-count. We also now consider passing --uuid to notmuch-compact an error, since the user might reasonably expect that to do something sensible, but we don't because of the existing API.
revision tracking patches round 4
This obsoletes id:1439112285-6681-1-git-send-email-da...@tethera.net The main differences since that series are in the command line syntax for notmuch-count. We also now consider passing --uuid to notmuch-compact an error, since the user might reasonably expect that to do something sensible, but we don't because of the existing API. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch