sort order regression

2010-04-26 Thread Michal Sojka
> Want to replay all the git test-suite commits other than any from the > person with the missing ack? That should get us pretty close to the > current state in git, would give us code we could use, and might even > make it possible for us to submit improvements directly to the upstream > git

sort order regression

2010-04-26 Thread Carl Worth
On Mon, 26 Apr 2010 11:59:12 +0200, Michal Sojka wrote: > > Want to replay all the git test-suite commits other than any from the > > person with the missing ack? > > I do not fully understand what you propose here. You mean to reply the > commits from git repository into notmuch repository and

Re: sort order regression

2010-04-26 Thread Michal Sojka
Want to replay all the git test-suite commits other than any from the person with the missing ack? That should get us pretty close to the current state in git, would give us code we could use, and might even make it possible for us to submit improvements directly to the upstream git

Re: sort order regression

2010-04-26 Thread Carl Worth
On Mon, 26 Apr 2010 11:59:12 +0200, Michal Sojka sojk...@fel.cvut.cz wrote: Want to replay all the git test-suite commits other than any from the person with the missing ack? I do not fully understand what you propose here. You mean to reply the commits from git repository into notmuch

sort order regression

2010-04-23 Thread Michal Sojka
On Fri, 23 Apr 2010, Sebastian Spaeth wrote: > Ohh, that is a good point. Maybe I should write some :-). Is the test > suite going to be changed any day now or does it still make sense to > write tests for the "monolitic" test suite? I do not have a plan to modularize the test suite in a near

sort order regression

2010-04-23 Thread Sebastian Spaeth
On 2010-04-22, Carl Worth wrote: > On 22 Apr 2010, Sebastian Spaeth wrote: > > > > jkr and I noticed that patch series are shown in reverse order now, in > > fact threads seem to display messages at the same depth in reverse > > chronological order now. > > My fault! Sorry about that. No harm

sort order regression

2010-04-23 Thread Carl Worth
On Fri, 23 Apr 2010 10:15:22 +0200, Michal Sojka wrote: > On Fri, 23 Apr 2010, Sebastian Spaeth wrote: > > Ohh, that is a good point. Maybe I should write some :-). Is the test > > suite going to be changed any day now or does it still make sense to > > write tests for the "monolitic" test suite?

Re: sort order regression

2010-04-23 Thread Michal Sojka
On Fri, 23 Apr 2010, Sebastian Spaeth wrote: Ohh, that is a good point. Maybe I should write some :-). Is the test suite going to be changed any day now or does it still make sense to write tests for the monolitic test suite? I do not have a plan to modularize the test suite in a near future.

Re: sort order regression

2010-04-23 Thread Carl Worth
On Fri, 23 Apr 2010 10:15:22 +0200, Michal Sojka sojk...@fel.cvut.cz wrote: On Fri, 23 Apr 2010, Sebastian Spaeth wrote: Ohh, that is a good point. Maybe I should write some :-). Is the test suite going to be changed any day now or does it still make sense to write tests for the monolitic

sort order regression

2010-04-22 Thread Sebastian Spaeth
jkr and I noticed that patch series are shown in reverse order now, in fact threads seem to display messages at the same depth in reverse chronological order now. Here is my monologue from IRC: Is that supposed to show the whole thread in reverse chronological order?: notmuch show

sort order regression

2010-04-22 Thread Carl Worth
On Thu, 22 Apr 2010 16:06:27 +0200, "Sebastian Spaeth" wrote: > > jkr and I noticed that patch series are shown in reverse order now, in > fact threads seem to display messages at the same depth in reverse > chronological order now. My fault! Sorry about that. On Thu, 22 Apr 2010 10:14:16

sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 10:21:11 -0400, Jesse Rosenthal wrote: > My suggestion would be to revert both the simplification and the fix to > enable the simplification to pass: (36e4459a3, 2a1a4f0551). Sorry, got that slightly wrong. The following commits need to be reverted:

sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 10:14:16 -0400, Jesse Rosenthal wrote: > Just to follow up on this, it seems that the regression comes from the > fix Carl introduced in 2a1a4f0551 to make his simplification of my patch > (simplification = 36e4459a3 , my patch = 4971b85641) pass tests. The > question is

sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 16:06:27 +0200, Sebastian Spaeth wrote: > > jkr and I noticed that patch series are shown in reverse order now, in > fact threads seem to display messages at the same depth in reverse > chronological order now. Just to follow up on this, it seems that the regression comes

sort order regression

2010-04-22 Thread Sebastian Spaeth
jkr and I noticed that patch series are shown in reverse order now, in fact threads seem to display messages at the same depth in reverse chronological order now. Here is my monologue from IRC: Is that supposed to show the whole thread in reverse chronological order?: notmuch show

Re: sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 16:06:27 +0200, Sebastian Spaeth sebast...@sspaeth.de wrote: jkr and I noticed that patch series are shown in reverse order now, in fact threads seem to display messages at the same depth in reverse chronological order now. Just to follow up on this, it seems that the

Re: sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 10:14:16 -0400, Jesse Rosenthal jrosent...@jhu.edu wrote: Just to follow up on this, it seems that the regression comes from the fix Carl introduced in 2a1a4f0551 to make his simplification of my patch (simplification = 36e4459a3 , my patch = 4971b85641) pass tests. The

Re: sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 10:21:11 -0400, Jesse Rosenthal jrosent...@jhu.edu wrote: My suggestion would be to revert both the simplification and the fix to enable the simplification to pass: (36e4459a3, 2a1a4f0551). Sorry, got that slightly wrong. The following commits need to be reverted: