Re: v4 flexible path location
David Bremner writes: > Since v3 [1] > > - rebase against the uncrustified version (unfortunately this makes an > interdiff too noisy to be helpful). > - improve (?) the documentation of database.mail_root in notmuch-config(1). > - tweak commit messages > - move the call to _init_libs from [10/22] to [9/22] > > I'm going to mark this version as ready to apply, so object now, or > grumble later. > As promised, I have now applied the updated version of this series to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: v4 flexible path location
David Bremner writes: > Since v3 [1] > > - rebase against the uncrustified version (unfortunately this makes an > interdiff too noisy to be helpful). > - improve (?) the documentation of database.mail_root in notmuch-config(1). > - tweak commit messages > - move the call to _init_libs from [10/22] to [9/22] > > I'm going to mark this version as ready to apply, so object now, or > grumble later. Rebasing this on top of the hook fix, I noticed the following diff --git a/lib/open.cc b/lib/open.cc index c9390359..8f572b0b 100644 --- a/lib/open.cc +++ b/lib/open.cc @@ -508,7 +508,7 @@ notmuch_database_open_with_config (const char *database_path, _set_database_path (notmuch, database_path); -status = _notmuch_choose_xapian_path (local, database_path, +status = _notmuch_choose_xapian_path (notmuch, database_path, ¬much->xapian_path, &message); if (status) goto DONE; Like all good memory bugs, this was mysteriously undetected until reopen was called multiple times in the hook fix. This is now fixed in my git repo. I'll hold off posting another series for now. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
v4 flexible path location
Since v3 [1] - rebase against the uncrustified version (unfortunately this makes an interdiff too noisy to be helpful). - improve (?) the documentation of database.mail_root in notmuch-config(1). - tweak commit messages - move the call to _init_libs from [10/22] to [9/22] I'm going to mark this version as ready to apply, so object now, or grumble later. [1]: id:20210307172734.1091264-1-da...@tethera.net [PATCH 09/22] lib/open: factor out library initialization [PATCH 10/22] lib/open: reuse directory checks from n_d_c_with_config ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
