[PATCH] test: Detect when some command unexpectedly fails

2010-11-21 Thread Michal Sojka
When some command in between test_begin_subtest and test_expect_equal fails, the test suite does not detect it unless the failure leads to difference in the strings compared by test_expect_equal. This patch sets shell -e option which switches on the detection of failed commands (thise with

Re: [PATCH] Implement a simple read-eval-print loop.

2010-11-21 Thread Austin Clements
Out of curiosity, why not simply use SSH control mastering? You could even make that part of the standard remote notmuch script, without requiring the user to change anything in their ssh configuration. This should be just as fast as a remote notmuch shell, but retains the ability to run

Re: [PATCH] Implement a simple read-eval-print loop.

2010-11-21 Thread Michal Sojka
On Sun, 21 Nov 2010, Michal Sojka wrote: This is a great idea. Now I use this script to invoke notmuch remotely and I don't have to create master connection manually. #!/bin/bash socket=$HOME/.ssh/notmuch-connection if [[ ! -S $socket ]]; then # Create master connection in background

Re: [PATCH] Implement a simple read-eval-print loop.

2010-11-21 Thread Michael Hudson
On Sun, 21 Nov 2010 22:51:29 +0100, Michal Sojka sojk...@fel.cvut.cz wrote: On Sun, 21 Nov 2010, Michal Sojka wrote: This is a great idea. Now I use this script to invoke notmuch remotely and I don't have to create master connection manually. #!/bin/bash

Re: [PATCH] Implement a simple read-eval-print loop.

2010-11-21 Thread Austin Clements
What about notmuch count query1; notmuch count query2; ... all as a single command issued by notmuch-hello? That should give exactly the same output, but eliminates the network round-trips without special support from count. It would be interesting to see how this compares with your modified

[PATCH] Including 'unread' tag to mails without maildir flags

2010-11-21 Thread Michal Sojka
On Fri, 19 Nov 2010, meskio at sindominio.net wrote: > Some mail fetchers, like fetchmail, leaves the email without ':2,' at the end > of > the filename. Notmuch didn't detect this emails as maildir, it didn't add the > maildir flags to them. > > Now it detects if a mail is in a maildir by the

[PATCH 1/2] test: Add test for messages without maildir info in new

2010-11-21 Thread Michal Sojka
A message in new without maildir info should be tagged the same as if empty info (:,2) is present, i.e. unread tag must be present. To test this behavior, notmuch new must be configured to add only inbox tag and not two tags inbox and unread, which is the default. --- test/maildir-sync | 10

[PATCH 2/2] Include 'unread' tag only to mails in new

2010-11-21 Thread Michal Sojka
Ruben's previous patch fixed the problem that he experienced, but it also caused the test "Removing info from filename leaves tags unchanged" to fail. This is an attempt to make all tests to pass. The Ruben's change is restricted to be only effective in 'new' directory. --- lib/message.cc |9

[PATCH] Additional maildir-sync test

2010-11-21 Thread Michal Sojka
On Sat, 20 Nov 2010, Michal Sojka wrote: > your patch fixes the problem, but it also breaks one of the tests in > test suite. I created the test for your patch ... and here is another test which was in my original synchronization patches, but Carl decided to remove it. It checks that tagging

[PATCH] test: Add emacs test for messages with very long subjects

2010-11-21 Thread Dmitry Kurochkin
RL: <http://notmuchmail.org/pipermail/notmuch/attachments/20101121/2e74cceb/attachment-0001.patch>

[PATCH] test: Detect when some command unexpectedly fails

2010-11-21 Thread Michal Sojka
When some command in between test_begin_subtest and test_expect_equal fails, the test suite does not detect it unless the failure leads to difference in the strings compared by test_expect_equal. This patch sets shell -e option which switches on the detection of failed commands (thise with

[PATCH] Implement a simple read-eval-print loop.

2010-11-21 Thread Austin Clements
, but > when I started "repl" was the only one I could think of. > > Servilio > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch > -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20101121/009f39f8/attachment.html>

[PATCH] Implement a simple read-eval-print loop.

2010-11-21 Thread Michal Sojka
On Sun, 21 Nov 2010, Austin Clements wrote: > Out of curiosity, why not simply use SSH control mastering? I use control mastering, but it still takes about five seconds to display notmuch hello screen. > You could even make that part of the "standard" remote notmuch script, > without requiring

[PATCH] Implement a simple read-eval-print loop.

2010-11-21 Thread Michal Sojka
On Sun, 21 Nov 2010, Michal Sojka wrote: > This is a great idea. Now I use this script to invoke notmuch remotely > and I don't have to create master connection manually. > > #!/bin/bash > socket="$HOME/.ssh/notmuch-connection" > if [[ ! -S $socket ]]; then > # Create master connection in

[PATCH] Implement a simple read-eval-print loop.

2010-11-21 Thread Austin Clements
ount --stdin > > > ... > > -Michal > -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20101121/2bc73766/attachment.htm>