Re: release-candidate/0.6

2011-05-10 Thread Jameson Graef Rollins
On Mon, 09 May 2011 10:20:18 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: ***I hereby declare that release-candidate/0.6 is ready for release.*** After all of that pomp, I take it all back! Fully fearful of further delaying release of 0.6, I decided I wanted to slip in a

Re: [PATCH] test: use `princ' instead of `message' calls in emacs tests

2011-05-10 Thread Jameson Graef Rollins
On Tue, 10 May 2011 10:25:08 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: The patch replaces all (message (buffer-string)) calls in emacs tests with (princ (buffer-string)). This avoids accidentally interpreting '%' as format specifiers and makes code simpler because we do not

Re: vim support improvements for 0.6

2011-05-10 Thread Jameson Graef Rollins
On Tue, 10 May 2011 01:30:11 +0300, Felipe Contreras felipe.contre...@gmail.com wrote: All right. Hopefully nobody will request further changes to these patches: git://github.com/felipec/notmuch.git [fc-vim-next] It's not rebased on top of your branch, but there are no merge conflicts.

[PATCH] avoid segfault when calling sanitize_string() on NULL

2011-05-10 Thread Daniel Kahn Gillmor
--- notmuch-search.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 794b145..26b24eb 100644 --- a/notmuch-search.c +++ b/notmuch-search.c @@ -116,6 +116,9 @@ sanitize_string (const void *ctx, const char *str) { char *out,

Re: [PATCH] avoid segfault when calling sanitize_string() on NULL

2011-05-10 Thread Jameson Graef Rollins
Yikes! Thanks for finding this, dkg. I just pushed this to r-c/0.6. It looks like we need to expand the tests to test this corner case. jamie. pgpdZpqR2ALSs.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org

Re: release-candidate/0.6

2011-05-10 Thread Jameson Graef Rollins
Arg. One last bit of churn. dkg found a bug in the new sanitize_string function that was causing segfaults on messages with empty headers. This is obviously an imprtant thing to fix. After chatting with some folks on #notmuch, we decided that the debian build dependency on libgmime 2.4.24 is a

Re: storing From and Subject in xapian

2011-05-10 Thread Stewart Smith
On Sun, 08 May 2011 22:24:37 -0700, Istvan Marko notm...@kismala.com wrote: Jameson Graef Rollins jroll...@finestructure.net writes: Unless I hear a strong positive response I'll hold off on considering it for 0.6, and suggest instead targeting it for 0.7. I would say wait until 0.7 at

vim support improvements for 0.6

2011-05-10 Thread Felipe Contreras
On Fri, May 6, 2011 at 10:51 PM, Jameson Graef Rollins wrote: > Hi, Filipe. ?I notice that you have been submitting a lot of patches for > vim support. ?As you may have seen, I'm trying to put together a release > candidate for notmuch 0.6. ?Since I know nothing about vim, would you be > willing

[PATCH] Don't re-compress .gz & al. in notmuch-show-save-part.

2011-05-10 Thread Dmitry Kurochkin
Write-region handles some file names specially, see Emacs Lisp manual section 25.11 Making Certain File Names "Magic" [1]. This is a nice feature for normal text editing, but it is not desirable if we need to save raw file content (e.g. attachment). In particular, this affects archives and may

[PATCH] python/thread: always return a string in get_subject/authors

2011-05-10 Thread Sebastian Spaeth
ype: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110510/ea8cf13e/attachment.pgp>

[PATCH] test: saving attachments from within emacs using notmuch-show-save-attachments

2011-05-10 Thread Dmitry Kurochkin
--- test/emacs | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/test/emacs b/test/emacs index 75dec89..675a887 100755 --- a/test/emacs +++ b/test/emacs @@ -112,9 +112,17 @@ Fcc: $(pwd)/mail/sent On Fri, 29 Mar 1974 10:00:00 -, Notmuch Test Suite wrote:

[PATCH] test: saving attachments from within emacs using notmuch-show-save-part

2011-05-10 Thread Dmitry Kurochkin
--- Oops, the previos patch (id:"1304990327-8665-1-git-send-email-dmitry.kurochkin at gmail.com") has wrong title. s/notmuch-show-save-attachments/notmuch-show-save-part/ Regards, Dmitry test/emacs | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git

[PATCH v2 0/2] test: add test for saving attachments using notmuch-show-save-part

2011-05-10 Thread Dmitry Kurochkin
This is amended patch from id:"1304990689-10933-1-git-send-email-dmitry.kurochkin at gmail.com" to test saving attachments withing Emacs using notmuch-show-save-part. It uses test_expect_equal_file instead of test_expect_equal as suggested by Jameson. This patch is for the release-candidate/0.6

[PATCH 1/2] test: copy files in test_expect_equal_file instead of moving them

2011-05-10 Thread Dmitry Kurochkin
Before the change, test_expect_equal_file moved files it compared in case of failure. The patch changes it to copy the files instead. This allows testing non-temporary files which are stored in git. Note: the change should not result in new temporary files left after the tests.

[PATCH 2/2] test: add test for saving attachments using notmuch-show-save-part

2011-05-10 Thread Dmitry Kurochkin
Use .gz filenames for saved attachments in the tests to check that Emacs does not re-compress the file. Use test_expect_equal_file instead of test_expect_equal to avoid binary output on the console. --- test/emacs | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff

[PATCH] test: add "%s" format string to all `message' calls in emacs tests

2011-05-10 Thread Dmitry Kurochkin
The patch replaces all (message (buffer-string)) calls in emacs tests with (message "%s" (buffer-string)). This works around an Emacs (23.3+1-1 on current Debian Unstable) segfault in "Ensure that emacs doesn't drop results" test. Note: the segfault does not happen on every test run. Though, it

[PATCH] test: add "%s" format string to all `message' calls in emacs tests

2011-05-10 Thread Austin Clements
This looks good to me (and is certainly more correct), but seems rather roundabout. Is there a reason this code doesn't simply (princ (buffer-string))? On Tue, May 10, 2011 at 1:40 AM, Dmitry Kurochkin wrote: > The patch replaces all (message (buffer-string)) calls in emacs > tests with

[PATCH] test: add "%s" format string to all `message' calls in emacs tests

2011-05-10 Thread Dmitry Kurochkin
On Tue, 10 May 2011 01:47:17 -0400, Austin Clements wrote: > This looks good to me (and is certainly more correct), but seems > rather roundabout. Is there a reason this code doesn't simply (princ > (buffer-string))? > Thanks, Austin! I am, unfortunately, not an Emacs Lisp expert. I did not

[PATCH] test: use `princ' instead of `message' calls in emacs tests

2011-05-10 Thread Dmitry Kurochkin
The patch replaces all (message (buffer-string)) calls in emacs tests with (princ (buffer-string)). This avoids accidentally interpreting '%' as format specifiers and makes code simpler because we do not need to capture stderr. Also, the patch works around an Emacs (23.3+1-1 on current Debian

release-candidate/0.6

2011-05-10 Thread Jameson Graef Rollins
0.6 f357eafd3c315c7b59abe3088479a3b4e68a4d11 -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110510/da69a3e9/attachment.pgp>

[PATCH] test: use `princ' instead of `message' calls in emacs tests

2011-05-10 Thread Jameson Graef Rollins
nt was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110510/3f91699d/attachment-0001.pgp>

vim support improvements for 0.6

2011-05-10 Thread Jameson Graef Rollins
ipe. Merged with r-c/0.6 at 0e57911dae0dc07ae567fa4467a9686a9d090ace. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attac

[PATCH] avoid segfault when calling sanitize_string() on NULL

2011-05-10 Thread Daniel Kahn Gillmor
--- notmuch-search.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 794b145..26b24eb 100644 --- a/notmuch-search.c +++ b/notmuch-search.c @@ -116,6 +116,9 @@ sanitize_string (const void *ctx, const char *str) { char *out,

[PATCH] avoid segfault when calling sanitize_string() on NULL

2011-05-10 Thread Jameson Graef Rollins
: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110510/d1439a9a/attachment.pgp>

release-candidate/0.6

2011-05-10 Thread Jameson Graef Rollins
aac1936bc9f878bd9ad2e097c5a686e146b73143 -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110510/d2eb6b6a/attachment.pgp>