Re: address completion when composing

2011-05-12 Thread Jameson Graef Rollins
On Thu, 12 May 2011 02:04:41 +0200, Florian Friesdorf f...@chaoflow.net wrote: 1. store to/cc/bcc in xapian Hey, Florian. I think all of these fields are actually already stored in the database. 2. provide a mechanism to query those fields from the cmdline I think this is the idea. You

Re: storing From and Subject in xapian

2011-05-12 Thread Istvan Marko
Stewart Smith stew...@flamingspork.com writes: Would it be possible to progressively fill the DB with the new data? i.e. if Subject/From not in db for message add Subject/From for this message to DB. I started looking into this but then realized that notmuch search opens the database in

Re: release-candidate/0.6

2011-05-12 Thread Pieter Praet
On Tue, 10 May 2011 09:42:39 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Arg. One last bit of churn. dkg found a bug in the new sanitize_string function that was causing segfaults on messages with empty headers. This is obviously an imprtant thing to fix. After

[PATCH] test: Fix message when skipping test_expect_equal* tests

2011-05-12 Thread Austin Clements
For these types of tests, the test name is previously recorded in a variable, not passed to the test function, so pass this variable to test_skip. --- test/test-lib.sh |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index

[PATCH] test: Report test failures from test_expect_*

2011-05-12 Thread Austin Clements
This makes test_expect_* return non-zero if the test fails, so the caller can make decisions based on this, such as setting test prerequisites. --- test/test-lib.sh |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 9b56406..955350a

Re: release-candidate/0.6

2011-05-12 Thread Austin Clements
On Thu, May 12, 2011 at 8:22 AM, Pieter Praet pie...@praet.org wrote: The atomicity tests were failing here because I didn't have GDB installed, so I've added it as a prereq. Sorry, I've had a patch to address that sitting around, but hadn't sent it out (and I only fixed that one test). I

Re: [PATCH] test: search-by-folder single-word search terms should be updated correctly when directories are renamed.

2011-05-12 Thread Pieter Praet
On Sun, 13 Mar 2011 00:44:14 +0100, Pieter Praet pie...@praet.org wrote: On Mon, 17 Jan 2011 14:00:41 +0100, Sebastian Spaeth sebast...@sspaeth.de wrote: However, when moving files into another folder and rerunning notmuch new, the folder value is never updated, it seems. This appears to

[PATCH 1/2] Make `notmuch-show-clean-address' parsing-error-proof.

2011-05-12 Thread Dmitry Kurochkin
Mail-header-parse-address may fail for an invalid address. Before the change, this would result in empty notmuch-show buffer with an error message like: Scan error: Unbalanced parentheses. The patch wraps the function in condition-case and returns unchanged address in case of error. ---

[PATCH 2/2] test: add notmuch-show for message with invalid From test

2011-05-12 Thread Dmitry Kurochkin
--- test/emacs | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 2e85b0c..f2983a7 100755 --- a/test/emacs +++ b/test/emacs @@ -37,8 +37,21 @@ output=$(test_emacs (notmuch-show \$maildir_storage_thread\) (princ (buffer-s

Re: release-candidate/0.6

2011-05-12 Thread Pieter Praet
On Thu, 12 May 2011 09:18:48 -0400, Austin Clements amdra...@mit.edu wrote: On Thu, May 12, 2011 at 8:22 AM, Pieter Praet pie...@praet.org wrote: The atomicity tests were failing here because I didn't have GDB installed, so I've added it as a prereq. Sorry, I've had a patch to address that

Re: [PATCH] test: search-by-folder single-word search terms should be updated correctly when directories are renamed.

2011-05-12 Thread Jameson Graef Rollins
On Thu, 12 May 2011 15:22:25 +0200, Pieter Praet pie...@praet.org wrote: I've pushed a cleaner version of this patch to my github repo, for inclusion in release-candidate/0.6. Hey, Pieter. I realize we've been passing around git urls a lot recently, particularly in regards to the

Re: release-candidate/0.6

2011-05-12 Thread Austin Clements
Nifty. I was afraid to go romping through all of the other test dependencies; I'm glad somebody wasn't. ]:--8) It should be noted that these patches depend on id:1305206110-17511-1-git-send-email-amdra...@mit.edu for correctness and id:1305206080-17461-1-git-send-email-amdra...@mit.edu for

address completion when composing

2011-05-12 Thread Florian Friesdorf
application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110512/fce2d329/attachment.pgp>

address completion when composing

2011-05-12 Thread Jameson Graef Rollins
. Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110512/4b0f5419/attachment.pgp>

storing From and Subject in xapian

2011-05-12 Thread Istvan Marko
Stewart Smith writes: > Would it be possible to progressively fill the DB with the new data? > > i.e. > > if Subject/From not in db for message >add Subject/From for this message to DB. I started looking into this but then realized that notmuch search opens the database in read-only mode so

release-candidate/0.6

2011-05-12 Thread Pieter Praet
On Tue, 10 May 2011 09:42:39 -0700, Jameson Graef Rollins wrote: > Arg. One last bit of churn. > > dkg found a bug in the new sanitize_string function that was causing > segfaults on messages with empty headers. This is obviously an imprtant > thing to fix. > > After chatting with some folks

[PATCH] test: Fix message when skipping test_expect_equal* tests

2011-05-12 Thread Austin Clements
For these types of tests, the test name is previously recorded in a variable, not passed to the test function, so pass this variable to test_skip. --- test/test-lib.sh |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index

[PATCH] test: Report test failures from test_expect_*

2011-05-12 Thread Austin Clements
This makes test_expect_* return non-zero if the test fails, so the caller can make decisions based on this, such as setting test prerequisites. --- test/test-lib.sh |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 9b56406..955350a

release-candidate/0.6

2011-05-12 Thread Austin Clements
On Thu, May 12, 2011 at 8:22 AM, Pieter Praet wrote: > The atomicity tests were failing here because I didn't have GDB > installed, so I've added it as a prereq. Sorry, I've had a patch to address that sitting around, but hadn't sent it out (and I only fixed that one test). I would suggest a

[PATCH] test: "search-by-folder" single-word search terms should be updated correctly when directories are renamed.

2011-05-12 Thread Pieter Praet
On Sun, 13 Mar 2011 00:44:14 +0100, Pieter Praet wrote: > On Mon, 17 Jan 2011 14:00:41 +0100, Sebastian Spaeth SSpaeth.de> wrote: > > However, when moving files into another folder and rerunning notmuch > > new, the folder value is never updated, it seems. > > This appears to occur only when

[PATCH 1/2] Make `notmuch-show-clean-address' parsing-error-proof.

2011-05-12 Thread Dmitry Kurochkin
Mail-header-parse-address may fail for an invalid address. Before the change, this would result in empty notmuch-show buffer with an error message like: Scan error: "Unbalanced parentheses". The patch wraps the function in condition-case and returns unchanged address in case of error. ---

[PATCH 2/2] test: add "notmuch-show for message with invalid From" test

2011-05-12 Thread Dmitry Kurochkin
--- test/emacs | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 2e85b0c..f2983a7 100755 --- a/test/emacs +++ b/test/emacs @@ -37,8 +37,21 @@ output=$(test_emacs "(notmuch-show \"$maildir_storage_thread\") (princ (buffer-s

release-candidate/0.6

2011-05-12 Thread Pieter Praet
On Thu, 12 May 2011 09:18:48 -0400, Austin Clements wrote: > On Thu, May 12, 2011 at 8:22 AM, Pieter Praet wrote: > > The atomicity tests were failing here because I didn't have GDB > > installed, so I've added it as a prereq. > > Sorry, I've had a patch to address that sitting around, but

[PATCH] test: "search-by-folder" single-word search terms should be updated correctly when directories are renamed.

2011-05-12 Thread Jameson Graef Rollins
t part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110512/e27f0f6c/attachment.pgp>

release-candidate/0.6

2011-05-12 Thread Austin Clements
Nifty. I was afraid to go romping through all of the other test dependencies; I'm glad somebody wasn't. ]:--8) It should be noted that these patches depend on id:1305206110-17511-1-git-send-email-amdragon at mit.edu for correctness and id:1305206080-17461-1-git-send-email-amdragon at mit.edu

release-candidate/0.6

2011-05-12 Thread Carl Worth
On Fri, 06 May 2011 12:46:34 -0700, Jameson Graef Rollins wrote: > Hi, folks. As some of you already know, I am trying to put together a > release candidate for a 0.6 release that we can present to cworth for > approval. Hi Jameson, This is really great! I appreciate you collecting useful