Re: [PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Daniel Schoepe
On Wed, 25 May 2011 00:10:43 -0400, Austin Clements amdra...@mit.edu wrote: Out of curiosity, what use cases do you envision for this? So far I've only heard two, both of which seem like great ideas, but neither of which require such a heavy-handed solution: displaying unread counts for tags

[PATCH] fixed return value check of sysoncf in get_name_from_passwd_file / get_username_from_passwd_file

2011-05-25 Thread Matthias Guedemann
When trying to port notmuch to DragonFlyBSD I found it core dumped immediately. The reason was that the sysconf(_SC_GETPW_R_SIZE_MAX) call returned -1 which is used for talloc memory allocation. The check was there but was done _after_ the allocation, the attached patch fixes this. regards

Re: [PATCH] emacs: Allow user to choose From address when composing a new message.

2011-05-25 Thread Thomas Jost
On Tue, 24 May 2011 15:02:01 -0700, Carl Worth cwo...@cworth.org wrote: In order to select a From address, the user simply presses M instead of m to begin composing a message. By default the list of names/addresses to be used during completion will be automatically generated by the settings in

[PATCH 1/4] emacs: Allow the user choose the From address when composing a new message from notmuch-show-mode too.

2011-05-25 Thread Thomas Jost
--- emacs/notmuch-show.el |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 825988c..93f46ac 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -847,7 +847,8 @@ function is used. (define-key map

[PATCH 2/4] emacs: Move the prompt for sender code to a new function.

2011-05-25 Thread Thomas Jost
This allows the code to be reused in different functions without duplicating it. --- emacs/notmuch-mua.el | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index cd4d75d..0bde02c 100644 --- a/emacs/notmuch-mua.el +++

[PATCH 3/4] emacs: Allow the user to choose the From address when forwarding a message.

2011-05-25 Thread Thomas Jost
--- emacs/notmuch-mua.el |8 emacs/notmuch-show.el |7 +++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index 0bde02c..7c08a6e 100644 --- a/emacs/notmuch-mua.el +++ b/emacs/notmuch-mua.el @@ -182,6 +182,14 @@

[PATCH 4/4] emacs: Allow the user to choose the From address when replying to a message.

2011-05-25 Thread Thomas Jost
--- emacs/notmuch-mua.el |9 - emacs/notmuch-show.el |6 ++ emacs/notmuch.el |7 +++ 3 files changed, 21 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index 7c08a6e..d04e69c 100644 --- a/emacs/notmuch-mua.el +++

Re: [PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Austin Clements
On Wed, May 25, 2011 at 6:04 AM, Daniel Schoepe daniel.scho...@googlemail.com wrote: On Wed, 25 May 2011 00:10:43 -0400, Austin Clements amdra...@mit.edu wrote: Out of curiosity, what use cases do you envision for this?  So far I've only heard two, both of which seem like great ideas, but

Re: [PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Daniel Schoepe
On Wed, 25 May 2011 10:44:51 -0400, Austin Clements amdra...@mit.edu wrote: May I suggest a slightly different way of looking at this that will quell my inner parser? Instead of configuring a weird query fragment like and tag:unread to be string-concatenated with the tag query, configure a

Re: [PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Daniel Schoepe
I accidentally used `filter' in the previous patch which isn't defined by default during runtime, updated version in the attachment. From e8f5e997b7082a50f75d7329a69fccc126a21e5e Mon Sep 17 00:00:00 2001 From: Daniel Schoepe daniel.scho...@googlemail.com Date: Fri, 20 May 2011 00:53:50 +0200

Re: [PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Austin Clements
On Wed, May 25, 2011 at 1:56 PM, Daniel Schoepe daniel.scho...@googlemail.com wrote: I accidentally used `filter' in the previous patch which isn't defined by default during runtime, updated version in the attachment. Cool. My inner parser is happy. A few comments on the code: +(defcustom

Re: [PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Daniel Schoepe
On Wed, 25 May 2011 15:11:16 -0400, Austin Clements amdra...@mit.edu wrote: At least in Emacs 23.3.1, it has to be (const :tag tag:TAG nil). I didn't think the order mattered, but the tag didn't display otherwise. It would also be good to give descriptive tags to the other choices. It

[PATCH] Fix hiding a message while some citations are visible

2011-05-25 Thread Dmitry Kurochkin
This patch series does some fixes and improvements for hiding and showing messages in notmuch-show. However it comes with a regression: isearch is broken for hidden overlays when `invisible' property is a list. I have opened emacs bug #8721 [1] and sent a patch. It has been committed to emacs

[PATCH 1/5] Pass message to the `notmuch-show-insert-text/plain-hook' hook.

2011-05-25 Thread Dmitry Kurochkin
Before the change, the `notmuch-show-insert-text/plain-hook' was given only the `depth' argument. The patch adds another one - the message. Currently, the new message argument is not used by any on the hooks. But it will be used later to get access to message invisibility specs when wash

[PATCH 2/5] Set message invisibility spec properties before inserting the body.

2011-05-25 Thread Dmitry Kurochkin
This would allow body-inserting code (in particular, wash button-inserting code) to use message invisibility specs. --- emacs/notmuch-show.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 786debf..34c0b79 100644

[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-05-25 Thread Dmitry Kurochkin
Before the change, message and citation invisibility overlays conflicted: if some citation is made visible and then the whole message is hidden, that citation remained visible. This happened because the citation's overlay has an invisible property which takes priority over the message overlay.

[PATCH 4/5] Set higher priority for headers and hidden citation overlays.

2011-05-25 Thread Dmitry Kurochkin
Before the patch, message, headers and hidden citation overlays had zero priority. All these overlay have `invisible' property. Emacs documentation says that we should not make assumptions about which overlay will prevail when they have the same priority [1]. It happens to work as we need, but

[PATCH 5/5] Simplify message and headers visibility code in notmuch-show view.

2011-05-25 Thread Dmitry Kurochkin
Before the change, headers and message visibility functions took extra care to correctly set `buffer-invisibility-spec'. This was needed because headers overlay `invisible' property had only headers' invisibility spec. So visibility of headers was determined only by the headers invisibility

Re: [PATCH] emacs: Allow user to choose From address when composing a new message.

2011-05-25 Thread Carl Worth
On Wed, 25 May 2011 15:21:06 +0200, Thomas Jost schno...@schnouki.net wrote: Thanks, IMHO that's better than my previous solution. And it makes my .emacs smaller, woohoo! :) Thanks for the review. One little issue though: you did not update notmuch-show-mode-map in notmuch-show.el. I'll

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-05-25 Thread Carl Worth
On Thu, 26 May 2011 02:10:14 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Before the change, message and citation invisibility overlays conflicted: if some citation is made visible and then the whole message is hidden, that citation remained visible. That sounds like quite a bug.

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-05-25 Thread Dmitry Kurochkin
On Wed, 25 May 2011 15:23:47 -0700, Carl Worth cwo...@cworth.org wrote: On Thu, 26 May 2011 02:10:14 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Before the change, message and citation invisibility overlays conflicted: if some citation is made visible and then the whole

Re: [PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Austin Clements
On Wed, May 25, 2011 at 5:21 PM, Daniel Schoepe daniel.scho...@googlemail.com wrote: On Wed, 25 May 2011 15:11:16 -0400, Austin Clements amdra...@mit.edu wrote: So, perhaps something like (defcustom notmuch-hello-tag-list-counts nil   Method for generating counts displayed in the all tags

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-05-25 Thread Carl Worth
On Thu, 26 May 2011 02:34:28 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I am not sure how it is best to test this. The common `printc' method for emacs tests does not work, because it prints invisible parts as well. We need either to find a way to print only visible text on

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-05-25 Thread Dmitry Kurochkin
On Wed, 25 May 2011 15:46:40 -0700, Carl Worth cwo...@cworth.org wrote: On Thu, 26 May 2011 02:34:28 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I am not sure how it is best to test this. The common `printc' method for emacs tests does not work, because it prints invisible

Re: [PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Daniel Schoepe
On Wed, 25 May 2011 18:42:30 -0400, Austin Clements amdra...@mit.edu wrote: 'Doh. That's what I get for not reading the surrounding code. I misunderstood what your patch was going for and assumed it was what *I* wanted notmuch to do, which is to show me useful counts (e.g., unread count),

New crypto patch series

2011-05-25 Thread Jameson Graef Rollins
Hi, folks. This is a series of patches that constitute a complete rework of notmuch crypto support (signature verification and decryption of PGP/MIME messages, with emacs ui support), including some relevant preparatory patches, on top of the notmuch/master branch at

[PATCH 03/11] Use empty strings instead of NULL in format_reply structure.

2011-05-25 Thread Jameson Graef Rollins
This keeps things consistent with notmuch-show, and prevents having to check for the existence of the field pointer for simple string output formats. --- notmuch-reply.c | 12 ++-- show-message.c |2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/notmuch-reply.c

[PATCH 05/11] test: new test-lib function to test for equality between files

2011-05-25 Thread Jameson Graef Rollins
We need to be able to test for the presence of a newline at the end of output. There's no good way to capture trailing newlines in bash, so redirecting output to a file is the next best thing. This new function should be used when testing for output that is expected to have trailing newlines.

[PATCH 01/11] Simplify reply_part function to eliminate redundant code paths.

2011-05-25 Thread Jameson Graef Rollins
This is the same logic but with less code. --- notmuch-reply.c | 41 ++--- 1 files changed, 14 insertions(+), 27 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index ab15650..5d72b1f 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -88,31

[PATCH 09/11] Add decryption of PGP/MIME-encrypted parts with --decrypt.

2011-05-25 Thread Jameson Graef Rollins
This adds support for decrypting PGP/MIME-encrypted parts to notmuch-show and notmuch-reply. The --decrypt option implies --verify. Once decryption (and possibly signature verification) is done, a new part_encstatus formatter is emitted, the part_sigstatus formatter is emitted, and the entire

[PATCH 02/11] Integrate reply_part_content function into reply_part function.

2011-05-25 Thread Jameson Graef Rollins
After the last patch to eliminate some redundant code paths in reply_part, the reply_part_content function was only being called once. Disolving the function and integrating its contents into the reply_part function makes things a little simpler, and frees up some name space that will be needed

[PATCH 07/11] test: add crypto tests for signature verification and decryption

2011-05-25 Thread Jameson Graef Rollins
This adds a new crypto test script to the test suite to test PGP/MIME signature verification and message decryption. Included here is a test GNUPGHOME with a test secret key (passwordless), and test for: * signing/verification * signing/verification with full owner trust * verification

[PATCH 06/11] test: add notmuch_show_sanitize_all function that is a little more aggressive.

2011-05-25 Thread Jameson Graef Rollins
The old notmuch_show_sanitize function only scrubed part of the filename. This one scrubs the full filename, as well as the message id. --- test/test-lib.sh |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 9e2e0b5..ae25635

[PATCH 04/11] Break up format-part function into part_start and part_content functions.

2011-05-25 Thread Jameson Graef Rollins
Future improvements (eg. crypto support) will require adding new part header. By breaking up the output of part headers from the output of part content, we can easily out new part headers with new formatting functions. --- notmuch-client.h |5 +- notmuch-reply.c | 13 --

[PATCH 10/11] emacs: Add support for PGP/MIME verification/decryption

2011-05-25 Thread Jameson Graef Rollins
A new emacs configuration variable notmuch-crypto-process-mime controls the processing of PGP/MIME signatures and encrypted parts. When this is set true, notmuch-query will use the notmuch show --decrypt flag to decrypt encrypted messages and/or calculate the sigstatus of signed messages. If

[PATCH 08/11] Add signature verification of PGP/MIME-signed parts with --verify.

2011-05-25 Thread Jameson Graef Rollins
This is primarily for notmuch-show, although the functionality is added to show-message. Once signatures are processed a new part_sigstatus formatter is emitted, and the entire multipart/signed part is replaced with the contents of the signed part. At the moment only a json part_sigstatus

[PATCH 11/11] tag signed/encrypted during notmuch new

2011-05-25 Thread Jameson Graef Rollins
This patch adds the tag signed to messages with any multipart/signed parts, and the tag encrypted to messages with any multipart/encrypted parts. This only occurs when messages are indexed during notmuch new, so a database rebuild is required to have old messages tagged. --- lib/index.cc

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-05-25 Thread Carl Worth
On Thu, 26 May 2011 03:10:11 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Wed, 25 May 2011 15:46:40 -0700, Carl Worth cwo...@cworth.org wrote: Well, emacs trunk is not broken :) The bug is in lisp code, so you can fix it in .emacs by redefining `isearch-range-invisible'

Re: [PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Carl Worth
On Thu, 26 May 2011 01:21:17 +0200, Daniel Schoepe daniel.scho...@googlemail.com wrote: Since the main difference between those sections is the clear visual distinction, it might be an option to provide the user with functions to easily declare new sections for the hello screen, where this

Re: [PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Austin Clements
On May 25, 2011 7:21 PM, Daniel Schoepe daniel.scho...@googlemail.com wrote: On Wed, 25 May 2011 18:42:30 -0400, Austin Clements amdra...@mit.edu wrote: 'Doh. That's what I get for not reading the surrounding code. I misunderstood what your patch was going for and assumed it was what *I*

[PATCH] Save and restore point explicitly in `notmuch-wash-toggle-invisible-action'.

2011-05-25 Thread Dmitry Kurochkin
Hi Carl. On Tue, 24 May 2011 13:20:56 -0700, Carl Worth wrote: > On Mon, 23 May 2011 19:29:46 +0400, Dmitry Kurochkin gmail.com> wrote: > > Before the change, save-excursion was used to save the point. > > But the restored position is affected by buffer modifications, > > which results in

[PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Daniel Schoepe
On Tue, 24 May 2011 13:39:44 -0700, Carl Worth wrote: > This seems like a useful feature, but perhaps it's a little too general? > > I'm imagining a user wanting to use this functionality but not knowing > anything about writing an emacs-lisp function. For such a user, this > variable won't

[PATCH] Save and restore point explicitly in `notmuch-wash-toggle-invisible-action'.

2011-05-25 Thread Dmitry Kurochkin
On Tue, 24 May 2011 15:01:04 -0700, Carl Worth wrote: > On Wed, 25 May 2011 00:43:20 +0400, Dmitry Kurochkin gmail.com> wrote: > > Now, looking at Emacs source code, save_excursion_save() uses > > point_marker() to save the point. As you said above, markers are > > updated when the

[PATCH] Save and restore point explicitly in `notmuch-wash-toggle-invisible-action'.

2011-05-25 Thread Dmitry Kurochkin
On Tue, 24 May 2011 18:43:41 -0400, Austin Clements wrote: > On Tue, May 24, 2011 at 6:16 PM, Dmitry Kurochkin > wrote: > > When a user clicks the button, the cursor is somewhere inside the old > > label. ?If we save the point as a marker, after step 3 it would end up > > at the position where

[PATCH] Save and restore point explicitly in `notmuch-wash-toggle-invisible-action'.

2011-05-25 Thread Dmitry Kurochkin
Before the change, save-excursion was used to save the point. But the restored position is affected by buffer modifications, which results in jumping cursor. The patch saves and restores point explicitly by using a variable instead of save-excursion. --- emacs/notmuch-wash.el | 13

[PATCH] Save and restore point explicitly in `notmuch-wash-toggle-invisible-action'.

2011-05-25 Thread Dmitry Kurochkin
On Tue, 24 May 2011 16:20:34 -0700, Carl Worth wrote: > On Tue, 24 May 2011 18:43:41 -0400, Austin Clements > wrote: > > Saving point this way is a bit dangerous, though. For example, if > > you're near the end of the buffer and shorten the label, attempting to > > restore the point could

[PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Austin Clements
Out of curiosity, what use cases do you envision for this? So far I've only heard two, both of which seem like great ideas, but neither of which require such a heavy-handed solution: displaying unread counts for tags rather than total counts, and hiding unused tags. I would argue that we

[PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Daniel Schoepe
ext attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110525/f1d8d2dc/attachment.pgp>

[PATCH] fixed return value check of sysoncf in get_name_from_passwd_file / get_username_from_passwd_file

2011-05-25 Thread Matthias Guedemann
When trying to port notmuch to DragonFlyBSD I found it core dumped immediately. The reason was that the "sysconf(_SC_GETPW_R_SIZE_MAX)" call returned -1 which is used for talloc memory allocation. The check was there but was done _after_ the allocation, the attached patch fixes this. regards

[PATCH] Change in increment_mtime for BSD compatibility of test suite

2011-05-25 Thread Felix Geller
notmuchmail.org/pipermail/notmuch/attachments/20110525/3c4d9478/attachment.pgp>

[PATCH] emacs: Allow user to choose "From" address when composing a new message.

2011-05-25 Thread Thomas Jost
-- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110525/65a0e32e/attachment.pgp>

[PATCH 1/4] emacs: Allow the user choose the "From" address when composing a new message from notmuch-show-mode too.

2011-05-25 Thread Thomas Jost
--- emacs/notmuch-show.el |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 825988c..93f46ac 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -847,7 +847,8 @@ function is used. " (define-key map

[PATCH 2/4] emacs: Move the "prompt for sender" code to a new function.

2011-05-25 Thread Thomas Jost
This allows the code to be reused in different functions without duplicating it. --- emacs/notmuch-mua.el | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index cd4d75d..0bde02c 100644 --- a/emacs/notmuch-mua.el +++

[PATCH 3/4] emacs: Allow the user to choose the "From" address when forwarding a message.

2011-05-25 Thread Thomas Jost
--- emacs/notmuch-mua.el |8 emacs/notmuch-show.el |7 +++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index 0bde02c..7c08a6e 100644 --- a/emacs/notmuch-mua.el +++ b/emacs/notmuch-mua.el @@ -182,6 +182,14 @@

[PATCH 4/4] emacs: Allow the user to choose the "From" address when replying to a message.

2011-05-25 Thread Thomas Jost
--- emacs/notmuch-mua.el |9 - emacs/notmuch-show.el |6 ++ emacs/notmuch.el |7 +++ 3 files changed, 21 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index 7c08a6e..d04e69c 100644 --- a/emacs/notmuch-mua.el +++

[PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Austin Clements
On Wed, May 25, 2011 at 6:04 AM, Daniel Schoepe wrote: > On Wed, 25 May 2011 00:10:43 -0400, Austin Clements > wrote: >> Out of curiosity, what use cases do you envision for this? ?So far >> I've only heard two, both of which seem like great ideas, but neither >> of which require such a

[PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Daniel Schoepe
scrubbed... Name: 0001-emacs-Make-queries-used-in-the-all-tags-section-conf.patch Type: text/x-diff Size: 3312 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110525/f02b5621/attachment.patch> -- next part -- A non-text attachment w

[PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Daniel Schoepe
-diff Size: 4469 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110525/214862c2/attachment.patch> -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not ava

[PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Austin Clements
On Wed, May 25, 2011 at 1:56 PM, Daniel Schoepe wrote: > I accidentally used `filter' in the previous patch which isn't defined > by default during runtime, updated version in the attachment. Cool. My inner parser is happy. A few comments on the code: > +(defcustom

[PATCH] emacs: Allow user to choose "From" address when composing a new message.

2011-05-25 Thread Carl Worth
again, -Carl -- carl.d.worth at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110525/986943a8/attachment.pgp>

[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-05-25 Thread Carl Worth
/attachments/20110525/51a2c0fc/attachment.pgp>

[PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Austin Clements
On Wed, May 25, 2011 at 5:21 PM, Daniel Schoepe wrote: > On Wed, 25 May 2011 15:11:16 -0400, Austin Clements > wrote: >> So, perhaps something like >> >> (defcustom notmuch-hello-tag-list-counts nil >> ? "Method for generating counts displayed in the all tags list. >> >> This variable controls

New crypto patch series

2011-05-25 Thread Jameson Graef Rollins
Hi, folks. This is a series of patches that constitute a complete rework of notmuch crypto support (signature verification and decryption of PGP/MIME messages, with emacs ui support), including some relevant preparatory patches, on top of the notmuch/master branch at

[PATCH 03/11] Use empty strings instead of NULL in format_reply structure.

2011-05-25 Thread Jameson Graef Rollins
This keeps things consistent with notmuch-show, and prevents having to check for the existence of the field pointer for simple string output formats. --- notmuch-reply.c | 12 ++-- show-message.c |2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/notmuch-reply.c

[PATCH 05/11] test: new test-lib function to test for equality between files

2011-05-25 Thread Jameson Graef Rollins
We need to be able to test for the presence of a newline at the end of output. There's no good way to capture trailing newlines in bash, so redirecting output to a file is the next best thing. This new function should be used when testing for output that is expected to have trailing newlines.

[PATCH 01/11] Simplify reply_part function to eliminate redundant code paths.

2011-05-25 Thread Jameson Graef Rollins
This is the same logic but with less code. --- notmuch-reply.c | 41 ++--- 1 files changed, 14 insertions(+), 27 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index ab15650..5d72b1f 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -88,31

[PATCH 09/11] Add decryption of PGP/MIME-encrypted parts with --decrypt.

2011-05-25 Thread Jameson Graef Rollins
This adds support for decrypting PGP/MIME-encrypted parts to notmuch-show and notmuch-reply. The --decrypt option implies --verify. Once decryption (and possibly signature verification) is done, a new part_encstatus formatter is emitted, the part_sigstatus formatter is emitted, and the entire

[PATCH 02/11] Integrate reply_part_content function into reply_part function.

2011-05-25 Thread Jameson Graef Rollins
After the last patch to eliminate some redundant code paths in reply_part, the reply_part_content function was only being called once. Disolving the function and integrating its contents into the reply_part function makes things a little simpler, and frees up some name space that will be needed

[PATCH 07/11] test: add crypto tests for signature verification and decryption

2011-05-25 Thread Jameson Graef Rollins
This adds a new "crypto" test script to the test suite to test PGP/MIME signature verification and message decryption. Included here is a test GNUPGHOME with a test secret key (passwordless), and test for: * signing/verification * signing/verification with full owner trust * verification

[PATCH 06/11] test: add notmuch_show_sanitize_all function that is a little more aggressive.

2011-05-25 Thread Jameson Graef Rollins
The old notmuch_show_sanitize function only scrubed part of the filename. This one scrubs the full filename, as well as the message id. --- test/test-lib.sh |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 9e2e0b5..ae25635

[PATCH 04/11] Break up format->part function into part_start and part_content functions.

2011-05-25 Thread Jameson Graef Rollins
Future improvements (eg. crypto support) will require adding new part header. By breaking up the output of part headers from the output of part content, we can easily out new part headers with new formatting functions. --- notmuch-client.h |5 +- notmuch-reply.c | 13 --

[PATCH 10/11] emacs: Add support for PGP/MIME verification/decryption

2011-05-25 Thread Jameson Graef Rollins
A new emacs configuration variable "notmuch-crypto-process-mime" controls the processing of PGP/MIME signatures and encrypted parts. When this is set true, notmuch-query will use the notmuch show --decrypt flag to decrypt encrypted messages and/or calculate the sigstatus of signed messages. If

[PATCH 08/11] Add signature verification of PGP/MIME-signed parts with --verify.

2011-05-25 Thread Jameson Graef Rollins
This is primarily for notmuch-show, although the functionality is added to show-message. Once signatures are processed a new part_sigstatus formatter is emitted, and the entire multipart/signed part is replaced with the contents of the signed part. At the moment only a json part_sigstatus

[PATCH 11/11] tag signed/encrypted during notmuch new

2011-05-25 Thread Jameson Graef Rollins
This patch adds the tag "signed" to messages with any multipart/signed parts, and the tag "encrypted" to messages with any multipart/encrypted parts. This only occurs when messages are indexed during notmuch new, so a database rebuild is required to have old messages tagged. --- lib/index.cc

[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-05-25 Thread Carl Worth
s Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110525/864c9e60/attachment.pgp>

[PATCH] emacs: Make the queries used in the all-tags section

2011-05-25 Thread Carl Worth
available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110525/0ac6b12a/attachment.pgp>