[PATCH] smtp-dummy: clear sockaddr_in structure before use in bind()

2011-11-12 Thread Tomi Ollila
Any junk bytes in sockaddr_in structure before passing that to bind() system call may cause problems. --- Thanks Austin. Consistent style matters... And dropped the peer_addr setting after reading accept(2) namual page. test/smtp-dummy.c |1 + 1 files changed, 1 insertions(+), 0

Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-12 Thread Tomi Ollila
On Fri, 11 Nov 2011 21:49:41 -0500, Austin Clements amdra...@mit.edu wrote: Good idea, but this introduces a dependency on netcat. Would it work to simply kill the SMTP dummy? I cannot guarantee 6 nines of probability (but can guarantee as many eights as one migh wish ;) Socket buffering and

Re: [PATCH] smtp-dummy: clear sockaddr_in structure before use in bind()

2011-11-12 Thread David Bremner
On Sat, 12 Nov 2011 11:57:22 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: Any junk bytes in sockaddr_in structure before passing that to bind() system call may cause problems. --- Pushed the second version. d ___ notmuch mailing list

Re: [PATCH] test: do not hide test_emacs errors

2011-11-12 Thread David Bremner
On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Do not redirect test_emacs stderr to /dev/null. Test_emacs uses emacsclient(1) now and it does not print unwanted messages (like those from `message') to stderr. But it does print useful errors, e.g. when

Re: [PATCH] add `tag:' prefix to `--output=tags' results

2011-11-12 Thread David Bremner
On Thu, 30 Jun 2011 10:20:29 +0200, Pieter Praet pie...@praet.org wrote: Alter `do_search_tags()' to prepend each result with `tag:', and update affected test. This makes its output consistent with `do_search_threads()' and `do_search_messages()'. What do people think about this change?

Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-12 Thread Austin Clements
Quoth Tomi Ollila on Nov 12 at 12:02 pm: On Fri, 11 Nov 2011 21:49:41 -0500, Austin Clements amdra...@mit.edu wrote: Good idea, but this introduces a dependency on netcat. Would it work to simply kill the SMTP dummy? I cannot guarantee 6 nines of probability (but can guarantee as many

Re: [PATCH] exec emacs at the end of run_emacs script

2011-11-12 Thread Austin Clements
LGTM Quoth Tomi Ollila on Nov 11 at 1:43 am: In the last line of run_emacs, exec the emacs process. With one fork less the process list is (also) neater. --- test/test-lib.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh

Re: [PATCH 6/6] emacs: make `notmuch-search-operate-all' operate on threads, not messages

2011-11-12 Thread Austin Clements
Quoth David Bremner on Nov 12 at 11:13 am: On Sun, 10 Jul 2011 17:55:35 +0200, Pieter Praet pie...@praet.org wrote: In order to be consistent with `notmuch-search-{add,remove}-tag' (+/-), `notmuch-search-operate-all' (*) should operate on matching threads instead of matching messages.

Re: [PATCH 0/4] Several minor Emacs enhancements

2011-11-12 Thread David Bremner
On Mon, 3 Oct 2011 14:03:54 +0200, Thomas Jost schno...@schnouki.net wrote: - The first one adds a face for crypto parts headers, because a hardcoded blue foreground looks quite ugly with my color theme. - The second one creates a customizable notmuch-mua-switch-function, which is then

Re: [PATCH] test: do not hide test_emacs errors

2011-11-12 Thread Tomi Ollila
On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner da...@tethera.net wrote: On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Do not redirect test_emacs stderr to /dev/null. Test_emacs uses emacsclient(1) now and it does not print unwanted messages (like

Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-12 Thread Tomi Ollila
On Sat, 12 Nov 2011 10:41:28 -0500, Austin Clements amdra...@mit.edu wrote: Actually, since sending mail is synchronous, there shouldn't be any issues with buffering or timing. If Emacs successfully sends the message, it will wait for the OK response (`smtpmail-via-smtp'), which should

Re: [PATCH 2/2] emacs: Unbind M-RET as display of thread with crypto switch.

2011-11-12 Thread Jameson Graef Rollins
So for some reason this patch and the three that follow it were not pushed when the first was. They were all incorrectly marked in nmbug as being pushed well. I assume this was just an oversight. In any event, these should be pushed, since they normalize the behavior of this keybinding, and fix

Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-12 Thread Jameson Graef Rollins
On Sat, 12 Nov 2011 23:07:38 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: 1) add line { echo QUIT /dev/tcp/127.0.0.1/25025; } 2/dev/null I have no directory called /dev/tcp on my system. jamie. pgpQDhwBJFSC7.pgp Description: PGP signature

Re: [PATCH] test: Add a test script for notmuch tag

2011-11-12 Thread Jameson Graef Rollins
This seems like a pretty obviously important set of tests that was missing. Thanks, Austin. jamie. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test: stashing in notmuch-{show,search}

2011-11-12 Thread David Bremner
On Thu, 30 Jun 2011 10:23:23 +0200, Pieter Praet pie...@praet.org wrote: Should provide full test coverage of the stashing feature. I (finally) pushed this pair of patches. d ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH v3] contrib/nmbug: new script for sharing tags with a given prefix.

2011-11-12 Thread David Bremner
On Fri, 11 Nov 2011 10:08:15 -0500, David Bremner da...@tethera.net wrote: From: David Bremner brem...@debian.org The main idea is consider the notmuch database as analogous to the work-tree. A bare git repo is maintained in the users home directory, with a tree of the form

Re: [PATCH 2/2] emacs: Unbind M-RET as display of thread with crypto switch.

2011-11-12 Thread David Bremner
On Sat, 12 Nov 2011 13:12:31 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: So for some reason this patch and the three that follow it were not pushed when the first was. They were all incorrectly marked in nmbug as being pushed well. I assume this was just an oversight. In

Re: [PATCH] test: do not hide test_emacs errors

2011-11-12 Thread Dmitry Kurochkin
On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner da...@tethera.net wrote: On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Do not redirect test_emacs stderr to /dev/null. Test_emacs uses emacsclient(1) now and it does not print unwanted messages (like

[PATCH] test: use dtach(1) instead of screen(1) in emacs tests

2011-11-12 Thread Dmitry Kurochkin
On Fri, 11 Nov 2011 22:48:13 +0200, Tomi Ollila wrote: > dtach is simpler than screen and is not setuid/setgid program so > TMPDIR does not get cleared by dynamic loader when executed. > --- > > Updated version after discussion with DmitryKurochkin and amdragon > on IRC. Thank you. > Looks

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

2011-11-12 Thread Dmitry Kurochkin
Hi all. Any objections to this trivial patch? Can we get it pushed? Regards, Dmitry

[PATCH v3] contrib/nmbug: new script for sharing tags with a given prefix.

2011-11-12 Thread David Bremner
On Fri, 11 Nov 2011 18:43:38 -0800, Jameson Graef Rollins wrote: > On Fri, 11 Nov 2011 18:55:15 -0500, David Bremner > wrote: > At this point I actually think they're probably exactly the same > audience, aren't they? Isn't nmbug primarily aimed at notmuch > developers that are reading

Configure mail responses headers to use Gcc anddddd not Fcc header in Emacs

2011-11-12 Thread Olivier Berger
Hi. I'm using notmuch together with a local dovecot imap server, and with Gnus in Emacs. When sending mails from notmuch, I'd like to be able to have a nnimap+localdovecot:Sentmail added for instance, instead of a Fcc header. Is this possible ? I can see one way which would be to hack a brutal

[PATCH] smtp-dummy: clear sockaddr_in structure before use in bind()

2011-11-12 Thread Tomi Ollila
Any junk bytes in sockaddr_in structure before passing that to bind() system call may cause problems. --- Thanks Austin. Consistent style matters... And dropped the peer_addr setting after reading accept(2) namual page. test/smtp-dummy.c |1 + 1 files changed, 1 insertions(+), 0

[PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-12 Thread Tomi Ollila
On Fri, 11 Nov 2011 21:49:41 -0500, Austin Clements wrote: > Good idea, but this introduces a dependency on netcat. Would it work > to simply kill the SMTP dummy? I cannot guarantee 6 nines of probability (but can guarantee as many eights as one migh wish ;) Socket buffering and timing might

[PATCH] smtp-dummy: clear sockaddr_in structure before use in bind()

2011-11-12 Thread David Bremner
On Sat, 12 Nov 2011 11:57:22 +0200, Tomi Ollila wrote: > Any junk bytes in sockaddr_in structure before passing that > to bind() system call may cause problems. > --- Pushed the second version. d

[PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

2011-11-12 Thread David Bremner
On Tue, 8 Nov 2011 21:55:28 -0500, Austin Clements wrote: > Buffer redisplay requires traversing the buffer's invisibility spec > This change switches to using a single element buffer invisibility > spec. To un-hide authors, instead of removing an entry from the > invisibility spec, it simply

[PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:".

2011-11-12 Thread David Bremner
On Sun, 9 Oct 2011 15:35:48 -0700, Jameson Graef Rollins wrote: > This modifies the notmuch-show "c i" binding to yank just the > message-id to the kill-ring, without the "id:" prefix. This makes > this yank binding consistent with the rest of the yank bindings in > that they don't include any

[PATCH] add `tag:' prefix to `--output=tags' results

2011-11-12 Thread David Bremner
On Thu, 30 Jun 2011 10:20:29 +0200, Pieter Praet wrote: > Alter `do_search_tags()' to prepend each result with `tag:', > and update affected test. > > This makes its output consistent with `do_search_threads()' and > `do_search_messages()'. What do people think about this change? Personally I

[PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-12 Thread Austin Clements
Quoth Tomi Ollila on Nov 12 at 12:02 pm: > On Fri, 11 Nov 2011 21:49:41 -0500, Austin Clements > wrote: > > Good idea, but this introduces a dependency on netcat. Would it work > > to simply kill the SMTP dummy? > > I cannot guarantee 6 nines of probability (but can guarantee as many eights >

[PATCH 6/6] emacs: make `notmuch-search-operate-all' operate on threads, not messages

2011-11-12 Thread David Bremner
On Sun, 10 Jul 2011 17:55:35 +0200, Pieter Praet wrote: > In order to be consistent with `notmuch-search-{add,remove}-tag' ("+"/"-"), > `notmuch-search-operate-all' ("*") should operate on matching threads > instead of matching messages. > As far as I can tell, the follow-up series for the race

[PATCH] exec emacs at the end of run_emacs script

2011-11-12 Thread Austin Clements
LGTM Quoth Tomi Ollila on Nov 11 at 1:43 am: > In the last line of run_emacs, exec the emacs process. > With one fork less the process list is (also) neater. > --- > test/test-lib.sh |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/test/test-lib.sh

[PATCH 6/6] emacs: make `notmuch-search-operate-all' operate on threads, not messages

2011-11-12 Thread Austin Clements
Quoth David Bremner on Nov 12 at 11:13 am: > On Sun, 10 Jul 2011 17:55:35 +0200, Pieter Praet wrote: > > In order to be consistent with `notmuch-search-{add,remove}-tag' ("+"/"-"), > > `notmuch-search-operate-all' ("*") should operate on matching threads > > instead of matching messages. > > >

[PATCH 0/4] Several minor Emacs enhancements

2011-11-12 Thread David Bremner
On Mon, 3 Oct 2011 14:03:54 +0200, Thomas Jost wrote: > - The first one adds a face for crypto parts headers, because a hardcoded blue > foreground looks quite ugly with my color theme. > - The second one creates a customizable notmuch-mua-switch-function, which is > then passed to

[PATCH] test: do not hide test_emacs errors

2011-11-12 Thread Tomi Ollila
On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner wrote: > On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin gmail.com> wrote: > > Do not redirect test_emacs stderr to /dev/null. Test_emacs uses > > emacsclient(1) now and it does not print unwanted messages (like > > those from `message') to

[PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-12 Thread Tomi Ollila
On Sat, 12 Nov 2011 10:41:28 -0500, Austin Clements wrote: > > Actually, since sending mail is synchronous, there shouldn't be any > issues with buffering or timing. If Emacs successfully sends the > message, it will wait for the OK response (`smtpmail-via-smtp'), which > should indicate that

[PATCH 2/2] emacs: Unbind M-RET as display of thread with crypto switch.

2011-11-12 Thread Jameson Graef Rollins
documentation. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111112/eec86434/attachment.pgp>

[PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-12 Thread Jameson Graef Rollins
me: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2012/74c8baa0/attachment.pgp>

[PATCH] test: Add a test script for "notmuch tag"

2011-11-12 Thread Jameson Graef Rollins
This seems like a pretty obviously important set of tests that was missing. Thanks, Austin. jamie.

[PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:".

2011-11-12 Thread Jameson Graef Rollins
was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2012/04feaca3/attachment.pgp>

[PATCH] test: stashing in notmuch-{show,search}

2011-11-12 Thread David Bremner
On Thu, 30 Jun 2011 10:23:23 +0200, Pieter Praet wrote: > Should provide full test coverage of the stashing feature. > I (finally) pushed this pair of patches. d

[PATCH v3] contrib/nmbug: new script for sharing tags with a given prefix.

2011-11-12 Thread David Bremner
On Fri, 11 Nov 2011 10:08:15 -0500, David Bremner wrote: > From: David Bremner > > The main idea is consider the notmuch database as analogous to the > work-tree. A bare git repo is maintained in the users home directory, > with a tree of the form tags/$message-id/$tag I pushed a slightly

[PATCH 2/2] emacs: Unbind M-RET as display of thread with crypto switch.

2011-11-12 Thread David Bremner
On Sat, 12 Nov 2011 13:12:31 -0800, Jameson Graef Rollins wrote: > So for some reason this patch and the three that follow it were not > pushed when the first was. They were all incorrectly marked in nmbug as > being pushed well. I assume this was just an oversight. In any event, > these