Re: [PATCH] dump: Don't sort.

2011-11-20 Thread Petter Reinholdtsen
[Thomas Schwinge] +/* This used to use NOTMUCH_SORT_MESSAGE_ID. On 2011-10-29, a measurement + * on a 372981 messages instance showed that wall time can be reduced from + * 28 minutes (sorted by Message-ID) to 15 minutes (unsorted), the latter + * being much more

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-20 Thread Austin Clements
Quoth Dmitry Kurochkin on Nov 19 at 9:26 am: On Fri, 18 Nov 2011 23:59:57 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Nov 19 at 6:42 am: Hi Jamie. On Fri, 18 Nov 2011 17:58:52 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Sat,

Re: [PATCH] Don't link libnotmuch if libutil isn't linked in properly.

2011-11-20 Thread David Bremner
On Sun, 13 Nov 2011 11:34:42 -0500, Tom Prince tom.pri...@ualberta.net wrote: For some reason, on my machine, the link is picking up /usr/lib/libutil.so instead of util/libutil.a. This causes there to be undefined symbols in libnotmuch, making it unuseable. This patch causes the link to fail

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-20 Thread Dmitry Kurochkin
Hi Jameson. On Sat, 19 Nov 2011 02:49:43 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Sat, 19 Nov 2011 06:42:00 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: The parameters are there for a reason. They are part of the content-type and are needed to handle

Re: [PATCH v2] Output unmodified Content-Type header value for JSON format.

2011-11-20 Thread Dmitry Kurochkin
On Sat, 19 Nov 2011 08:59:29 -0400, David Bremner da...@tethera.net wrote: On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Before the change, notmuch used g_mime_content_type_to_string(3) function to output Content-Type header value. Turns out it

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-20 Thread Dmitry Kurochkin
On Sat, 19 Nov 2011 13:58:18 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Nov 19 at 9:26 am: On Fri, 18 Nov 2011 23:59:57 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Nov 19 at 6:42 am: Hi Jamie. On Fri, 18 Nov 2011

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-20 Thread Jameson Graef Rollins
On Sun, 20 Nov 2011 22:32:53 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Yes, at least in most cases. On the other hand, if you can make notmuch show raw multipart part (you can, right?), then it seems natural that notmuch provides enough information to parse it. This is kind

[PATCH] fix a double // to single /

2011-11-20 Thread Florian Friesdorf
--- test/raw |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/raw b/test/raw index b7e265a..99d3a3b 100755 --- a/test/raw +++ b/test/raw @@ -1,4 +1,4 @@ -#!/usr//bin/env bash +#!/usr/bin/env bash test_description='notmuch show --format=raw' . ./test-lib.sh --

[PATCH] emacs: Don't record undo information for search or show buffers.

2011-11-20 Thread Austin Clements
There's no reason to record undo information for read-only, programmatically-constructed buffers. The undo list just chews up memory keeping track of our calls to insert. --- emacs/notmuch-show.el |2 ++ emacs/notmuch.el |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff

[PATCH] emacs: Avoid unnecessary markers.

2011-11-20 Thread Austin Clements
This is just cleanup. These markers are all immediately resolved to points by Emacs, so using markers here is just unncessary overhead. --- I originally did this for performance, since Emacs has to scan all un-GC'd markers on every buffer change, but it turns out to matter notmuch.

Re: [PATCH] emacs: Don't record undo information for search or show buffers.

2011-11-20 Thread Dmitry Kurochkin
On Sun, 20 Nov 2011 20:00:55 -0500, Austin Clements amdra...@mit.edu wrote: There's no reason to record undo information for read-only, programmatically-constructed buffers. The undo list just chews up memory keeping track of our calls to insert. Makes sense and looks good! Regards, Dmitry

Re: [PATCH] emacs: Avoid unnecessary markers.

2011-11-20 Thread Dmitry Kurochkin
On Sun, 20 Nov 2011 20:07:02 -0500, Austin Clements amdra...@mit.edu wrote: This is just cleanup. These markers are all immediately resolved to points by Emacs, so using markers here is just unncessary overhead. --- I originally did this for performance, since Emacs has to scan all un-GC'd

Re: [PATCH] emacs: breakout notmuch-show-advance functionality from notmuch-show-advance-and-archive

2011-11-20 Thread David Bremner
On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: This patch breaks out much of the functionality of notmuch-show-advance-and-archive into a new function: notmuch-show-advance. This new function does all the advancing through a show buffer that

Re: [PATCH] emacs: logically group def{custom,face}s

2011-11-20 Thread David Bremner
On Tue, 01 Nov 2011 21:00:28 +0100, Pieter Praet pie...@praet.org wrote: Thanks for testing, Daniel and Jameson! It still applies cleanly, so if there's anything preventing it from being merged in, I'd like to hear about it. Oops. Some time in the last few weeks, it stopped applying

[PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-20 Thread Dmitry Kurochkin
Hi Jameson. On Sat, 19 Nov 2011 02:49:43 -0800, Jameson Graef Rollins wrote: > On Sat, 19 Nov 2011 06:42:00 +0400, Dmitry Kurochkin gmail.com> wrote: > > The parameters are there for a reason. They are part of the > > content-type and are needed to handle the body properly. If you say > >

[PATCH v2] Output unmodified Content-Type header value for JSON format.

2011-11-20 Thread Dmitry Kurochkin
On Sat, 19 Nov 2011 08:59:29 -0400, David Bremner wrote: > On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin gmail.com> wrote: > > Before the change, notmuch used g_mime_content_type_to_string(3) > > function to output Content-Type header value. Turns out it outputs > > only "type/subtype"

[PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-20 Thread Dmitry Kurochkin
On Sat, 19 Nov 2011 13:58:18 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Nov 19 at 9:26 am: > > On Fri, 18 Nov 2011 23:59:57 -0500, Austin Clements > > wrote: > > > Quoth Dmitry Kurochkin on Nov 19 at 6:42 am: > > > > Hi Jamie. > > > > > > > > On Fri, 18 Nov 2011 17:58:52

[PATCH] fix a double // to single /

2011-11-20 Thread Florian Friesdorf
--- test/raw |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/raw b/test/raw index b7e265a..99d3a3b 100755 --- a/test/raw +++ b/test/raw @@ -1,4 +1,4 @@ -#!/usr//bin/env bash +#!/usr/bin/env bash test_description='notmuch show --format=raw' . ./test-lib.sh --

[PATCH] emacs: Don't record undo information for search or show buffers.

2011-11-20 Thread Austin Clements
There's no reason to record undo information for read-only, programmatically-constructed buffers. The undo list just chews up memory keeping track of our calls to insert. --- emacs/notmuch-show.el |2 ++ emacs/notmuch.el |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff

[PATCH] emacs: Avoid unnecessary markers.

2011-11-20 Thread Austin Clements
This is just cleanup. These markers are all immediately resolved to points by Emacs, so using markers here is just unncessary overhead. --- I originally did this for performance, since Emacs has to scan all un-GC'd markers on every buffer change, but it turns out to matter notmuch.

[PATCH] emacs: breakout notmuch-show-advance functionality from notmuch-show-advance-and-archive

2011-11-20 Thread David Bremner
On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins wrote: > This patch breaks out much of the functionality of > notmuch-show-advance-and-archive into a new function: > notmuch-show-advance. This new function does all the advancing > through a show buffer that

[PATCH] emacs: logically group def{custom,face}s

2011-11-20 Thread David Bremner
On Tue, 01 Nov 2011 21:00:28 +0100, Pieter Praet wrote: > > Thanks for testing, Daniel and Jameson! > > It still applies cleanly, so if there's anything preventing it from > being merged in, I'd like to hear about it. > Oops. Some time in the last few weeks, it stopped applying cleanly. d