Re: [PATCH v2 4/4] emacs: Use the new JSON reply format.

2012-01-17 Thread David Edmondson
Much nicer now that it uses the mm stuff. On Mon, 16 Jan 2012 11:13:23 -0700, Adam Wolfe Gordon wrote: > +(defun find-parts (parts type) Sorry for being a nuisance - this needs a name that indicates that it relates to notmuch. How about `notmuch-parts-filter-by-type'? > + "Return a list of me

Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Mark Walters
> > I wonder if the "problem" comes from me doing things in a non-lispy > > fashion (I am completely new to lisp). Thus > > notmuch-show-part-button-default-action is a variable that gets passed > > around rather than a function. > > Sorry, I should have looked at the bigger context in this patch

Re: how about message-citation-line-format (was: Re: [PATCH v2 5/4] emacs: Add customization for the first line of quotes.)

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 08:17:49 +0100, Gregor Zattler wrote: > Hi Adam, notmuch developers, > * Adam Wolfe Gordon [16. Jan. 2012]: > > Add a customization option, notmuch-mua-reply-quoth, which controls > > the first line of the reply body (typically, "On %date%, %from% wrote:"). > > This allows use

Re: [PATCH v2 3/3] search: Support automatic tag exclusions

2012-01-17 Thread David Edmondson
On Mon, 16 Jan 2012 15:16:24 -0700, Jeremy Nickurak wrote: > On Mon, Jan 16, 2012 at 12:28, Austin Clements wrote: > >> Having "deleted" and "spam" as default settings in the configuration > >> file might be more reasonable. > > If I read correctly: > > 1) If no exclude options are in the confi

Re: [PATCH] emacs: Improved printing support.

2012-01-17 Thread David Edmondson
On Mon, 16 Jan 2012 16:27:06 -0500, Aaron Ecay wrote: > > +;; > > The above is just a stray comment line, right? I tend to use them as spacers, but, sure. > > +(defun notmuch-show-with-message-as-text (fn) > > + "Apply function `fn' to a text representation of the current > > +message." > > I

Re: Emacs: Crypto: How to get automatic encryption?

2012-01-17 Thread David Edmondson
On Mon, 16 Jan 2012 23:48:30 -0500, Antoine Beaupré wrote: > Jumping in here, I have modified the previously posted code here to > provide me with a more complete solution. This looks good. I'll switch over to using it. > Code is attached. Obviously, those function names would change if they >

Re: [PATCH] Add pseudo-compatibility with gmime 2.6

2012-01-17 Thread Adrian Perez
Hi, On Tue, 17 Jan 2012 00:56:39 +0100, Thomas Jost wrote: > There are lots of API changes in gmime 2.6 crypto handling. By adding > preprocessor directives, it is however possible to add gmime 2.6 compatibility > while preserving compatibility with gmime 2.4 too. This approach is better than

Re: [PATCH] Add pseudo-compatibility with gmime 2.6

2012-01-17 Thread Adrian Perez
Hi, Just a couple of comments inline :) On Mon, 16 Jan 2012 22:47:14 -0500, Austin Clements wrote: > Quoth Thomas Jost on Jan 17 at 12:56 am: > > There are lots of API changes in gmime 2.6 crypto handling. By adding > > preprocessor directives, it is however possible to add gmime 2.6 > > comp

Re: [PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files

2012-01-17 Thread Tomi Ollila
On Mon, 16 Jan 2012 23:32:00 -0500, Austin Clements wrote: > Cleanup is the type of pain that should only be suffered once, so I'd > be much happier with this if there was an accompanying git hook that > prevented more mis-formatted code from slipping in. We'd need a script to be called from .git

Re: [PATCH] Add pseudo-compatibility with gmime 2.6

2012-01-17 Thread Thomas Jost
On Mon, 16 Jan 2012 22:47:14 -0500, Austin Clements wrote: > Quoth Thomas Jost on Jan 17 at 12:56 am: > > There are lots of API changes in gmime 2.6 crypto handling. By adding > > preprocessor directives, it is however possible to add gmime 2.6 > > compatibility > > while preserving compatibility

[PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6

2012-01-17 Thread Thomas Jost
There are lots of API changes in gmime 2.6 crypto handling. By adding preprocessor directives, it is however possible to add gmime 2.6 compatibility while preserving compatibility with gmime 2.4 too. This is mostly based on id:"8762i8hrb9@bookbinder.fernseed.info". This was tested against bot

[PATCH v2 1/2] show: don't use hex literals in JSON output

2012-01-17 Thread Thomas Jost
JSON does not support hex literals (0x..) so numbers must be formatted as %d instead of %x. --- notmuch-show.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index d14dac9..91f566c 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -641,7

[PATCH] NEWS: consistent 2-space indentation

2012-01-17 Thread Tomi Ollila
In NEWS file, indentation for item descriptions is generally 2 spaces but in a few cases there were 3 or 4 (4 caused different markdown handling) space indentations. Indentation in those lines are brought to consistent 2-space indentation. --- NEWS | 16 1 files changed, 8 inser

Re: [PATCH] NEWS: consistent 2-space indentation

2012-01-17 Thread David Bremner
On Tue, 17 Jan 2012 13:00:15 +0200, Tomi Ollila wrote: > In NEWS file, indentation for item descriptions is generally 2 spaces > but in a few cases there were 3 or 4 (4 caused different markdown > handling) space indentations. Indentation in those lines are brought > to consistent 2-space indentat

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-17 Thread David Bremner
On Tue, 17 Jan 2012 07:22:42 +, David Edmondson wrote: > On Mon, 16 Jan 2012 18:21:24 -0400, David Bremner wrote: > > I'm leaning to revert this patch. Any opposition? > > Please revert it and I'll investigate further. Reverted. d ___ notmuch mai

[PATCH] Start devel directory for developer tools and documentation.

2012-01-17 Thread David Bremner
From: David Bremner We had a lot of back and forth about the name of this directory, but nothing very conclusive. In the end, I just chose "devel" just to move on. --- RELEASING => devel/RELEASING |0 TODO => devel/TODO |0 2 files changed, 0 insertions(+), 0 deletions(-) rena

Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6

2012-01-17 Thread Tomi Ollila
On Tue, 17 Jan 2012 11:50:53 +0100, Thomas Jost wrote: > There are lots of API changes in gmime 2.6 crypto handling. By adding > preprocessor directives, it is however possible to add gmime 2.6 compatibility > while preserving compatibility with gmime 2.4 too. > > This is mostly based on id:"8762

[PATCH 1/4] test: Add `test_emacs_expect_t'.

2012-01-17 Thread David Edmondson
Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes two arguments: - the name of the test, - some lisp to evaluate. The test passes if the lisp returns `t', otherwise it fails and the output is reported to the tester. --- test/emacs-test-funct

[PATCH 3/4] emacs: Avoid `mail-header-parse-address' in `notmuch-show-clean-address'.

2012-01-17 Thread David Edmondson
`mail-header-parse-address' expects un-decoded mailbox parts, which is not what we have at this point. Replace it with simple string deconstruction. --- emacs/notmuch-show.el | 48 +++- 1 files changed, 35 insertions(+), 13 deletions(-) diff --git a/e

emacs based tests, version 3

2012-01-17 Thread David Edmondson
Taking Dmitry's suggestions on board. The end result does indeed feel better, thanks! [PATCH 1/4] test: Add `test_emacs_expect_t'. [PATCH 2/4] test: Add address cleaning tests. [PATCH 3/4] emacs: Avoid `mail-header-parse-address' in [PATCH 4/4] emacs: Another special case for _

[PATCH 4/4] emacs: Another special case for `notmuch-show-clean-address'.

2012-01-17 Thread David Edmondson
Remove backslashes. --- emacs/notmuch-show.el| 14 +- test/address-cleaning.el |6 -- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 8b2fbb3..90c9c05 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuc

[PATCH 2/4] test: Add address cleaning tests.

2012-01-17 Thread David Edmondson
Including some more test framework in test-lib.el. --- test/address-cleaning.el | 29 + test/address-cleaning.sh | 11 +++ test/notmuch-test|1 + test/test-lib.el | 29 + 4 files changed, 70 insertions(+), 0

Re: [PATCH 1/4] test: Add `test_emacs_expect_t'.

2012-01-17 Thread Dmitry Kurochkin
On Tue, 17 Jan 2012 12:52:25 +, David Edmondson wrote: > Add a new test function to allow simpler testing of emacs > functionality. > > `test_emacs_expect_t' takes two arguments: > - the name of the test, > - some lisp to evaluate. > > The test passes if the lisp returns `t', otherwise i

Re: [PATCH 2/4] test: Add address cleaning tests.

2012-01-17 Thread Dmitry Kurochkin
On Tue, 17 Jan 2012 12:52:26 +, David Edmondson wrote: > Including some more test framework in test-lib.el. > --- > test/address-cleaning.el | 29 + > test/address-cleaning.sh | 11 +++ > test/notmuch-test|1 + > test/test-lib.el |

Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6

2012-01-17 Thread Thomas Jost
On Tue, 17 Jan 2012 14:48:34 +0200, Tomi Ollila wrote: > On Tue, 17 Jan 2012 11:50:53 +0100, Thomas Jost wrote: > > There are lots of API changes in gmime 2.6 crypto handling. By adding > > preprocessor directives, it is however possible to add gmime 2.6 > > compatibility > > while preserving co

Re: [PATCH 2/4] test: Add address cleaning tests.

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 17:11:58 +0400, Dmitry Kurochkin wrote: > Since test/ directory is used for all kind of tests not just Emacs > UI-specific, so I think address-cleaning.* files should be > emacs-address-cleaning. Okay. pgpjWFrQsKV9M.pgp Description: PGP signature ___

Re: [PATCH 1/4] test: Add `test_emacs_expect_t'.

2012-01-17 Thread David Edmondson
(And one for the list...) On Tue, 17 Jan 2012 17:09:35 +0400, Dmitry Kurochkin wrote: > -1 > > This is not what I suggested. I do not like the approach when a single > function is used to both declare a subtest and test for result (as > opposed to test_begin_subtest). The fact that it is poss

[PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-17 Thread Dmitry Kurochkin
This makes `show-trailing-whitespace' happy, i.e. it does not mark the whole search box line as trailing spaces. Since the dot is invisible, this change makes no visible difference for `notmuch-hello'. --- emacs/notmuch-hello.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/2] emacs: fix typo in notmuch-hello

2012-01-17 Thread Dmitry Kurochkin
--- emacs/notmuch-hello.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index a71f3ce..aed1fb3 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -509,7 +509,7 @@ Complete list of currently available key

[PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

2012-01-17 Thread David Edmondson
--- test/test-lib.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index d1fbc05..7c9ce24 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -926,7 +926,7 @@ test_emacs () { --eval '(orphan-watchdo

[PATCH 3/3] test: Add address cleaning tests.

2012-01-17 Thread David Edmondson
Including some more test framework in test-lib.el. --- notmuch-test-address-cleaning-3 currently fails, in order that you can see the output format in that case. test/emacs-address-cleaning.el | 29 + test/emacs-address-cleaning.sh | 12 test/notmuch-

[PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-17 Thread David Edmondson
Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes one argument - a list expression to evaluate. The test passes if the expression returns `t', otherwise it fails and the output is reported to the tester. --- Re-worked as Dmitry suggested. test/

Re: [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 17:24:45 +0400, Dmitry Kurochkin wrote: > This makes `show-trailing-whitespace' happy, i.e. it does not mark the > whole search box line as trailing spaces. Why should `whitespace-mode' be active in `notmuch-hello' buffers? pgpEE8lecgUob.pgp Description: PGP signature _

Re: [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-17 Thread Dmitry Kurochkin
On Tue, 17 Jan 2012 14:08:58 +, David Edmondson wrote: > On Tue, 17 Jan 2012 17:24:45 +0400, Dmitry Kurochkin > wrote: > > This makes `show-trailing-whitespace' happy, i.e. it does not mark the > > whole search box line as trailing spaces. > > Why should `whitespace-mode' be active in `notm

Re: [PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

2012-01-17 Thread Dmitry Kurochkin
Can you please elaborate why this is needed? Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 18:13:26 +0400, Dmitry Kurochkin wrote: > On Tue, 17 Jan 2012 14:08:58 +, David Edmondson wrote: > > On Tue, 17 Jan 2012 17:24:45 +0400, Dmitry Kurochkin > > wrote: > > > This makes `show-trailing-whitespace' happy, i.e. it does not mark the > > > whole search box line

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-17 Thread Dmitry Kurochkin
On Tue, 17 Jan 2012 14:07:03 +, David Edmondson wrote: > Add a new test function to allow simpler testing of emacs > functionality. > > `test_emacs_expect_t' takes one argument - a list expression to > evaluate. The test passes if the expression returns `t', otherwise it > fails and the outpu

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 18:26:41 +0400, Dmitry Kurochkin wrote: > Sorry, I still do not understand why we can not implement > test_emacs_expect_t() like: > > result=${test_emacs $@} > test_expect_equal $result t > > Can you please explain? In the failure case test_expect_equal does: test_fa

Re: [PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

2012-01-17 Thread David Edmondson
(And for the list...) On Tue, 17 Jan 2012 18:20:04 +0400, Dmitry Kurochkin wrote: > Can you please elaborate why this is needed? This code: # wait until the emacs server is up until test_emacs '()' 2>/dev/null; do sleep 1

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-17 Thread Dmitry Kurochkin
On Tue, 17 Jan 2012 14:35:07 +, David Edmondson wrote: > On Tue, 17 Jan 2012 18:26:41 +0400, Dmitry Kurochkin > wrote: > > Sorry, I still do not understand why we can not implement > > test_emacs_expect_t() like: > > > > result=${test_emacs $@} > > test_expect_equal $result t > > > > C

Re: [PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

2012-01-17 Thread Dmitry Kurochkin
On Tue, 17 Jan 2012 14:37:52 +, David Edmondson wrote: > (And for the list...) > > On Tue, 17 Jan 2012 18:20:04 +0400, Dmitry Kurochkin > wrote: > > Can you please elaborate why this is needed? > > This code: > > # wait until the emacs server is up > un

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 18:49:36 +0400, Dmitry Kurochkin wrote: > > + # We cannot call 'test_emacs' in a subshell, because > > + # the setting of EMACS_SERVER would not persist > > + # throughout a sequence of tests, so we use a > > + # temporary file. > > +

Re: [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style

2012-01-17 Thread Tomi Ollila
On Tue, 10 Jan 2012 08:07:07 -0400, David Bremner wrote: > From: David Bremner > > Uncrustify is a free (as in GPL2+) tool that indents and beautifies > C/C++ code. It is similar to GNU indent in functionality although > probably more configurable (in fairness, indent has better > documentation)

Re: Emacs: Crypto: How to get automatic encryption?

2012-01-17 Thread David Edmondson
>(if (and force (re-search-forward "<#secure [> >]*>\n" nil t)) > (replace-match "" nil nil)) >;; If we can encrypt, do so, else just sign. >(if (or force (not (re-search-forward "<#secure [> >]*>\n" nil t))) Is this second test for `force' necessary? If `force' is

[PATCH v2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-17 Thread Dmitry Kurochkin
This makes `show-trailing-whitespace' happy, i.e. it does not mark the whole search box line as trailing spaces. Since the dot is invisible, this change makes no visible difference for `notmuch-hello'. --- emacs/notmuch-hello.el |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-)

Re: [PATCH v2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-17 Thread David Edmondson
+1. pgpAZYyk0EXbW.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 4/4] emacs: Use the new JSON reply format.

2012-01-17 Thread Adam Wolfe Gordon
Hi David, Thanks for the review. A couple of comments inline: On Tue, Jan 17, 2012 at 02:04, David Edmondson wrote: >> +    (insert "\n") >> +    (set-buffer-modified-p nil))) > > Is this newline always required? Is it the cause of the spurious blank > line down below? This is the cause of the

Re: how about message-citation-line-format (was: Re: [PATCH v2 5/4] emacs: Add customization for the first line of quotes.)

2012-01-17 Thread Adam Wolfe Gordon
On Tue, Jan 17, 2012 at 00:17, Gregor Zattler wrote: > I really missed this feature in notmuch.  There is already > message-citation-line-format which is part of message mode or > gnus and is not used in notmuch.  Wouldn't it be more consistent > to reuse this? Glad to hear someone would use the

Infinite loop in emacs interface

2012-01-17 Thread Rodney Lorrimar
Hi, Emacs notmuch is a really excellent mail program. But today I got an infinite loop in emacs 24.0.92.1 with notmuch (0.11 and master). It only happens when viewing a certain thread. There seem to be 2 problems: 1. the n and p keys (notmuch-show-{next,previous}-open-message) can't get past

Re: Infinite loop in emacs interface

2012-01-17 Thread Aaron Ecay
Rodney, After converting the mbox file to Maildir and adding it to my mailstore, I cannot reproduce the loop. (The versions of notmuch and emacs I used are close to the ones you have, but not an exact match, so it may be something subtle about those versions. I can investigate more carefully if

Re: [PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files

2012-01-17 Thread Austin Clements
Quoth Tomi Ollila on Jan 17 at 12:46 pm: > On Mon, 16 Jan 2012 23:32:00 -0500, Austin Clements wrote: > > Cleanup is the type of pain that should only be suffered once, so I'd > > be much happier with this if there was an accompanying git hook that > > prevented more mis-formatted code from slippi

Re: Partial words on notmuch search?

2012-01-17 Thread Jani Nikula
On Mon, 16 Jan 2012 21:34:31 -0500, Austin Clements wrote: > Quoth Andrei Popescu on Jan 16 at 10:21 pm: > > This is also interesting: > > $ notmuch count 'debian' > > 65888 > > $ notmuch count 'dEbian' > > 65888 > > $ notmuch count 'Debian' > > 65887 > > The first two will match stemmed versions

show-mode message/thread archiving improvements

2012-01-17 Thread Jameson Graef Rollins
I have reworked the show-mode message/thread archiving improvements from two now-obsolete patch sets: id:"1325975294-646-1-git-send-email-jroll...@finestructure.net" id:"1325986015-22510-1-git-send-email-jroll...@finestructure.net" All the "delete" stuff has been removed from this series, and I j

[PATCH 5/6] emacs: use pop-at-end functionality in show-archive-message-then-next function

2012-01-17 Thread Jameson Graef Rollins
This provides a smoother message processing flow by reducing the number of key presses needed for these common operations. --- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 6b2e6e9..21eadbe 100644

[PATCH 3/6] emacs: add message archiving functions

2012-01-17 Thread Jameson Graef Rollins
This adds two new message archiving functions that parallel the thread archiving functions: notmuch-show-archive-message{,-then-next}. The former also takes a prefix argument to unarchive the message (ie. put back in inbox). --- emacs/notmuch-show.el | 17 + 1 files changed, 17

[PATCH 6/6] emacs: modify the default show-mode key bindings for archiving

2012-01-17 Thread Jameson Graef Rollins
This changes the default key bindings for the 'a' key in notmuch-show mode. Instead of archiving the entire thread, it now just archives the current message, and then advance to the next open message (archive-message-then-next). 'A' is now bound to the previous archive-thread-then-next function.

[PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-17 Thread Jameson Graef Rollins
Brake up notmuch-show-archive-thread-internal into two new functions: notmuch-show-tag-thread-internal: applies a tag to all messages in thread. If option remove flag is t, tags will be removed instead of added. notmuch-show-next-thread: moves to the next thread in the search result. If given a

[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-17 Thread Jameson Graef Rollins
This will allow for keybindings that achieve a smoother message processing flow by reducing the number of key presses needed for most common operations. --- emacs/notmuch-show.el | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmu

[PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread

2012-01-17 Thread Jameson Graef Rollins
This function is now just for archiving the current thread. A new function is created to archive-then-next. The 'a' key binding is updated accordingly. This will allow people to bind to the simple thread archiving function without the extra navigation. The archive-thread function now also takes

[PATCH] fix .gitignore for gzipped man pages

2012-01-17 Thread Jani Nikula
--- .gitignore |1 - man/.gitignore |2 ++ 2 files changed, 2 insertions(+), 1 deletions(-) create mode 100644 man/.gitignore diff --git a/.gitignore b/.gitignore index d64ec9f..d428290 100644 --- a/.gitignore +++ b/.gitignore @@ -7,7 +7,6 @@ tags /notmuch notmuch.sym notmuch-shar

Re: [PATCH] fix .gitignore for gzipped man pages

2012-01-17 Thread Jameson Graef Rollins
+1. jamie. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: Infinite loop in emacs interface

2012-01-17 Thread Rodney Lorrimar
On Tue, 17 Jan 2012 12:37:52 -0500, Aaron Ecay wrote: > After converting the mbox file to Maildir and adding it to my mailstore, > I cannot reproduce the loop. (The versions of notmuch and emacs I used > are close to the ones you have, but not an exact match, so it may be > something subtle about

[PATCH] emacs: fix archive thread/message function documentation.

2012-01-17 Thread Jameson Graef Rollins
This removes an inaccuracy in the thread archiving function, and adds a clarification to the message archiving function. --- Late catch on some documentation inaccuracies. Apologies. emacs/notmuch-show.el | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/emacs/no

[PATCH] emacs: have notmuch-search-archive-thread use -next-thread function

2012-01-17 Thread Jameson Graef Rollins
Use this standard function, to keep thread navigation in one place. --- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index ef4dcc7..e4bca51 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -617,7 +617,7 @@ thr

Re: [PATCH] fix .gitignore for gzipped man pages

2012-01-17 Thread David Bremner
On Tue, 17 Jan 2012 20:16:03 +0200, Jani Nikula wrote: > --- > .gitignore |1 - > man/.gitignore |2 ++ pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

on deleting messages

2012-01-17 Thread Jameson Graef Rollins
Now that Austin's excellent tag exclusion patch set [0] has been pushed, the question remains if we want to support any delete-handling key bindings in emacs. Based on the show-mode improvements I recently sent [1], the following patch set implements thread and message delete keys. This is the la

[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

2012-01-17 Thread Jameson Graef Rollins
No functional change here. The help message previously referred to the "delete" tag, but "deleted" is now preferred, so hopefully this will reduce any potential confusion. --- emacs/notmuch.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch.el b/emacs/not

[PATCH 3/3] emacs: add delete key bindings for search and show mode.

2012-01-17 Thread Jameson Graef Rollins
This mimics the archiving keys ('a' and 'A'). --- emacs/notmuch-show.el |2 ++ emacs/notmuch.el |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 141241d..f0259d5 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notm

[PATCH 2/3] emacs: message/thread deletion by adding "deleted" tag

2012-01-17 Thread Jameson Graef Rollins
--- emacs/notmuch-show.el | 46 ++ emacs/notmuch.el |8 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index c1d721e..141241d 100644 --- a/emacs/notmuch-show.el +++ b/emac

[PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer

2012-01-17 Thread Dmitry Kurochkin
Before the change, "s" in notmuch-hello buffer would jump to the search box. The patch changes the binding to `notmuch-search' which is consistent with all other notmuch buffers. --- emacs/notmuch-hello.el | 19 ++- 1 files changed, 6 insertions(+), 13 deletions(-) diff --git a

[PATCH 2/3] emacs: use a single history for all searches

2012-01-17 Thread Dmitry Kurochkin
There are two ways to do search in Emacs UI: search widget in notmuch-hello buffer and `notmuch-search' function bound to "s". Before the change, these search mechanisms used different history lists. The patch makes notmuch-hello search use the same history list as `notmuch-search' function. ---

[PATCH 3/3] emacs: bind "s" to `notmuch-hello-search' in notmuch-hello buffer

2012-01-17 Thread Dmitry Kurochkin
`notmuch-hello-search' uses `notmuch-search' function but refreshes notmuch-hello buffer when the search buffer is closed. --- emacs/notmuch-hello.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index cb36977..e908659

Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-17 Thread Dmitry Kurochkin
Hello. On Mon, 16 Jan 2012 12:21:20 +, Jani Nikula wrote: > On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin > wrote: > > On Mon, 16 Jan 2012 11:35:37 +, David Edmondson wrote: > > > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin > > > wrote: > > > > Before the change, ther

Re: Partial words on notmuch search?

2012-01-17 Thread Austin Clements
Quoth Jani Nikula on Jan 17 at 7:43 pm: > On Mon, 16 Jan 2012 21:34:31 -0500, Austin Clements wrote: > > Quoth Andrei Popescu on Jan 16 at 10:21 pm: > > > This is also interesting: > > > $ notmuch count 'debian' > > > 65888 > > > $ notmuch count 'dEbian' > > > 65888 > > > $ notmuch count 'Debian'

Re: show-mode message/thread archiving improvements

2012-01-17 Thread Aaron Ecay
+1 on this series from me. (Minor comments on a couple of the patches to follow.) -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-17 Thread Aaron Ecay
On Tue, 17 Jan 2012 10:05:26 -0800, Jameson Graef Rollins wrote: > Brake up notmuch-show-archive-thread-internal into two new functions: > > notmuch-show-tag-thread-internal: applies a tag to all messages in > thread. If option remove flag is t, tags will be removed instead of > added. > > not

Re: [PATCH 3/6] emacs: add message archiving functions

2012-01-17 Thread Aaron Ecay
On Tue, 17 Jan 2012 10:05:28 -0800, Jameson Graef Rollins wrote: > This adds two new message archiving functions that parallel the thread > archiving functions: notmuch-show-archive-message{,-then-next}. The > former also takes a prefix argument to unarchive the message (ie. put > back in inbox)

Re: [PATCH] emacs: have notmuch-search-archive-thread use -next-thread function

2012-01-17 Thread Aaron Ecay
+1 -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-17 Thread Jameson Graef Rollins
On Tue, 17 Jan 2012 15:10:40 -0500, Aaron Ecay wrote: > This should be a docstring instead of a comment. (This applies equally > to the old version) We're not currently in the habit of adding doc strings for non-interactive programs. Do we need to go down that route? jamie. pgpxWGCN6f8xU

Re: [PATCH 3/6] emacs: add message archiving functions

2012-01-17 Thread Jameson Graef Rollins
On Tue, 17 Jan 2012 15:13:47 -0500, Aaron Ecay wrote: > If this function uses the prefix arg, its interactive call should be > “(interactive "P")”. This applies equally to the -thread variant in > patch 2/6, but I made the comment here because that diff doesn’t show > the function contiguously.

Re: on deleting messages

2012-01-17 Thread Jani Nikula
On Tue, 17 Jan 2012 11:01:45 -0800, Jameson Graef Rollins wrote: > Now that Austin's excellent tag exclusion patch set [0] has been pushed, > the question remains if we want to support any delete-handling key > bindings in emacs. > > Based on the show-mode improvements I recently sent [1], the f

Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Austin Clements
Quoth Mark Walters on Jan 17 at 9:06 am: > > > > I wonder if the "problem" comes from me doing things in a non-lispy > > > fashion (I am completely new to lisp). Thus > > > notmuch-show-part-button-default-action is a variable that gets passed > > > around rather than a function. > > > > Sorry,

Re: [PATCH v2 3/3] search: Support automatic tag exclusions

2012-01-17 Thread Austin Clements
Quoth David Edmondson on Jan 17 at 9:08 am: > On Mon, 16 Jan 2012 15:16:24 -0700, Jeremy Nickurak > wrote: > > On Mon, Jan 16, 2012 at 12:28, Austin Clements wrote: > > >> Having "deleted" and "spam" as default settings in the configuration > > >> file might be more reasonable. > > > > If I re

Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Mark Walters
> > I am happy to make that change. My original patch in the summer was more > > like that: > > id:"caludzswato+4mcuoomk+8vfs+pog-xuma6u-aqx2m6-sbyq...@mail.gmail.com" > > Is this the right id? I couldn't find it in the list archive. Sorry I messed up: it should be id:"87mxehqhbl.fsf@r102.confi

Re: [PATCH] Add pseudo-compatibility with gmime 2.6

2012-01-17 Thread Austin Clements
Quoth Thomas Jost on Jan 17 at 11:48 am: > On Mon, 16 Jan 2012 22:47:14 -0500, Austin Clements wrote: > > Quoth Thomas Jost on Jan 17 at 12:56 am: > > > This is mostly based on id:"8762i8hrb9@bookbinder.fernseed.info". > > > > > > This was tested against both gmime 2.6.4 and 2.4.31. With gmim

Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Aaron Ecay
On Tue, 17 Jan 2012 15:26:03 -0500, Austin Clements wrote: > Quoth Mark Walters on Jan 17 at 9:06 am: > > > > > > I wonder if the "problem" comes from me doing things in a non-lispy > > > > fashion (I am completely new to lisp). Thus > > > > notmuch-show-part-button-default-action is a variable

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-17 Thread Aaron Ecay
On Tue, 17 Jan 2012 12:17:54 -0800, Jameson Graef Rollins wrote: > > We're not currently in the habit of adding doc strings for > non-interactive programs. Do we need to go down that route? It is handy for developers, since the usual documentation facilities (describe-function, apropos, ...) w

Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Austin Clements
Quoth Mark Walters on Jan 17 at 8:39 pm: > > > I am happy to make that change. My original patch in the summer was more > > > like that: > > > id:"caludzswato+4mcuoomk+8vfs+pog-xuma6u-aqx2m6-sbyq...@mail.gmail.com" > > > > Is this the right id? I couldn't find it in the list archive. > > Sorry

Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer

2012-01-17 Thread Jani Nikula
On Tue, 17 Jan 2012 23:34:08 +0400, Dmitry Kurochkin wrote: > Before the change, "s" in notmuch-hello buffer would jump to the > search box. The patch changes the binding to `notmuch-search' which > is consistent with all other notmuch buffers. > --- > emacs/notmuch-hello.el | 19 ++--

Notmuch fails to build with gmime 2.6.4

2012-01-17 Thread hollunder
Hi there. I've seen gmime related discussion but it's hard to follow using a web interface, so here's my bug report. Arch Linux x86_64 gmime 2.6.4 notmuch git, last commit: 8ea82928b91e847298e4586f9db9734e727a418a Build error: CC -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=s

Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer

2012-01-17 Thread Dmitry Kurochkin
[of course I sent this email privately, sorry for duplicates] On Tue, 17 Jan 2012 23:22:30 +0200, Jani Nikula wrote: > On Tue, 17 Jan 2012 23:34:08 +0400, Dmitry Kurochkin > wrote: > > Before the change, "s" in notmuch-hello buffer would jump to the > > search box. The patch changes the bindin

Re: on deleting messages

2012-01-17 Thread Xavier Maillard
Hi, On Tue, 17 Jan 2012 11:01:45 -0800, Jameson Graef Rollins wrote: [ ... ] > Based on the show-mode improvements I recently sent [1], the following > patch set implements thread and message delete keys. > > This is the last I'm going to comment on this issue. If we don't want > to support

Improving notmuch query documentation [was: Re: Partial words on notmuch search?]

2012-01-17 Thread Andrei Popescu
On Lu, 16 ian 12, 21:34:31, Austin Clements wrote: > Quoth Andrei Popescu on Jan 16 at 10:21 pm: > > This is also interesting: > > $ notmuch count 'debian' > > 65888 > > $ notmuch count 'dEbian' > > 65888 > > $ notmuch count 'Debian' > > 65887 > > The first two will match stemmed versions of "debi

Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6

2012-01-17 Thread Austin Clements
Quoth Thomas Jost on Jan 17 at 11:50 am: > There are lots of API changes in gmime 2.6 crypto handling. By adding > preprocessor directives, it is however possible to add gmime 2.6 compatibility > while preserving compatibility with gmime 2.4 too. > > This is mostly based on id:"8762i8hrb9@book

Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Mark Walters
> In general, yes, I think so. A few comments on your draft below. Ok I include a newer version which I am fairly happy with but I do have some queries. > > +(defvar notmuch-show-part-button-map > > + (let ((map (make-sparse-keymap))) > > + (set-keymap-parent map button-map) > > +

Re: Improving notmuch query documentation [was: Re: Partial words on notmuch search?]

2012-01-17 Thread Austin Clements
Quoth Andrei Popescu on Jan 18 at 12:14 am: > On Lu, 16 ian 12, 21:34:31, Austin Clements wrote: > > Quoth Andrei Popescu on Jan 16 at 10:21 pm: > > > Where can I read more about this? (except the source :) > > > > Most of this is in the Xapian query syntax document you found. Really > > we ought

Re: Notmuch fails to build with gmime 2.6.4

2012-01-17 Thread Austin Clements
Quoth hollun...@lavabit.com on Jan 17 at 4:24 pm: > Hi there. I've seen gmime related discussion but it's hard to follow using > a web interface, so here's my bug report. There's a GMime 2.6 support patch that will probably make it into the master branch in the next day or two. Sorry for the inc

Re: Infinite loop in emacs interface

2012-01-17 Thread Rodney Lorrimar
Hi, Actually, this is starting to look like a problem with gnus in the latest emacs-snapshot. I didn't notice before, but when I view the thread, I get this error: Debugger entered--Lisp error: (void-variable gnus-inhibit-images) mm-shr((# ("text/html") nil nil nil nil nil nil)) mm-inline-te

[PATCH v2 4/5] emacs: Use the new JSON reply format.

2012-01-17 Thread Adam Wolfe Gordon
Using the new JSON reply format allows emacs to quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them. This is very useful for users who regularly receive HTML-only email. The behavior for messages that contain plain text parts should be unchanged.

[PATCH v2 5/5] emacs: Use message-citation-line-format in reply

2012-01-17 Thread Adam Wolfe Gordon
Instead of using a static citation line for the first line of the reply message, use the customizable one defined by message-mode. This makes it easy for users to customize the reply style, and retains consistency for users with existing message-mode customizations. The test has been updated to re

  1   2   3   >